From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B98B24541D; Thu, 13 Jun 2024 18:20:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4927F402CB; Thu, 13 Jun 2024 18:20:51 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3156E402BC for ; Thu, 13 Jun 2024 18:20:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718295649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PXTZNwieB5XON+tB8xCcd+sgHSPLpoTd3d4GklFMzk0=; b=X5yJySs4O97MWnzxALM4MNJ8X9LHXP7EpJkq7nZHk03R3Cj3/PEr4kifZpQFjuMD7b5TJI w28nVLy3c2psltaagg/CI6VTirKhagehQTOn+1hmjvNBzf1jlaCqAEiERLluQub5sOAGFQ r11TP0j7Ca69mUS/AGaQL6uHUtrx5IE= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-b7DYBYsaN4ieviFgTpTMHg-1; Thu, 13 Jun 2024 12:20:48 -0400 X-MC-Unique: b7DYBYsaN4ieviFgTpTMHg-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-52c89d6b3ebso910071e87.0 for ; Thu, 13 Jun 2024 09:20:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718295646; x=1718900446; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PXTZNwieB5XON+tB8xCcd+sgHSPLpoTd3d4GklFMzk0=; b=Fai8fP2EhQ3Wh8cfRZNOepA4nL/Ooi+Yl6eHm7Dax7IRMAnHT274QAa1zgoXnOfHgs m6qNuE96XsSbJB3XiysUJZCoz6Lftu7B8dhFYMeztj69zrnLTG4cXQ8lQDui+RbTtUDb zt2zpRWyWt8BHEdGxM6v4ZhHFld/YVycND5VRSauqTSwI3kknFg3FcS1p2yF0gKVrPL/ ESNo00l5MoAyO5fO52f9bcX3sCWE1/bYkueLVGoD5SWJtgGwomu9QcRS+tlKpii4lin9 nqPZ3tNEHHYa2990RAjcSgSoPXXZ7u9MaEApMWJJSzQC4AUoGrC7M128nBAluy1sSDmW GKYw== X-Gm-Message-State: AOJu0YytkZRkwx3mgn3pK62cEKu56ANPa/iAprfcAtikiuIl3CjR0cRq 0VcbBnnUajKC91BpEm4ru1ePoaQLSEwFph9TZdBoqYhnOQkBPZlLYnhUP1n5KOHbsrqdZ49Htyl Kx7bd9MrxW60sHvBMQxqXHSSksUFpqzA/PhvggqN7KG9VJf3JabmzbdLbAuY2PXNh6oNPNpJ10N 08Y6NpRak99Qmq5J8= X-Received: by 2002:a05:6512:3e06:b0:52c:9fd6:1b8a with SMTP id 2adb3069b0e04-52ca6e54ff0mr229227e87.8.1718295646561; Thu, 13 Jun 2024 09:20:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEG8GGt7X3MgAr+komfXKkURJR5UFwxadCmLvEsRi5QwL3t6OJoue9w7aGB2sQkox0hdhRNjuT3fE+pvSnmrsg= X-Received: by 2002:a05:6512:3e06:b0:52c:9fd6:1b8a with SMTP id 2adb3069b0e04-52ca6e54ff0mr229212e87.8.1718295646178; Thu, 13 Jun 2024 09:20:46 -0700 (PDT) MIME-Version: 1.0 References: <20240613161429.168287-1-ktraynor@redhat.com> In-Reply-To: <20240613161429.168287-1-ktraynor@redhat.com> From: David Marchand Date: Thu, 13 Jun 2024 18:20:34 +0200 Message-ID: Subject: Re: [PATCH] eal: fix logs for '--lcores' To: Kevin Traynor Cc: dev@dpdk.org, Tyler Retzlaff , Anatoly Burakov , Bruce Richardson , Marko Kovacevic X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 13, 2024 at 6:14=E2=80=AFPM Kevin Traynor = wrote: > > The argument is '--lcores' but it is being logged as '--lcore' > in several places. > > e.g. > $ dpdk-testpmd -l 8,10,12 --lcores 8,10,12 > EAL: Option --lcore is ignored, because (-l) is set! > > Fix the spelling in logs and tests. > > Fixes: 117eaa70584b ("eal: add error check for core options") and Fixes: 128ee4c26d87 ("app/test: add unit tests for --lcores option") (but no need for a v2 for this). > Signed-off-by: Kevin Traynor Reviewed-by: David Marchand Thanks for the quick fix. --=20 David Marchand