From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C87EA0526; Tue, 10 Nov 2020 13:43:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C42A7F64; Tue, 10 Nov 2020 13:43:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 16763DED for ; Tue, 10 Nov 2020 13:43:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605012192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=puZBoy9puZ/40fb/sIbVTp7T2FJu3tlqHJGUVkMbVUw=; b=RPE5nsG+tvtQ+cmyJ/4Hv2i6ZZOISLl3CEEx0RHDks2Cel1tULhdTINwUUZXJKhwnKniop 9RPPUEY3T7yEX3yxCRT5J7e01mrt16KXecBgaJuyosjG9zLzZNoXIOALprxLLrKV3bV7/8 baOWI2fw0yczaX/0JrTsJGyV/B8EKWY= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-501-4jVp6nQaPqa0B3vXz8uGqQ-1; Tue, 10 Nov 2020 07:43:08 -0500 X-MC-Unique: 4jVp6nQaPqa0B3vXz8uGqQ-1 Received: by mail-vk1-f197.google.com with SMTP id p81so1268547vkd.21 for ; Tue, 10 Nov 2020 04:43:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=puZBoy9puZ/40fb/sIbVTp7T2FJu3tlqHJGUVkMbVUw=; b=IU353Hpr11f0NcVdjRyfMLyPjK6vn70W29vjE/jI0+QsX3JHpzYLc/HXTwuY6qRSbw 11hKzeDySuTAYDWo3f1sBmX5H1nukjMwi5HtiqockilcVddmlXB5mtnMDwHZBa9gd5MD ZWNc5GG9lIrwNhYAb/Ksu6wMa1h+mq5I50awmi1VQBIM9gBkJSXCVeALEi0duo+wqp2n TI2RFKXwJxR+ie/fcB6ysAgEEWBweV/8nbC1E9E7mEzx/oR21nJ9gOP1XliS65QipgoS d8ejJ/ZtfnVASga90P1kN4r7o4ZHuFQPMv0xwIr7adnPiiwAgaYwK2GsL6Ov+33VV+ay QkBw== X-Gm-Message-State: AOAM533UGDcTtZRl4SwYnXdfFcGsBGPfSjD0VZVI0UlUc2kR9jDJj116 TPdJ1HeOYDpYCK8n6FHngrbORkrfiUPbHPmhTKRFVraeTvYx+HI73IJHJSLmHhXD5TPUc+n/7za 6tho/lWNdKz5G1I8V9lQ= X-Received: by 2002:a1f:d205:: with SMTP id j5mr10230725vkg.9.1605012188128; Tue, 10 Nov 2020 04:43:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzlrUn35nZHboQQtPLz2ShM/v9lJwBUhV9a/Y5auUTW4YOwE3OBBKVZwqRC0e5JYCY9ZYak+aiH8HsiA9q010= X-Received: by 2002:a1f:d205:: with SMTP id j5mr10230713vkg.9.1605012187942; Tue, 10 Nov 2020 04:43:07 -0800 (PST) MIME-Version: 1.0 References: <68ecd941-9c56-4de7-fae2-2ad15bdfd81a@alibaba-inc.com> <1603381885-88819-1-git-send-email-huawei.xhw@alibaba-inc.com> <0fefe2e6-1a4d-0579-4b59-92088bfaa276@alibaba-inc.com> In-Reply-To: <0fefe2e6-1a4d-0579-4b59-92088bfaa276@alibaba-inc.com> From: David Marchand Date: Tue, 10 Nov 2020 13:42:57 +0100 Message-ID: To: =?UTF-8?B?6LCi5Y2O5LyfKOatpOaXtuatpOWIu++8iQ==?= Cc: "ferruh.yigit" , dev , Maxime Coquelin , "Burakov, Anatoly" , Zhihong Wang , "Xia, Chenbo" , Gaetan Rivet , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 10, 2020 at 1:35 PM =E8=B0=A2=E5=8D=8E=E4=BC=9F(=E6=AD=A4=E6=97= =B6=E6=AD=A4=E5=88=BB=EF=BC=89 wrote: > Previously there are different ways to get port address based on > different DPDK uio driver(IGB_UIO/UIO_PCI_GENERIC/VFIO), which is > actually not necessary. > > This patch makes IO/MMIO port map/RW API more generic, which also > supports MMIO. It also fixes performance issue with vfio. > > Could you spare some time to have time to review this? This is too touchy and I don't want to mess virtio support this late in the release. I asked for Maxime to have a look, but he seems really busy. This will have to wait next release. --=20 David Marchand