From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3726FA0093;
Tue, 19 May 2020 17:36:09 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 15D071C2A3;
Tue, 19 May 2020 17:36:08 +0200 (CEST)
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 6EA741C2A0
for <dev@dpdk.org>; Tue, 19 May 2020 17:36:06 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1589902565;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=nJKyYnLSQ5dmkSSJyI5n74L7gGm7pgW0mYJhFvonr2A=;
b=Xh4LXXE58+LIIOavbihmEg3cCZ7m6sYGNSnOmbHuJ7KiNuWseAaM+6VuuKDBsRA1Hwl0lB
0t9X+SxjbgURuM69f5vVYhpEnTi7s4mhtjXAvjN8wJc1ivm8pJAcxqquYbybL9O3ZTHsxm
j/kyWa27BVvS7zTA4vBALefKrTu77l4=
Received: from mail-io1-f71.google.com (mail-io1-f71.google.com
[209.85.166.71]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-362-SYTuHVE_Mwe1SOsZ2U1pPw-1; Tue, 19 May 2020 11:36:03 -0400
X-MC-Unique: SYTuHVE_Mwe1SOsZ2U1pPw-1
Received: by mail-io1-f71.google.com with SMTP id n20so4065982iog.3
for <dev@dpdk.org>; Tue, 19 May 2020 08:36:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=nJKyYnLSQ5dmkSSJyI5n74L7gGm7pgW0mYJhFvonr2A=;
b=Q1d49sQQAOQZ3xpGl34K8Mvqmkp8x3/YwkcAhO01o/1QgPT3+IwKThxe7avmM/QjEf
6adU4QyosnEHyZ2U8uccn/wY623+SPla9WoV/UWlzk7tRm2LOvpVkcES8uKIpXUTrtwI
5X4Aw7ptwcHxV7A84kl3xe5z97F4RMEHlKG+8SgWTnhmHdeg1OD5Melf7A6S2CYXe42f
/kFi7spx5+CK74sCcBpyb6YsBRSWikWoYYLAw+/0r4AN7Lp4BPMzsAVqH9Z3N7yzmQNp
/EDi/cJneSVZa/Wa3cSQyPiByuwdO8JgsbtxUFzhwAt1KodDUpiPYYaOCubAB4ZxGHRd
KSiA==
X-Gm-Message-State: AOAM531Vilqlohj/1EWMF7ZnpxWjWLAaRSJUF6BkthgNhyHwRl9qAccr
eHh7RpMHCJpN9MHSu9jCXJdfd8JI05Blvv0QAJce782NBtr0eL3OojxzZEW+zOmWhzB1g2cr1yc
Q5O1y3V0AcWCzsROYQ+U=
X-Received: by 2002:a92:6c03:: with SMTP id h3mr21263028ilc.58.1589902562744;
Tue, 19 May 2020 08:36:02 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwYj2d+aUarxJj+z6P/q3qOpkhPLmobuPF6t649TxF3uDbyiDuoYRkbXGGLuegNrpBh8kv8pWUO/kdVpfb3oCE=
X-Received: by 2002:a92:6c03:: with SMTP id h3mr21263000ilc.58.1589902562415;
Tue, 19 May 2020 08:36:02 -0700 (PDT)
MIME-Version: 1.0
References: <20200430054606.92715-1-haiyue.wang@intel.com>
In-Reply-To: <20200430054606.92715-1-haiyue.wang@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 19 May 2020 17:35:51 +0200
Message-ID: <CAJFAV8zqOb0HnThcTgA5ndiSXUSPjKT5xJf2ARoj4hKMZeOEiw@mail.gmail.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Bruce Richardson <bruce.richardson@intel.com>, "Burakov,
Anatoly" <anatoly.burakov@intel.com>,
Neil Horman <nhorman@tuxdriver.com>, Ray Kinsella <mdr@ashroe.eu>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v1 1/2] devtools: add internal ABI version
check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, Apr 30, 2020 at 7:54 AM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> INTERNAL is new introduced version, update the shell script that checks
> whether built libraries are versioned with expected ABI (current ABI,
> current ABI + 1, EXPERIMENTAL, or INTERNAL).
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> devtools/check-abi-version.sh | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/devtools/check-abi-version.sh b/devtools/check-abi-version.sh
> index 9a3d13546..f0cca42a9 100755
> --- a/devtools/check-abi-version.sh
> +++ b/devtools/check-abi-version.sh
> @@ -4,7 +4,7 @@
>
> # Check whether library symbols have correct
> # version (provided ABI number or provided ABI
> -# number + 1 or EXPERIMENTAL).
> +# number + 1 or EXPERIMENTAL or INTERNAL).
> # Args:
> # $1: path of the library .so file
> # $2: ABI major version number to check
> @@ -12,7 +12,7 @@
>
> if [ -z "$1" ]; then
> echo "Script checks whether library symbols have"
> - echo "correct version (ABI_VER/ABI_VER+1/EXPERIMENTAL)"
> + echo "correct version (ABI_VER/ABI_VER+1/EXPERIMENTAL/INTERNAL)"
> echo "Usage:"
> echo " $0 SO_FILE_PATH [ABI_VER]"
> exit 1
> @@ -41,11 +41,11 @@ for SYM in $(echo "${OBJ_DUMP_OUTPUT}" | awk '{print $(NF-1) "-" $NF}')
> do
> version=$(echo $SYM | cut -d'-' -f 1)
> symbol=$(echo $SYM | cut -d'-' -f 2)
> - case $version in (*"$ABIVER"*|*"$NEXT_ABIVER"*|"EXPERIMENTAL")
> + case $version in (*"$ABIVER"*|*"$NEXT_ABIVER"*|"EXPERIMENTAL"|"INTERNAL")
> ;;
> (*)
> echo "Warning: symbol $symbol ($version) should be annotated " \
> - "as ABI version $ABIVER / $NEXT_ABIVER, or EXPERIMENTAL."
> + "as ABI version $ABIVER / $NEXT_ABIVER, EXPERIMENTAL, or INTERNAL."
> ret=1
> ;;
> esac
> --
> 2.26.2
>
LGTM + tested current master before and after the patch.
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand