From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93C6C41BAB; Thu, 2 Feb 2023 11:48:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E14442D9B; Thu, 2 Feb 2023 11:48:49 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C71F642D9B for ; Thu, 2 Feb 2023 11:48:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675334928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fic+u4b9SV7mMz3ZYOORcrI8sq9u+czGy5Ti6zzebQw=; b=h1MMVTJ4V3RK2l5eiNTcfAGz4mLf8GRrdSxA6v+aaOwITvjaPqotxsM2LnszV/rCcGHBdv fdoMdSydlvhezgqUz79K3PzBA88c1f67YU4kUoONm8OeQyQV6ORHQkhcS++uzR49yTsrWr AteTGnPdYhrpNcDh/XLA4ypDrK0yGYs= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-387-emHXXAxFNKyT61xf1d0-Tw-1; Thu, 02 Feb 2023 05:48:47 -0500 X-MC-Unique: emHXXAxFNKyT61xf1d0-Tw-1 Received: by mail-pf1-f199.google.com with SMTP id k22-20020a056a00169600b00593939d0601so809610pfc.5 for ; Thu, 02 Feb 2023 02:48:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fic+u4b9SV7mMz3ZYOORcrI8sq9u+czGy5Ti6zzebQw=; b=BEvCN5uaD29cIkrM1MHDbTLClDC5JwnSu1Apto5xVTdy7RlLODia1+4rxykNKSEkm5 A3L4/n/oV1+s0z7P+fQh4r79QWxsfIp6eVGQdTZaHufirgsTRNfS1imsk6DXOXp3Aeuy 2k8X2agsDNtYzlwc2DyUf42Ms6f7a7C+RLLF3S2vjkCoQDNej2WbxUx9aY7YbxEBYzY1 9Ftdjw19yZJfCcFT8OtSfveM61V5Qvxlauxh/Ip2D/3NmhehuG4q+MTXr9kopGmFcUri JBwCQB1y5/QmJ4wuUfSYUoXh3aezvnMA4q/bafuOiKk+cWS5mFAaRQ7uVD2YuuZ2+WeV Qj9A== X-Gm-Message-State: AO0yUKUyzu01ygHK6a7v9Jj/B+6LY9Vzy8afYGqpcb7W0mtuC/CKzTtn fwlDvRJuv5CPepiztje7WmVH20Eirv6yGF6UU0KdfKG42ZVhfakNkvZbZ+nR1iqQ52Mp2PQxoks kENivCrxkN6QsKbvwXI8= X-Received: by 2002:a17:90b:181:b0:227:104f:4497 with SMTP id t1-20020a17090b018100b00227104f4497mr465241pjs.68.1675334925988; Thu, 02 Feb 2023 02:48:45 -0800 (PST) X-Google-Smtp-Source: AK7set/UXYNaXYWlmObGelUK0q2TqCLiKevj7y1RYnJC+s5Y+ewbo94ZHng5EpJpec91p+nUGIQBMu3K6LON61T0iSk= X-Received: by 2002:a17:90b:181:b0:227:104f:4497 with SMTP id t1-20020a17090b018100b00227104f4497mr465235pjs.68.1675334925773; Thu, 02 Feb 2023 02:48:45 -0800 (PST) MIME-Version: 1.0 References: <20221230095853.1323616-1-nipun.gupta@amd.com> <20230104051936.2456411-1-nipun.gupta@amd.com> In-Reply-To: <20230104051936.2456411-1-nipun.gupta@amd.com> From: David Marchand Date: Thu, 2 Feb 2023 11:48:34 +0100 Message-ID: Subject: Re: [PATCH v2] vfio: do not coalesce DMA mappings To: anatoly.burakov@intel.com, Nipun Gupta Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, nikhil.agarwal@amd.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On Wed, Jan 4, 2023 at 6:19 AM Nipun Gupta wrote: > > At the cleanup time when dma unmap is done, linux kernel > does not allow unmap of individual segments which were > coalesced together while creating the DMA map for type1 IOMMU > mappings. So, this change updates the mapping of the memory > segments(hugepages) on a per-page basis. > > Signed-off-by: Nipun Gupta > Signed-off-by: Nikhil Agarwal This change is scary. I won't take it without a review from the maintainer. Anatoly, can you have a look? Thanks. -- David Marchand