From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E05EEA04FD; Mon, 4 Jul 2022 09:42:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDCC7410E5; Mon, 4 Jul 2022 09:42:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6EBB840E09 for ; Mon, 4 Jul 2022 09:42:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656920550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EhwYnzahFXXISGVd5lAp5EtknIZTIJTKdALbhum7NLM=; b=ZE6cF++SETuC24mEnoD+QQtiJLaYbM68OM3Hl6LYXDwvn3DhAo5skE62vRIShl3i+2ASU4 EmuOegSKTNVZD3di8rsWfdlv7xQ6H7OH2dokREZHS6n7whZQopYcVTvjp569+vZozD4xPf Uib2j0LlQDeel+/B9o1+iUk4GzE1apo= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-248-jW6M2582M7Sc9M80-0v7Sw-1; Mon, 04 Jul 2022 03:42:27 -0400 X-MC-Unique: jW6M2582M7Sc9M80-0v7Sw-1 Received: by mail-lf1-f72.google.com with SMTP id f29-20020a19dc5d000000b004811c8d1918so2743695lfj.2 for ; Mon, 04 Jul 2022 00:42:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EhwYnzahFXXISGVd5lAp5EtknIZTIJTKdALbhum7NLM=; b=7PGBDjL1dseuPts3bfb4IA0sdPiFz834wTZHLd2IHMJZfyIGiRO9ygS448LtSmu3yi P+ydK63g9LddyaUBqjv9EnActDwIwddPmVb89nXWgFut9JkOWZIIjw3WUjb62IlGqb2l OQaa355S1sCGHyxGLhYPzp1Zfv7W8Hr0TyivdHf74Dze4cGVuIX4putHkwJhRgzirxz8 FIONQNcFnjhkTH+zaBg8axKX57cWFYv+1eusvf37lqfEQ/R6SHKaWRDwmitOMO2wP9MB PvOuQ6L3wtc/b+jCRJx3PBRMfRPnZoDzqNT1mOpXHjySeGMG7nkRDNPnLv7WyyG7+XNs 28fA== X-Gm-Message-State: AJIora+78h60IyPng/6UtYU4ta8IlJBA0dbcjq8+93vJazaVQlthM9sd 0hb2qPhGqJO123FMVLHMa0kHE9f1cJnylmhwpN2gT3Xpho3IMbTOx7geCxexVZzc2WF+tf0tXCU 2Z61gVC42Via6e5KQvfk= X-Received: by 2002:ac2:4e97:0:b0:47f:b53b:4af5 with SMTP id o23-20020ac24e97000000b0047fb53b4af5mr17773754lfr.499.1656920546258; Mon, 04 Jul 2022 00:42:26 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uz7KUUgjP9IUWhDD06upKrTabp4gJUgnEblAPL+oZceUCGKQ0N0nLKVD0nSm35CUqQ1PYMIHfpf/Uh4wBcSxc= X-Received: by 2002:ac2:4e97:0:b0:47f:b53b:4af5 with SMTP id o23-20020ac24e97000000b0047fb53b4af5mr17773740lfr.499.1656920546051; Mon, 04 Jul 2022 00:42:26 -0700 (PDT) MIME-Version: 1.0 References: <20220704070428.2051264-1-yuanx.wang@intel.com> In-Reply-To: <20220704070428.2051264-1-yuanx.wang@intel.com> From: David Marchand Date: Mon, 4 Jul 2022 09:42:14 +0200 Message-ID: Subject: Re: [PATCH] net/virtio-user: restore callfds index for Rx interrupts To: Yuan Wang Cc: Maxime Coquelin , "Xia, Chenbo" , dev , Jiayu Hu , "He, Xingguang" , Cheng Jiang , Harman Kalra , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jul 4, 2022 at 9:11 AM Yuan Wang wrote: > > The callfds[] array stores eventfds sequentially for Rx and Tx vq. > > Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") > Cc: stable@dpdk.org > > Signed-off-by: Yuan Wang Good catch... This is what I had fixed in 848e93d9001e ("net/virtio-user: fix Rx interrupts with multi-queue"). I suppose the issue has been reintroduced when rebasing Harman series. > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c > index 35aa76b1ff..f9cada05e4 100644 > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c > @@ -417,7 +417,7 @@ virtio_user_fill_intr_handle(struct virtio_user_dev *dev) > > for (i = 0; i < dev->max_queue_pairs; ++i) { > if (rte_intr_efds_index_set(eth_dev->intr_handle, i, > - dev->callfds[i])) > + dev->callfds[2 * i + VTNET_SQ_RQ_QUEUE_IDX])) > return -rte_errno; > } Reviewed-by: David Marchand -- David Marchand