From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id BB06CA04C1;
Thu, 21 Nov 2019 17:23:20 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 10BAF2BA3;
Thu, 21 Nov 2019 17:23:20 +0100 (CET)
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 839A62BA2
for <dev@dpdk.org>; Thu, 21 Nov 2019 17:23:18 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1574353397;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=OwrowcRH17xaR15SjjM2FOkY9bfjtYCWY9+o+HbVqQo=;
b=cCRMIKBrqt+SmWzO13/+6+Uyorv3JyCPtn6IGbL7lZWIxHs8Lfse7HUTWzrOPqUJ2RcZBh
310uH9tFY6hGpscb8eTF/Ft5yp/0Oi2QsZS7ltE2KzJmlz+RtpjX+ERvvi9+jqe/RR+uY3
f3Ih50iJzip5yhsD1yE7sWOxhkY+EhM=
Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com
[209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-41-pZ8lEpVSPECbUaqH4_iTFA-1; Thu, 21 Nov 2019 11:23:15 -0500
Received: by mail-vk1-f199.google.com with SMTP id t128so1526160vkb.9
for <dev@dpdk.org>; Thu, 21 Nov 2019 08:23:15 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=wIR+nXiFglG1xm0aoF5IGmqnuse40MRurxdF6P6gF4c=;
b=t3hFaoJGfjfmNULfHsIR9rC9uwn8l4++Kqig32uHPQiUWM0v7uLTMjV0gBulNxUOLH
2fkZgRJafVCFK2QrNFj5oVYewSideG2Ex264cMePh46qt1BwNUkpaIhSe3rBdnPpg6bq
Rl7Julouv556KNNj1oPA72KYEQNe5GO8aa8yhayVXDJKbyuR3oNn38YDiORiukQtohgi
o8bYJqAsXNlUeGtOz0zEfJT230FbnPhx6i/NyrQ8I7P83CvvrJe6aEjPrzE2bWrYVwjY
GuTwjZ+/FoiqL8Jxxq0lsgK0OA49g9ZPHHOQjU3pE9aFzhGZ3AAjqxuHMSwnAy/T1AId
ozSQ==
X-Gm-Message-State: APjAAAXuPCHUkEiJBXLDGIWwsZTc1O3lFo6po1ylNxW5trpVQrSl1vR6
j5VhHlcYLc35/oPN9+qnJF7qyB2mZcpFz+A9N4etNuZ7tzRAckNBs6vC0rcYSDQA0vfWkWydXXt
vR4AaGcutZefrbEersGk=
X-Received: by 2002:a67:bd05:: with SMTP id y5mr6567181vsq.180.1574353395044;
Thu, 21 Nov 2019 08:23:15 -0800 (PST)
X-Google-Smtp-Source: APXvYqwIOxPnv6BdX+mw6EoUxDBfRPU9LquizPLzBYfJ7GL/+mjjD0UKr5riunwbOX0BdSH1RhgPB7lf8pOP+K53fCg=
X-Received: by 2002:a67:bd05:: with SMTP id y5mr6567154vsq.180.1574353394722;
Thu, 21 Nov 2019 08:23:14 -0800 (PST)
MIME-Version: 1.0
References: <20191121151256.20613-1-david.marchand@redhat.com>
<8055a2ec-42ef-30c2-5452-b0e8b92caa87@intel.com>
<CAJFAV8x_djX+-zuNcEg9+J6eT3OdN+fEsqpReut9he2yGMVNmg@mail.gmail.com>
In-Reply-To: <CAJFAV8x_djX+-zuNcEg9+J6eT3OdN+fEsqpReut9he2yGMVNmg@mail.gmail.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 21 Nov 2019 17:23:03 +0100
Message-ID: <CAJFAV8zre=JHGbNASu=QFUHoMTetgNptKG7jbs25HpXPVQkwdQ@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
X-MC-Unique: pZ8lEpVSPECbUaqH4_iTFA-1
X-Mimecast-Spam-Score: 0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: reduce memory consumption
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, Nov 21, 2019 at 5:17 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Thu, Nov 21, 2019 at 4:36 PM Ferruh Yigit <ferruh.yigit@intel.com> wro=
te:
> > > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
> > > index 90694a3309..217d577018 100644
> > > --- a/app/test-pmd/testpmd.h
> > > +++ b/app/test-pmd/testpmd.h
> > > @@ -58,8 +58,6 @@ typedef uint16_t portid_t;
> > > typedef uint16_t queueid_t;
> > > typedef uint16_t streamid_t;
> > >
> > > -#define MAX_QUEUE_ID ((1 << (sizeof(queueid_t) * 8)) - 1)
> >
> > No strong opinion, but would it be simpler if assign 'MAX_QUEUE_ID' to
> > 'RTE_MAX_QUEUES_PER_PORT' instead?
> > #define MAX_QUEUE_ID RTE_MAX_QUEUES_PER_PORT
>
> This was my first solution once I spotted this.
> But I prefer to globally replace: when reading this code, using
> MAX_QUEUE_ID leaves the impression that testpmd has its own
> restriction on max queue count.
Btw, not sure we want to backport this, or maybe up to branches
containing d44f8a485f5d ("app/testpmd: enable per queue configure")
Opinions?
--=20
David Marchand