From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4EC23A05D3 for ; Wed, 22 May 2019 14:40:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 885C54C80; Wed, 22 May 2019 14:40:53 +0200 (CEST) Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 6270010BD for ; Wed, 22 May 2019 14:40:52 +0200 (CEST) Received: by mail-ua1-f67.google.com with SMTP id e9so785785uar.9 for ; Wed, 22 May 2019 05:40:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C/X4plxzCYJSqcXbuySM1pGV+ksli7gjkAHqndnRShw=; b=YtpQp6AOCtDgiiwS73unUaKpHZjA4LYzbnttkCg5CuwM6A+OxlDdw1vpxhKgqaakjs KKEcHtJ01eKqVylhWNN5q0YqDYwa+TQrtIV2WF0+mXbSGCzb7t+6pS8j8TvfNw1OKT9X tlwf7Mq292tsdjS5d6u1wkSQs2w+PPRqtAMiTjyYDPeT7Cjrlfht5mwIxo5vWou4NZAc lzPZ9Z8BaplpcWYLynv9ZfH81Osd6/IbF8YgwhTwFfm2Bw2HYsRkjhQfSJV69v274q7P /c6eUoa2WY/SzEk/whanTumuQcmNbHHl3eD+qyhde9ePfhnlzQtstXeRy6Svo2lWmzPG /6kw== X-Gm-Message-State: APjAAAW6v7a2s6Ipyvlp/K2qsoxluV+P5oF7bxItkZaKjGLd9kfAjHu6 vbLpfPznUF6zebIq6Wfo5EIqf8EN+F3c4CPJtVynwA== X-Google-Smtp-Source: APXvYqx+Uf119W6GmO6jsFoUqpdUvjqwwyosnI+TXqwSg6xiRaw1Eh5TR2RaP3on905BeKkLAFdhc9ABuWpfRJQEows= X-Received: by 2002:ab0:2bc6:: with SMTP id s6mr8120622uar.86.1558528851706; Wed, 22 May 2019 05:40:51 -0700 (PDT) MIME-Version: 1.0 References: <1557907020-1548-1-git-send-email-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 22 May 2019 14:40:40 +0200 Message-ID: To: "Wang, Yipeng1" Cc: "dev@dpdk.org" , Dharmik Thakkar , "thomas@monjalon.net" , "stephen@networkplumber.org" , "stable@dpdk.org" , "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] test/hash: use existing lcore API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, On Wed, May 22, 2019 at 2:16 AM Wang, Yipeng1 wrote: > >-----Original Message----- > >From: David Marchand [mailto:david.marchand@redhat.com] > >Sent: Wednesday, May 15, 2019 12:57 AM > >To: dev@dpdk.org > >Cc: thomas@monjalon.net; stephen@networkplumber.org; stable@dpdk.org; > Wang, Yipeng1 ; Gobriel, > >Sameh ; Richardson, Bruce < > bruce.richardson@intel.com>; De Lara Guarch, Pablo > > > >Subject: [PATCH 1/2] test/hash: use existing lcore API > > > >Prefer the existing apis rather than direct access the configuration > >structure. > > > >Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency") > >Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket") > >Cc: stable@dpdk.org > > > >Signed-off-by: David Marchand > >--- > > app/test/test_hash_readwrite_lf.c | 29 ++++++++++++++--------------- > > 1 file changed, 14 insertions(+), 15 deletions(-) > > > > [Wang, Yipeng] > > Hi, David, I tested the patch and the test case seems now frozen after > running in the middle. Have you seen same thing? > > I include the original author Dharmik for the file for more reviews. > > > Output: > > " > .... > > Test: Hash add - key shift, Hash lookup - miss > > Number of readers: 1 > Cycles per lookup: 112 > > Number of readers: 2 > Cycles per lookup: 113 > > Number of readers: 4 > Cycles per lookup: 116 > > ** With bulk-lookup ** > > Number of readers: 1 > Cycles per lookup: 41 > > Number of readers: 2 > Cycles per lookup: 40 > > Number of readers: 4 > Cycles per lookup: 40 > > Test: Multi-add-lookup > > Number of writers: 2 > Number of readers: 1 > Cycles per lookup: 166 > > Number of writers: 2 > Number of readers: 2 > " > > Thanks for reporting. I reproduced the issue. I did not catch it as I was starting the test with 4 cores on my laptop. I will post a fix and/or an updated patch. -- David Marchand