From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61B2C4341F; Fri, 1 Dec 2023 14:11:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DCD7402AF; Fri, 1 Dec 2023 14:11:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 394244029C for ; Fri, 1 Dec 2023 14:11:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701436281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lqnQIum9UDLvCIIkWihRIM8c5JAaM+fSg8Im6gkyo/o=; b=gs5lC8FaSCtUii8BkA0t4QxE36wzqE/5+jiAHqtKCrnlUUvjy5bgmgqixNvGPNJr5t7twx X7CzUoqofVWxU9q56Uq7PY0YBqptGT84E3bnZLCs96kUlpDFKxcZhqYa64AmUjGFJ2U0lq e52x84mU8Wh3xj7bYbY3YQs41dhWEug= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-zwvBCsWcNZasXAE8jWBODQ-1; Fri, 01 Dec 2023 08:11:20 -0500 X-MC-Unique: zwvBCsWcNZasXAE8jWBODQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c9af182fc9so21983501fa.2 for ; Fri, 01 Dec 2023 05:11:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436278; x=1702041078; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lqnQIum9UDLvCIIkWihRIM8c5JAaM+fSg8Im6gkyo/o=; b=q2VVqkf+Q1RQ2og+yZlMknRY0KCaI1acrWb47qOdj/9jqyMJ9CUnQYLdH3HKPaOlpJ d9yuV9GQIQMxdI0jqa64iHEGYlRJE89gH/BQ9XhA/1SlhDAb8ZFNVxaMGn0jx/eWdIOI zeJkvDAiNhA5dUZBcyVM12BKNuVlMedswXnPF/9vHN2IWdaSXtTPgx9cGd9xs8nWG6DM fyx7bpGyb7FCnYEbjyzVOdMuO0nrSDXSJNBiohT3mnD+aKHdSl4/oOKTEVA14C0VOCQv 2w+91Udr2wRj9XbPcX/gk3vOi2ozQpGv0WeiyQiFSZUYiKmnMrvJK7tm76TAunuHq/7Y /59Q== X-Gm-Message-State: AOJu0YyMBUWrTrRymLk/06Fr1XFem+2dA3l+Qk11NUlcNkUyAUJHixFJ b8XkqbXxilNuTSEw9QUZTYg1xI/bGH4NOYzU4kD1rkjCrSHVFcfKfYeriHn+sY5/RJQmq9uVfzF qZ/zqvE8ZDGEn+FdqfRE= X-Received: by 2002:a2e:96c2:0:b0:2c9:c3d6:1035 with SMTP id d2-20020a2e96c2000000b002c9c3d61035mr853124ljj.15.1701436278595; Fri, 01 Dec 2023 05:11:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IG3ERPpNiQbmuTtB8cCgC8pxGlCkisg8t5tXAGPEc7OvW3GlhNB288usrxhaa23toT5S4hXatBUceCP3HyqyEw= X-Received: by 2002:a2e:96c2:0:b0:2c9:c3d6:1035 with SMTP id d2-20020a2e96c2000000b002c9c3d61035mr853119ljj.15.1701436278330; Fri, 01 Dec 2023 05:11:18 -0800 (PST) MIME-Version: 1.0 References: <20230208044825.1682620-1-stephen@networkplumber.org> <20230814163125.63033-1-stephen@networkplumber.org> <20230814163125.63033-2-stephen@networkplumber.org> In-Reply-To: From: David Marchand Date: Fri, 1 Dec 2023 14:11:06 +0100 Message-ID: Subject: Re: [PATCH v8 1/6] ip_frag: use a dynamic logtype To: Konstantin Ananyev Cc: Stephen Hemminger , "dev@dpdk.org" , Konstantin Ananyev , Anatoly Burakov , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Konstantin, On Fri, Dec 1, 2023 at 1:17=E2=80=AFPM Konstantin Ananyev wrote: > > Hi David, > > > On Mon, Aug 14, 2023 at 6:31=E2=80=AFPM Stephen Hemminger > > wrote: > > > @@ -52,20 +54,20 @@ rte_ip_frag_table_create(uint32_t bucket_num, uin= t32_t bucket_entries, > > > if (rte_is_power_of_2(bucket_entries) =3D=3D 0 || > > > nb_entries > UINT32_MAX || nb_entries =3D=3D = 0 || > > > nb_entries < max_entries) { > > > - RTE_LOG(ERR, USER1, "%s: invalid input parameter\n", = __func__); > > > + RTE_LOG(ERR, IPFRAG, "%s: invalid input parameter\n",= __func__); > > > return NULL; > > > } > > > > > > sz =3D sizeof (*tbl) + nb_entries * sizeof (tbl->pkt[0]); > > > if ((tbl =3D rte_zmalloc_socket(__func__, sz, RTE_CACHE_LINE_= SIZE, > > > socket_id)) =3D=3D NULL) { > > > - RTE_LOG(ERR, USER1, > > > + RTE_LOG(ERR, IPFRAG, > > > "%s: allocation of %zu bytes at socket %d fai= led do\n", > > > __func__, sz, socket_id); > > > return NULL; > > > } > > > > > > - RTE_LOG(INFO, USER1, "%s: allocated of %zu bytes at socket %d= \n", > > > + RTE_LOG(INFO, IPFRAG, "%s: allocated of %zu bytes at socket %= d\n", > > > __func__, sz, socket_id); > > > > > > tbl->max_cycles =3D max_cycles; > > > -- > > > 2.39.2 > > > > > > > Any reason not to use the IP_FRAG_LOG macro? > > This is easy for me to fix when applying if you have no objection. > > As I remember, IP_FRAG_LOG is disabled by default. > To enable it, user has to build it with -DRTE_LIBRTE_IP_FRAG_DEBUG or so. Indeed, so nothing to do here, thanks. --=20 David Marchand