From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C7FAA0A0C; Thu, 22 Jul 2021 22:30:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC8E940DF5; Thu, 22 Jul 2021 22:30:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 8FF174068C for ; Thu, 22 Jul 2021 22:29:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626985798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+jpY8bSRGZV6j7L8lHCLBbt7Kd+syzGUOfyjkbVWjqs=; b=Bl2DPVFcFfAZ5tLV+q9ux5BHfX3oU60KJ/sLx4hBD61DYeIOqKELItqyZ7OeVh4GTVlFpR zPQRQwIcqUmmvkHdaI6fMEK7q906g5EwUTczrgiq2nXsfseyJphap9SZEKVoTsom9XcYnJ zLPl+Wixqp8FEGujsHDn0PHxrIdqmPo= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-ZB9IgCBgNiKyFmIhVuavGA-1; Thu, 22 Jul 2021 16:29:57 -0400 X-MC-Unique: ZB9IgCBgNiKyFmIhVuavGA-1 Received: by mail-ua1-f72.google.com with SMTP id n3-20020a9f3ec30000b02902a1449fe0deso2596805uaj.18 for ; Thu, 22 Jul 2021 13:29:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+jpY8bSRGZV6j7L8lHCLBbt7Kd+syzGUOfyjkbVWjqs=; b=PnFCyk+DQ5d6fUOeP0v9FWg0JCC9/0oGJE97UH9QQn+1FQTXb1g6pUTT8E2eakD2Yt k2h1eD4EBUzyWnqJc+viLJ4Ol7IWsv3Her22KwcohqD9X/QyEJ5L9OgJh7nC8HDsZe+X zmuoIlMkkqqI4OTPN70UcQ76BFHxg3HvBZuZmp7NYRKjHEZeSS4W1pb+O4/d28ieII2v H8m4KL2Xw5rzw1hd6Pz1TKHATYaNqaGsVlDx1TAYBAsr/F9oPArnwA/jjYZViEheXkpB EhfQZjH1yi9AfEqPT3hPq0zXIntiWAtFj9sWrukfDTW/HUqSRTixy9UilWMnWKsmsfJV pVeg== X-Gm-Message-State: AOAM5338kIeQJyPEdjY+Z0h7oav8t1Pp/zbXHzd9ADwnWRQR/cHJTExF VV7bGUEq1nNxsfnHH08jLyHGYXUb4DcsVU6R7fEavGBSkizptAAN9Dz0e0/AI8Kcm/ErRgpY1zA DjAUGMDhb1zxRRBzp1K0= X-Received: by 2002:a67:f90c:: with SMTP id t12mr2471862vsq.27.1626985797136; Thu, 22 Jul 2021 13:29:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBm2kaoIBce9xPkZxPMb1xw7/7PC5Q9UaTBek7+dvamp0X2vO19aplhsPEQK8IL0fgyDmJF8Lpys3GTcXCp0M= X-Received: by 2002:a67:f90c:: with SMTP id t12mr2471851vsq.27.1626985796960; Thu, 22 Jul 2021 13:29:56 -0700 (PDT) MIME-Version: 1.0 References: <20210707230605.58a79a47@sovereign> <20210708105958.526656-1-john.levon@nutanix.com> In-Reply-To: <20210708105958.526656-1-john.levon@nutanix.com> From: David Marchand Date: Thu, 22 Jul 2021 22:29:45 +0200 Message-ID: To: John Levon Cc: dev , "Burakov, Anatoly" , Dmitry Kozlyuk , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] eal: allow hugetlbfs sub-directories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 8, 2021 at 1:00 PM John Levon wrote: > > get_hugepage_dir() was implemented in such a way that a --huge-dir > option had to exactly match the mountpoint, but there's no reason for > this restriction. Fix the implementation to allow a sub-directory within > a suitable hugetlbfs mountpoint to be specified, preferring the closest > match. > > Signed-off-by: John Levon This change in EAL hugetlbfs discovery is too dangerous to be taken after -rc1. Could you give some usecases/examples on why this change is needed? Updating the documentation and the unit test also seem necessary. -- David Marchand