From: David Marchand <david.marchand@redhat.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Ori Kam <orika@mellanox.com>, dev <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH] regex/mlx5: fix registration name Date: Wed, 29 Jul 2020 16:13:21 +0200 Message-ID: <CAJFAV8zuDpJK1OHGfZ4F2ZWNP8R0-WikZCNsCdtz4kYd7n=R7Q@mail.gmail.com> (raw) In-Reply-To: <3416145.6uEhLjpTrq@thomas> On Wed, Jul 29, 2020 at 4:10 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > 29/07/2020 16:01, Ori Kam: > > The current registration name has the net prefix, which is incorrect. > > This commit removes the net and changes the name to be regex_mlx5. > > It was offlist, but Reported-by: David Marchand <david.marchand@redhat.com> > > Signed-off-by: Ori Kam <orika@mellanox.com> > > --- > > drivers/regex/mlx5/mlx5_regex.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c > > index 1ca5bfe..cba3eb9 100644 > > --- a/drivers/regex/mlx5/mlx5_regex.c > > +++ b/drivers/regex/mlx5/mlx5_regex.c > > @@ -262,6 +262,6 @@ > > } > > > > RTE_LOG_REGISTER(mlx5_regex_logtype, pmd.regex.mlx5, NOTICE) > > -RTE_PMD_EXPORT_NAME(net_mlx5_regex, __COUNTER__); > > -RTE_PMD_REGISTER_PCI_TABLE(net_mlx5_regex, mlx5_regex_pci_id_map); > > -RTE_PMD_REGISTER_KMOD_DEP(net_mlx5_regex, "* ib_uverbs & mlx5_core & mlx5_ib"); > > +RTE_PMD_EXPORT_NAME(regex_mlx5, __COUNTER__); > > +RTE_PMD_REGISTER_PCI_TABLE(regex_mlx5, mlx5_regex_pci_id_map); > > +RTE_PMD_REGISTER_KMOD_DEP(regex_mlx5, "* ib_uverbs & mlx5_core & mlx5_ib"); > > I think you should add a macro for the name of the driver, > and take this opportunity to use the macro in mlx5_regex_driver.pci_driver.driver.name, > which is currently mlx5_regex instead of regex_mlx5. Sounds good to me. We might want to align other drivers too, as there are discrepancies in vdpa drivers. -- David Marchand
next prev parent reply other threads:[~2020-07-29 14:13 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-29 14:01 Ori Kam 2020-07-29 14:10 ` Thomas Monjalon 2020-07-29 14:13 ` David Marchand [this message] 2020-08-05 14:51 ` [dpdk-dev] [PATCH v2] regex/mlx5: fix registered driver name Thomas Monjalon 2020-08-05 16:35 ` Ori Kam 2020-08-05 16:37 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAJFAV8zuDpJK1OHGfZ4F2ZWNP8R0-WikZCNsCdtz4kYd7n=R7Q@mail.gmail.com' \ --to=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=orika@mellanox.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git