From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3BDEA052B; Wed, 29 Jul 2020 16:13:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C37E010A3; Wed, 29 Jul 2020 16:13:39 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id AC4771023 for ; Wed, 29 Jul 2020 16:13:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596032017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o+Y74dt75r9fLaWWSShvgygTZ0zwC4rt0B44pvBBq60=; b=dVYU+Ahn75eHHF/M1Uncyu3BqiXMelwLI7N2aqY6pGBPfTxGmXk7Fu2uGhqtKM7Sb7/3/S BvXoZFWyppPTaqZlCmIdE6DpqSop6DG2zPp0GwH3TeRPgxObPzSxmeQefB4yliX1cvMkUr Y26jnBxVXoulq8WpJJ24OBLUwss3rRM= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-EOIhXpM_MKa1LLZ6YHhhEQ-1; Wed, 29 Jul 2020 10:13:34 -0400 X-MC-Unique: EOIhXpM_MKa1LLZ6YHhhEQ-1 Received: by mail-vk1-f199.google.com with SMTP id g12so1950574vkl.22 for ; Wed, 29 Jul 2020 07:13:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o+Y74dt75r9fLaWWSShvgygTZ0zwC4rt0B44pvBBq60=; b=fGyWlioWTRTtm5Kgr5u995pHRHsjQILuBGF8FY2RMNcJEbeAcniPH3MscFRIjtxqCV 8SwuXwQbCxohBoV1U5ugZftF11OrJdpmKaNUnt96dmBUffnyhIufYuviTYxBIfqZqC9h ivfsCZl9pxbvEp85bnDElcsoYci5ytc1n2QQdXnQY6lnk5DRFUQ2L2NfZOyGiqEw7SXq fLyxGzndjHAJWvaYrc1LiMo4Na+pEOWx362LtIrbev3RN7dQJLzVj5/HkrsijfSy4srk lkU72raRTvmSW6z7Y3h5lGfvuvdbSE3G+J+FEj6ZWsB8VxGXxBY6i1KLNo7Skuma+ynf SbXQ== X-Gm-Message-State: AOAM533PHmHz2c1yZ6jCU9dnkl4Ye2cY82Q7Gbwj2ObYC2IZe5C4sCyA Frce95rskdCjb8nYI1AgLBuY1TuhIDnmNVI0RymOlLoNX8wNr4wbscJdrejekMAeHw8OhLLUHc3 GlErktswMYbRortRaTh8= X-Received: by 2002:a9f:31f3:: with SMTP id w48mr24265005uad.87.1596032013609; Wed, 29 Jul 2020 07:13:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaKVlayxSByAHB/EJTCBL/GgCXUDwgcDWOCj0r6n5jL+DAdn+zKHA90jsm5o0057imv1gBVqrati797a4Z4Q8= X-Received: by 2002:a9f:31f3:: with SMTP id w48mr24264983uad.87.1596032013369; Wed, 29 Jul 2020 07:13:33 -0700 (PDT) MIME-Version: 1.0 References: <1596031264-59994-1-git-send-email-orika@mellanox.com> <3416145.6uEhLjpTrq@thomas> In-Reply-To: <3416145.6uEhLjpTrq@thomas> From: David Marchand Date: Wed, 29 Jul 2020 16:13:21 +0200 Message-ID: To: Thomas Monjalon Cc: Ori Kam , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] regex/mlx5: fix registration name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 29, 2020 at 4:10 PM Thomas Monjalon wrote: > > 29/07/2020 16:01, Ori Kam: > > The current registration name has the net prefix, which is incorrect. > > This commit removes the net and changes the name to be regex_mlx5. > > It was offlist, but Reported-by: David Marchand > > Signed-off-by: Ori Kam > > --- > > drivers/regex/mlx5/mlx5_regex.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c > > index 1ca5bfe..cba3eb9 100644 > > --- a/drivers/regex/mlx5/mlx5_regex.c > > +++ b/drivers/regex/mlx5/mlx5_regex.c > > @@ -262,6 +262,6 @@ > > } > > > > RTE_LOG_REGISTER(mlx5_regex_logtype, pmd.regex.mlx5, NOTICE) > > -RTE_PMD_EXPORT_NAME(net_mlx5_regex, __COUNTER__); > > -RTE_PMD_REGISTER_PCI_TABLE(net_mlx5_regex, mlx5_regex_pci_id_map); > > -RTE_PMD_REGISTER_KMOD_DEP(net_mlx5_regex, "* ib_uverbs & mlx5_core & mlx5_ib"); > > +RTE_PMD_EXPORT_NAME(regex_mlx5, __COUNTER__); > > +RTE_PMD_REGISTER_PCI_TABLE(regex_mlx5, mlx5_regex_pci_id_map); > > +RTE_PMD_REGISTER_KMOD_DEP(regex_mlx5, "* ib_uverbs & mlx5_core & mlx5_ib"); > > I think you should add a macro for the name of the driver, > and take this opportunity to use the macro in mlx5_regex_driver.pci_driver.driver.name, > which is currently mlx5_regex instead of regex_mlx5. Sounds good to me. We might want to align other drivers too, as there are discrepancies in vdpa drivers. -- David Marchand