DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide
@ 2020-07-03 17:15 Ferruh Yigit
  2020-08-06 23:43 ` Thomas Monjalon
  2020-11-27 14:37 ` David Marchand
  0 siblings, 2 replies; 7+ messages in thread
From: Ferruh Yigit @ 2020-07-03 17:15 UTC (permalink / raw)
  To: John McNamara, Marko Kovacevic; +Cc: dev, Ferruh Yigit

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 doc/guides/contributing/patches.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index 25d97b85b..39ec64ec8 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -550,6 +550,10 @@ results in a subfolder of the current working directory.
 The environment variable ``DPDK_ABI_REF_DIR`` can be set so that the results go
 to a different location.
 
+Sample::
+
+        DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=/tmp ./devtools/test-meson-builds.sh
+
 
 Sending Patches
 ---------------
-- 
2.25.4


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide
  2020-07-03 17:15 [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide Ferruh Yigit
@ 2020-08-06 23:43 ` Thomas Monjalon
  2020-08-07 12:00   ` Kinsella, Ray
  2020-08-07 12:59   ` Kinsella, Ray
  2020-11-27 14:37 ` David Marchand
  1 sibling, 2 replies; 7+ messages in thread
From: Thomas Monjalon @ 2020-08-06 23:43 UTC (permalink / raw)
  To: Ferruh Yigit
  Cc: John McNamara, Marko Kovacevic, dev, david.marchand, Neil Horman, mdr

+Cc David, Neil and Ray

03/07/2020 19:15, Ferruh Yigit:
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  doc/guides/contributing/patches.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
> index 25d97b85b..39ec64ec8 100644
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> @@ -550,6 +550,10 @@ results in a subfolder of the current working directory.
>  The environment variable ``DPDK_ABI_REF_DIR`` can be set so that the results go
>  to a different location.
>  
> +Sample::
> +
> +        DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=/tmp ./devtools/test-meson-builds.sh




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide
  2020-08-06 23:43 ` Thomas Monjalon
@ 2020-08-07 12:00   ` Kinsella, Ray
  2020-08-07 12:58     ` Ferruh Yigit
  2020-08-07 12:59   ` Kinsella, Ray
  1 sibling, 1 reply; 7+ messages in thread
From: Kinsella, Ray @ 2020-08-07 12:00 UTC (permalink / raw)
  To: Thomas Monjalon, Ferruh Yigit
  Cc: John McNamara, Marko Kovacevic, dev, david.marchand, Neil Horman



On 07/08/2020 00:43, Thomas Monjalon wrote:
> +Cc David, Neil and Ray
> 
> 03/07/2020 19:15, Ferruh Yigit:
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>  doc/guides/contributing/patches.rst | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
>> index 25d97b85b..39ec64ec8 100644
>> --- a/doc/guides/contributing/patches.rst
>> +++ b/doc/guides/contributing/patches.rst
>> @@ -550,6 +550,10 @@ results in a subfolder of the current working directory.
>>  The environment variable ``DPDK_ABI_REF_DIR`` can be set so that the results go
>>  to a different location.
>>  
>> +Sample::
>> +
>> +        DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=/tmp ./devtools/test-meson-builds.sh
> 
> 
This is good, but I think we ought to include some guidance on what version to use.
What we agreed at the techboard meeting was that the last release should always be used. 

The script should probably automagically select the last version.
That is work to be done, for the moment, it will be sufficient to amend the line

"To enable them, a reference version must be selected via the environment variable DPDK_ABI_REF_VERSION."

to something like

"To enable them, a reference version must be selected via the environment variable DPDK_ABI_REF_VERSION. Contributors should be ordinarily be referencing the most recent release of DPDK."

Make sense?

Thanks,

Ray K
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide
  2020-08-07 12:00   ` Kinsella, Ray
@ 2020-08-07 12:58     ` Ferruh Yigit
  2020-08-07 12:58       ` Kinsella, Ray
  0 siblings, 1 reply; 7+ messages in thread
From: Ferruh Yigit @ 2020-08-07 12:58 UTC (permalink / raw)
  To: Kinsella, Ray, Thomas Monjalon
  Cc: John McNamara, Marko Kovacevic, dev, david.marchand, Neil Horman

On 8/7/2020 1:00 PM, Kinsella, Ray wrote:
> 
> 
> On 07/08/2020 00:43, Thomas Monjalon wrote:
>> +Cc David, Neil and Ray
>>
>> 03/07/2020 19:15, Ferruh Yigit:
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>> ---
>>>  doc/guides/contributing/patches.rst | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
>>> index 25d97b85b..39ec64ec8 100644
>>> --- a/doc/guides/contributing/patches.rst
>>> +++ b/doc/guides/contributing/patches.rst
>>> @@ -550,6 +550,10 @@ results in a subfolder of the current working directory.
>>>  The environment variable ``DPDK_ABI_REF_DIR`` can be set so that the results go
>>>  to a different location.
>>>  
>>> +Sample::
>>> +
>>> +        DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=/tmp ./devtools/test-meson-builds.sh
>>
>>
> This is good, but I think we ought to include some guidance on what version to use.
> What we agreed at the techboard meeting was that the last release should always be used. 
> 
> The script should probably automagically select the last version.
> That is work to be done, for the moment, it will be sufficient to amend the line
> 
> "To enable them, a reference version must be selected via the environment variable DPDK_ABI_REF_VERSION."
> 
> to something like
> 
> "To enable them, a reference version must be selected via the environment variable DPDK_ABI_REF_VERSION. Contributors should be ordinarily be referencing the most recent release of DPDK."
> 
> Make sense?
> 

Intention of the patch is to provide a sample command to help using it,
independent from what version to use.

What do you think doing reference version guidance in different patch?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide
  2020-08-07 12:58     ` Ferruh Yigit
@ 2020-08-07 12:58       ` Kinsella, Ray
  0 siblings, 0 replies; 7+ messages in thread
From: Kinsella, Ray @ 2020-08-07 12:58 UTC (permalink / raw)
  To: Ferruh Yigit, Thomas Monjalon
  Cc: John McNamara, Marko Kovacevic, dev, david.marchand, Neil Horman



On 07/08/2020 13:58, Ferruh Yigit wrote:
> On 8/7/2020 1:00 PM, Kinsella, Ray wrote:
>>
>>
>> On 07/08/2020 00:43, Thomas Monjalon wrote:
>>> +Cc David, Neil and Ray
>>>
>>> 03/07/2020 19:15, Ferruh Yigit:
>>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>>> ---
>>>>  doc/guides/contributing/patches.rst | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
>>>> index 25d97b85b..39ec64ec8 100644
>>>> --- a/doc/guides/contributing/patches.rst
>>>> +++ b/doc/guides/contributing/patches.rst
>>>> @@ -550,6 +550,10 @@ results in a subfolder of the current working directory.
>>>>  The environment variable ``DPDK_ABI_REF_DIR`` can be set so that the results go
>>>>  to a different location.
>>>>  
>>>> +Sample::
>>>> +
>>>> +        DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=/tmp ./devtools/test-meson-builds.sh
>>>
>>>
>> This is good, but I think we ought to include some guidance on what version to use.
>> What we agreed at the techboard meeting was that the last release should always be used. 
>>
>> The script should probably automagically select the last version.
>> That is work to be done, for the moment, it will be sufficient to amend the line
>>
>> "To enable them, a reference version must be selected via the environment variable DPDK_ABI_REF_VERSION."
>>
>> to something like
>>
>> "To enable them, a reference version must be selected via the environment variable DPDK_ABI_REF_VERSION. Contributors should be ordinarily be referencing the most recent release of DPDK."
>>
>> Make sense?
>>
> 
> Intention of the patch is to provide a sample command to help using it,
> independent from what version to use.
> 
> What do you think doing reference version guidance in different patch?
> 

np. I will do that.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide
  2020-08-06 23:43 ` Thomas Monjalon
  2020-08-07 12:00   ` Kinsella, Ray
@ 2020-08-07 12:59   ` Kinsella, Ray
  1 sibling, 0 replies; 7+ messages in thread
From: Kinsella, Ray @ 2020-08-07 12:59 UTC (permalink / raw)
  To: Thomas Monjalon, Ferruh Yigit
  Cc: John McNamara, Marko Kovacevic, dev, david.marchand, Neil Horman



On 07/08/2020 00:43, Thomas Monjalon wrote:
> +Cc David, Neil and Ray
> 
> 03/07/2020 19:15, Ferruh Yigit:
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>  doc/guides/contributing/patches.rst | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
>> index 25d97b85b..39ec64ec8 100644
>> --- a/doc/guides/contributing/patches.rst
>> +++ b/doc/guides/contributing/patches.rst
>> @@ -550,6 +550,10 @@ results in a subfolder of the current working directory.
>>  The environment variable ``DPDK_ABI_REF_DIR`` can be set so that the results go
>>  to a different location.
>>  
>> +Sample::
>> +
>> +        DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=/tmp ./devtools/test-meson-builds.sh
> 
> 
> 

Acked-by: Ray Kinsella <mdr@ashroe.eu>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide
  2020-07-03 17:15 [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide Ferruh Yigit
  2020-08-06 23:43 ` Thomas Monjalon
@ 2020-11-27 14:37 ` David Marchand
  1 sibling, 0 replies; 7+ messages in thread
From: David Marchand @ 2020-11-27 14:37 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: John McNamara, Marko Kovacevic, dev

On Fri, Jul 3, 2020 at 7:15 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Ray Kinsella <mdr@ashroe.eu>

Sample sounds odd to me, but applied as is.
Thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-11-27 14:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-03 17:15 [dpdk-dev] [PATCH] doc: add sample for ABI checks in contribution guide Ferruh Yigit
2020-08-06 23:43 ` Thomas Monjalon
2020-08-07 12:00   ` Kinsella, Ray
2020-08-07 12:58     ` Ferruh Yigit
2020-08-07 12:58       ` Kinsella, Ray
2020-08-07 12:59   ` Kinsella, Ray
2020-11-27 14:37 ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git