From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE03D41BAB; Thu, 2 Feb 2023 11:56:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77E83406A2; Thu, 2 Feb 2023 11:56:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 462A040689 for ; Thu, 2 Feb 2023 11:56:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675335414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B2Fk5s94fXgZEQVgLEgNJ5hqONtnDiCqourRQltwWbo=; b=Yh7Q28Z/2w87WUe7X0pFeh2b029uix2S5j62zzzNjFQQcdoGZ0iesBrl/8zWIxfTae9Mz+ Oz/IPsxzmN+F2LhGi8x0704GNtERVbwDgYYIgZStY9/Ywo59N+5JYNYLjwZgGgDUbyrhnL YtSm6TfILEf9myX8QcIBGvBXymNBvSo= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-329-ZmDLwYKPNYmXOm9fk-QDgA-1; Thu, 02 Feb 2023 05:56:53 -0500 X-MC-Unique: ZmDLwYKPNYmXOm9fk-QDgA-1 Received: by mail-pl1-f197.google.com with SMTP id t12-20020a170902b20c00b00192e3d10c5bso789788plr.4 for ; Thu, 02 Feb 2023 02:56:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B2Fk5s94fXgZEQVgLEgNJ5hqONtnDiCqourRQltwWbo=; b=zqP9ZSA9oRwBej58KaUzkHfZlnAcRT74uWfU8btMNAKWphcNOwLxsbMZHRDISzYjNn czXbVhPQxOYB6pX6z6OQt9Qhb6mKfCVC0/5arRdqujng79UYSH1DJjFrzLfe0GMVYuzs a8pyNXbx8qB7OtFU9gR8L01J92Fj1N6VcnE+6m0iVTwLKmhVYnNyp5O++LNT/q7z34xv jkzVC7L4ofaqDWcyWRlW1LCDA5aRQ+Jz57y07hIU7AoMDsm1bAjPHTUid8o9XBPRLIbN liWc+NM74WPGg8s/i6JvYJmTDpY4kgJ8Sd14YbPmYXIAO5PvN5+VdAYcfqzf4jGlrsyu CENA== X-Gm-Message-State: AO0yUKVDbrIU7ogKJK5nXPxcvZtTnN4E3GLmKnbk0F8JUSS18w4BvShB rgjmFFdH1mmLMpV4oRezmqcdUrQMu0+z1QLbpPl17YQ88P4A05mXMRf6HZ8b03IlG2nRO36H0BO yL/5RN2B8DncNhtql8l4= X-Received: by 2002:a63:d443:0:b0:4ad:30aa:8e6a with SMTP id i3-20020a63d443000000b004ad30aa8e6amr1045303pgj.40.1675335412612; Thu, 02 Feb 2023 02:56:52 -0800 (PST) X-Google-Smtp-Source: AK7set/UvPjHN/+PoS0RzTP1XIb1nr6S6wxMbpwTVjS56dZpRaLszAE3yHAp6Djr8BhtjyOF/n8xfEozkZknQ3WDb8Q= X-Received: by 2002:a63:d443:0:b0:4ad:30aa:8e6a with SMTP id i3-20020a63d443000000b004ad30aa8e6amr1045295pgj.40.1675335412333; Thu, 02 Feb 2023 02:56:52 -0800 (PST) MIME-Version: 1.0 References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com> <1673380001-16558-1-git-send-email-roretzla@linux.microsoft.com> <20230120221418.GA9231@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: From: David Marchand Date: Thu, 2 Feb 2023 11:56:41 +0100 Message-ID: Subject: Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, mb@smartsharesystems.com, bruce.richardson@intel.com, ferruh.yigit@amd.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 2, 2023 at 10:14 AM David Marchand wrote: > > Hello Tyler, > > On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff > wrote: > > > > hi folks, > > > > i think this one can probably be merged? > > > > Series-acked-by: Morten Br=C3=B8rup > > Series-acked-by: Bruce Richardson > > patch 1/2 Acked-by: Ferruh Yigit > > I like the cleanup of rte_common.h and additional unit tests, but the > MSVC bits don't belong here. > Please move them in your MSVC enablement series > https://patchwork.dpdk.org/project/dpdk/list/?series=3D26662&state=3D%2A&= archive=3Dboth. Addendum, running the series through my checks, I can see that test_bitcount.c is left unattended wrt the MAINTAINERS file. app/test/test_bitcount.c must be put under the "EAL API and common code" section. Thanks. --=20 David Marchand