From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34B49A0542; Thu, 13 Feb 2020 15:01:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1658D1C021; Thu, 13 Feb 2020 15:01:30 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 44ABB1C020 for ; Thu, 13 Feb 2020 15:01:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581602488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EZZS/Fug4uh5JtMcrbsWzOYD6FYpXNO5wMVc2uL1668=; b=J4Vih/f7j9fieDqUlxGUtYmwIVqdY0hDRNw9U/Sxm930Cr1JIYlJm7I/saBMqVIjXV5jxt OT/6pUjAUi5xFN8eebMk5VPl9QVZZ/F3zdntwqsz/6442r7vhoJDxAvsEGgGNFSMLv7uxe Qy5HoX9wGre6W0iP/Ce2lxPKPj2Mk/4= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-fkolrHbgMba7_cRCu9ovuA-1; Thu, 13 Feb 2020 09:01:24 -0500 Received: by mail-vs1-f71.google.com with SMTP id z3so436109vsp.1 for ; Thu, 13 Feb 2020 06:01:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b70Rml4Avs9GTgx7XS97pElnwfL3Q/H75583Wull6j4=; b=s6AbzevHxV0cftL/bnV3J4F4z0L5X8N9umuIN3qF3ovasgNJwCkkNKwMF2tGuYt8S2 bq1p64SaQHBC2PiQ6q8HX/hZ/lWV1/KhOS57GM9InowpFi+56t5ERk4yVth9Sh3Rakmr dMqjbk5ZZGSQZL2TR11zfqKcs1su7aqATpioubOCcnYz/uWnS99TBgssQxSuL1u8KkHn 21UhYtrrEQ/6yZcPoswqz2e8kafLe/QCu1MWFbTrvuhRqFYMvJy1jGtFY8PLLUvTTuFN bncZTI8/jbPFjioKx1i3VFbNb5oI77kCvP967lqMZmgMvO9fEYKP9IsX/grmEs45QpTY 47fg== X-Gm-Message-State: APjAAAX19bz4OnAonyae110mNNM9OHSiGn1fzNcY0dI5q2ylCfVVB/5c vf1wMUSfblF9r6wGwJmNtZSCN5tom3/JTCOyrRyzI4YMYHQRFf347uqhSSEncQpgMh8+ruxubG2 g7v8TAHo4WbqhOrrj9Cs= X-Received: by 2002:a67:e342:: with SMTP id s2mr2063933vsm.198.1581602483685; Thu, 13 Feb 2020 06:01:23 -0800 (PST) X-Google-Smtp-Source: APXvYqxp0RhylNcxQBvEkigHS7kh8fspm2Q3UDZedghhrc6pDLFvJWrHw+ZCenhN1GaISbei+IYCLiijIEaHHlbY0pE= X-Received: by 2002:a67:e342:: with SMTP id s2mr2063910vsm.198.1581602483339; Thu, 13 Feb 2020 06:01:23 -0800 (PST) MIME-Version: 1.0 References: <20200204160006.64720-1-ciara.power@intel.com> In-Reply-To: <20200204160006.64720-1-ciara.power@intel.com> From: David Marchand Date: Thu, 13 Feb 2020 15:01:12 +0100 Message-ID: To: Ciara Power Cc: Bruce Richardson , dev , dpdk stable X-MC-Unique: fkolrHbgMba7_cRCu9ovuA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] examples/ioat: fix failure check for ioat dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 4, 2020 at 5:10 PM Ciara Power wrote: > > The nb_dq return value from the ioat dequeue is negative in failure > cases, however the variable was an unsigned int, causing the condition > where nb_dq <=3D 0 to never be true. This is now cast to a signed int, > which will successfully reflect the -1 value to be used in this > conditional check. > > Coverity issue: 350342 > Coverity issue: 350349 > Fixes: 92c981637ffc ("examples/ioat: handle failure case for ioat dequeue= ") > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power Acked-by: Bruce Richardson Applied, thanks. -- David Marchand