From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4697445A7A; Tue, 1 Oct 2024 14:08:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CCC54027E; Tue, 1 Oct 2024 14:08:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A4BF04027C for ; Tue, 1 Oct 2024 14:08:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727784531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7UEpKPplSDetWCmefYZ9wN9RolXLTzTGMNmjIvn89II=; b=bstn7KJPF2jOyLsXa6Pe7VZ9bs+aCznbzuPdiTzb8ze2Y56HIkUqzfS6yXPrxsbFQhWjuI IB8LVYzTtjAmVfT19PBmolQ2MPKUvSrcRzrbL7ZfmYr1/RJM/XfiXFpLp2aJrTHRLScXgg bay4bKNaVzLAONYF31DRCBBoqer6L+M= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-7Sh-ARuANlmMxOZYvjVMkg-1; Tue, 01 Oct 2024 08:08:50 -0400 X-MC-Unique: 7Sh-ARuANlmMxOZYvjVMkg-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-53995187384so1919569e87.2 for ; Tue, 01 Oct 2024 05:08:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727784529; x=1728389329; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7UEpKPplSDetWCmefYZ9wN9RolXLTzTGMNmjIvn89II=; b=a8iEf29YlbMf2YQx+ruR0nqwwy+AsONnMKXegAhOiw/gwTfK5HgYGNvHPO3V1+TrfP yGu1m+pj5CrBBexsWe1O7wCSXDclnt3Qlh2mP3Re0ZMCg3MaAQLHPg2Ud5/tnPMj4tBH n+z/qgxI/pD+zNMLPIH2NRlANkGO3ImvWvEFTEllYO35+oY/ScC8mjN8NjFKmuhLC4xw 8bgbjEyj+6OdhC3DIiT2j+Y+hlB44PZlbJl6dejDJGEhUNEXSrmN+HeqdQj5mKJ4tfy3 rbHAnc6Ew5aj3ZWUgE2FNJY2ilJuvb38nN2coq9gcyx9eSCRlUKIZwN8+Jjyy5AyF17u jK1g== X-Gm-Message-State: AOJu0YzXmycuTriKtvsFmY3pai3HcCbxhe+DbWxbaxwfIj2VmPMHmxJP 9VRjNV/nwxIq85KZW7OhfeaCqrWlzKGqhAK6c17vhxxzaO+v8Imxw9tMbSZSFdhCsXuHTAtWqDe YNpeytBSBuDgCRHne39Kmy9r4BXxJ8kiL4XaA3s/suvPGJbjcvg1gKP4moswUOwJxyToYmPTdiq O+zcmB3nW2Dxm0KLQ= X-Received: by 2002:a05:6512:b27:b0:536:a50a:3c25 with SMTP id 2adb3069b0e04-5389fc34472mr6941768e87.12.1727784528625; Tue, 01 Oct 2024 05:08:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFY/xmCi1d6fH1ZY8Ko9zGSvmDye26m/ySi/9ktScaHkXumA+H0vhV5eHYWVyk2tpINBUsk85R5mPWmTlcWhas= X-Received: by 2002:a05:6512:b27:b0:536:a50a:3c25 with SMTP id 2adb3069b0e04-5389fc34472mr6941739e87.12.1727784528231; Tue, 01 Oct 2024 05:08:48 -0700 (PDT) MIME-Version: 1.0 References: <20240907145433.1479091-1-david.marchand@redhat.com> <20240912082643.1532679-1-david.marchand@redhat.com> <20240912082643.1532679-4-david.marchand@redhat.com> <7782369.EvYhyI6sBW@thomas> In-Reply-To: <7782369.EvYhyI6sBW@thomas> From: David Marchand Date: Tue, 1 Oct 2024 14:08:37 +0200 Message-ID: Subject: Re: [PATCH v2 03/14] net/dpaa: remove broken debug macros To: Thomas Monjalon , Hemant Agrawal Cc: dev@dpdk.org, Sachin Saxena X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 1, 2024 at 12:19=E2=80=AFPM Thomas Monjalon wrote: > 12/09/2024 10:26, David Marchand: > > Those debug macros never worked as existing callers never passed a > > 'level' argument. > > Remove them. > > > > Signed-off-by: David Marchand > > Why not removing the calls to these macros? I was unclear if the fmlib enters the "base driver" category. So I simply removed macros from the header providing wrappers to dpdk API. Relooking, I see other changes in this directory, so I agree I may as well remove those calls. Hemant, opinion? --=20 David Marchand