DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Gongming Chen <chengongming1900@outlook.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	 "yanzhirun_163@163.com" <yanzhirun_163@163.com>,
	Robin Jarry <rjarry@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>,
	 Gongming Chen <chengm11@chinatelecom.cn>,
	"stable@dpdk.org" <stable@dpdk.org>,
	 Fan Yin <yinf1@chinatelecom.cn>,
	Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
Subject: Re: [EXTERNAL] [PATCH v2] graph: fix does not return the unique id when create graph
Date: Tue, 18 Jun 2024 15:27:52 +0200	[thread overview]
Message-ID: <CAJFAV8zwgWLHBMp5XvH4sWBhq2KZOF1OZ=Bg2vaPmwQMOy2ymA@mail.gmail.com> (raw)
In-Reply-To: <PH0PR18MB50717BEE1DF15249CE390878ACE72@PH0PR18MB5071.namprd18.prod.outlook.com>

On Fri, May 10, 2024 at 10:40 AM Kiran Kumar Kokkilagadda
<kirankumark@marvell.com> wrote:
> > When the order of graph destroy is not the reverse order of create, that is,
> > when it is destroyed at will, the newly created graph id will be the same as
> > the existing graph id, which is not the expected unique graph id. This graph
> > id incorrectly corresponds to multiple graphs.
> >
> > Fixes: a91fecc19c5c ("graph: implement create and destroy")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Fan Yin <yinf1@chinatelecom.cn>
> > Signed-off-by: Gongming Chen <chengm11@chinatelecom.cn>
> > Signed-off-by: Fan Yin <yinf1@chinatelecom.cn>
> > ---
>
> There is a similar patch from robin in review.
> https://patchwork.dpdk.org/project/dpdk/patch/20240326154936.1132201-1-rjarry@redhat.com/
> I already Acked it. It is ready for merge.

I merged Robin fix, please have a look.

I'll mark your proposed patch as rejected in patchwork, for now.
Feel free to send a new patch if there is still some issue.

Thanks.


-- 
David Marchand


      reply	other threads:[~2024-06-18 13:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10  6:42 [PATCH v1] " Gongming Chen
2024-05-10  6:55 ` [PATCH v2] " Gongming Chen
2024-05-10  8:39   ` [EXTERNAL] " Kiran Kumar Kokkilagadda
2024-06-18 13:27     ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zwgWLHBMp5XvH4sWBhq2KZOF1OZ=Bg2vaPmwQMOy2ymA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=chengm11@chinatelecom.cn \
    --cc=chengongming1900@outlook.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=rjarry@redhat.com \
    --cc=stable@dpdk.org \
    --cc=yanzhirun_163@163.com \
    --cc=yinf1@chinatelecom.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).