From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E67364548D; Tue, 18 Jun 2024 15:28:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF43740E4F; Tue, 18 Jun 2024 15:28:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 446E2402B4 for ; Tue, 18 Jun 2024 15:28:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718717290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mpAdvk7jZASP46nYWlP1mRbOk7wMssbO83rLm7I1nyw=; b=RyBSUB3uGBUFk7lLoF+B8M9BTvO1I9xMby6ko1g/Enpa+5dhnsHops8F9rnNjwmP5FbgGy UDPQYPdak6JN7UedGH4alJaoT/CXQug7zu8Xh0CADH94vDOu5AXYAcRx+Co8yjlTKCiPJ+ kdD3gTYmBgkUsfZA+FWIe1y5gIXja20= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-244-z0TzBftaMVefaSKKneankw-1; Tue, 18 Jun 2024 09:28:05 -0400 X-MC-Unique: z0TzBftaMVefaSKKneankw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ea892f8441so39064911fa.1 for ; Tue, 18 Jun 2024 06:28:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718717284; x=1719322084; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mpAdvk7jZASP46nYWlP1mRbOk7wMssbO83rLm7I1nyw=; b=aqLUWEGA+Bz8TEMSwRFPrE/gIRJWgWaSFd7zBCLfEFhYBsDnUvbu2wOwtD+9p3brCf 5DNV3/jhnSIJvwa9wcvfmHXJH9AbVShD+eAgMT0sqF3YFq/ETKjWLn1gmfE0OvfDaYew WTkC1EZwhkJnY6QzVKt7bNoVINa/cRYoUzy9l7J6dXt6UFpzdo5dd6s8ZZUtNRmKrJm+ BOczwRv9z4dO0i0ICXMODWk5K/sUlaBxmx2w77PvZm8cbhZNXLimgD+J0rr9xpBywqXa nHn1QRU+iqOeu6q2qP9dQsZ5q5kbF3QqFxpsTSekEsXx/ozB2SXp48zBpJUp38DsBhGB qalQ== X-Forwarded-Encrypted: i=1; AJvYcCUtHQxIs3jmRNSPRluQ2vd9p4h5DW2rubvh3O9+byYqzCEiEYwbAXmebs7Aiv7cIyL3h39D0bJDLkTTc6M= X-Gm-Message-State: AOJu0YxXww1Asx6PoDrGjTtiWB+nIcWKzshWH4pBZf8guNXYKmBUzv3B CiphHtUyoXKEtm+0Yk+zFNX9P7fcTlv/mrAjDi4FPn4B5syCKtv9B8Px52roYAo+xkblx55q7+l VwGFq/EXg+n/QxmZHlag+8o8bBJtgOCOyS9bhEwF7eMqHxI9yhXyvBJ+Tuatilx3LzgJpxmWKBB XGqgiH7bU3WceicG4= X-Received: by 2002:ac2:4ed8:0:b0:52c:9d31:3f25 with SMTP id 2adb3069b0e04-52ca6e90302mr8633790e87.43.1718717283876; Tue, 18 Jun 2024 06:28:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEU8xVgcdhyhBSyF5Y+V/mn7CC6Wevn+ttA7XyhzWimlXjI9mhUT1HTtxdH04cYX9HVeVGZ5P2fYOCXzKJu34Y= X-Received: by 2002:ac2:4ed8:0:b0:52c:9d31:3f25 with SMTP id 2adb3069b0e04-52ca6e90302mr8633766e87.43.1718717283524; Tue, 18 Jun 2024 06:28:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Tue, 18 Jun 2024 15:27:52 +0200 Message-ID: Subject: Re: [EXTERNAL] [PATCH v2] graph: fix does not return the unique id when create graph To: Gongming Chen Cc: Jerin Jacob , Nithin Kumar Dabilpuram , "yanzhirun_163@163.com" , Robin Jarry , "dev@dpdk.org" , Gongming Chen , "stable@dpdk.org" , Fan Yin , Kiran Kumar Kokkilagadda X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, May 10, 2024 at 10:40=E2=80=AFAM Kiran Kumar Kokkilagadda wrote: > > When the order of graph destroy is not the reverse order of create, tha= t is, > > when it is destroyed at will, the newly created graph id will be the sa= me as > > the existing graph id, which is not the expected unique graph id. This = graph > > id incorrectly corresponds to multiple graphs. > > > > Fixes: a91fecc19c5c ("graph: implement create and destroy") > > Cc: stable@dpdk.org > > > > Reported-by: Fan Yin > > Signed-off-by: Gongming Chen > > Signed-off-by: Fan Yin > > --- > > There is a similar patch from robin in review. > https://patchwork.dpdk.org/project/dpdk/patch/20240326154936.1132201-1-rj= arry@redhat.com/ > I already Acked it. It is ready for merge. I merged Robin fix, please have a look. I'll mark your proposed patch as rejected in patchwork, for now. Feel free to send a new patch if there is still some issue. Thanks. --=20 David Marchand