From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
Matan Azrad <matan@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
Ravi Kumar <ravi1.kumar@amd.com>,
Xiaolong Ye <xiaolong.ye@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>, Gaetan Rivet <grive@u256.net>,
Ziyang Xuan <xuanziyang2@huawei.com>,
Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
Guoyang Zhou <zhouguoyang@huawei.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] build: remove redundant config include
Date: Mon, 10 Feb 2020 11:25:47 +0100 [thread overview]
Message-ID: <CAJFAV8zwnDm=4rL+ydAFQbAmuHNye8BO0LWh9=e7_P9ZCiWS+w@mail.gmail.com> (raw)
In-Reply-To: <20200210095334.1167059-1-thomas@monjalon.net>
On Mon, Feb 10, 2020 at 10:54 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The header file rte_config.h is always included by make or meson.
> If required in an exported API header file, it must be included
> in the public header file for external applications.
> In the internal files, explicit include of rte_config.h is useless,
> and can be removed.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> app/test-pmd/config.c | 1 -
> buildtools/pmdinfogen/pmdinfogen.h | 1 -
> drivers/common/mlx5/mlx5_glue.c | 2 --
> drivers/crypto/ccp/rte_ccp_pmd.c | 1 -
> drivers/net/af_xdp/rte_eth_af_xdp.c | 1 -
> drivers/net/failsafe/failsafe_intr.c | 1 -
> drivers/net/hinic/base/hinic_compat.h | 1 -
> drivers/net/mlx4/mlx4.c | 1 -
> drivers/net/mlx5/mlx5.c | 1 -
> drivers/net/vdev_netvsc/vdev_netvsc.c | 1 -
> lib/librte_eal/common/eal_common_mcfg.c | 1 -
> lib/librte_eal/common/eal_memcfg.h | 1 -
> 12 files changed, 13 deletions(-)
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2020-02-10 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 9:53 Thomas Monjalon
2020-02-10 9:58 ` Matan Azrad
2020-02-10 10:25 ` David Marchand [this message]
2020-02-10 13:39 ` Neil Horman
2020-02-11 16:03 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zwnDm=4rL+ydAFQbAmuHNye8BO0LWh9=e7_P9ZCiWS+w@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bernard.iremonger@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=jingjing.wu@intel.com \
--cc=matan@mellanox.com \
--cc=nhorman@tuxdriver.com \
--cc=qi.z.zhang@intel.com \
--cc=ravi1.kumar@amd.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=xuanziyang2@huawei.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).