From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2B0141C4D; Thu, 9 Feb 2023 10:16:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A0AF40EDC; Thu, 9 Feb 2023 10:16:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 339C34067B for ; Thu, 9 Feb 2023 10:16:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675934194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sOtMQNUytEcqCvjMw3IDeX9EsJ/kzXicmOCP+7PrkE0=; b=EgNofFQb/l3lLaL49lGXJbxjfNOaPfJIdV2AvuJUycki43979hK5T6OyIzIW67/DnlePOe f2sK+k/6ZjuGXNXdnEaVrBm0G4+/mV4xNGFpQRO2wWSS0ZtTnpm3iG90uS52v+LpaojNFh jJFDWmdTC+4NKhMYD613o2pUFSYnPaY= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-663-_ajkJWOjPdGw-IRDHfHAGg-1; Thu, 09 Feb 2023 04:16:33 -0500 X-MC-Unique: _ajkJWOjPdGw-IRDHfHAGg-1 Received: by mail-pl1-f198.google.com with SMTP id g12-20020a170902868c00b00199148d00f2so997290plo.17 for ; Thu, 09 Feb 2023 01:16:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sOtMQNUytEcqCvjMw3IDeX9EsJ/kzXicmOCP+7PrkE0=; b=z7r0EXW/ussgYy/xVd0MHfUD65UAcjtKgfZZwgec9rEZIcVrLNgJhDbt9mVPGCCQY7 Jd4QdNpL729UMuUfnYbzzXAS1TSqaQd3ebREffzhk6MH1GjmfGXkoXfSE+2N/TNdxAtF 2cr0hLyrNaKl7cnxucSeVQ8ohiC34ujFmIYTmqGkA9G5/3HkZ5DwprQRdGPwuN+7Qus6 uoQJw8xqoBLmWTJwDHfBcg4Ur5+e9NXMSkYaqN/DTtzxQtV6aIi8G6QacmlkWpNH8xQk 4nbwa3JnWbZ1V/UKZVmBA/1yMTGeZ+hQWpjzh9m/+gwL9w14xq102JaA2a1Ka0H7uEHU mWzA== X-Gm-Message-State: AO0yUKUyAyVMkl/VImd6cTv04ZGk4ic2/rqtmgLwSG0yGg/tCJxOBkvT yxkwrqQeiBUFkJn8j8UFRqF2P/C8EXfcO+ceyLnLMsZjgrfQ1sQwc30iTLJmWibEb0J4gzFid8Y oae3cSLNs2iPeacl6v4I= X-Received: by 2002:aa7:95ac:0:b0:590:6fcc:be6f with SMTP id a12-20020aa795ac000000b005906fccbe6fmr2333359pfk.49.1675934192325; Thu, 09 Feb 2023 01:16:32 -0800 (PST) X-Google-Smtp-Source: AK7set/WoP5Jq8lFcuzpiL0OKJBor1RjavnnqqvuWYpgf5ZvHKN4kSsZN85hLDbO5hZwn92UgjPtSKw98ULmZtlVfSI= X-Received: by 2002:aa7:95ac:0:b0:590:6fcc:be6f with SMTP id a12-20020aa795ac000000b005906fccbe6fmr2333355pfk.49.1675934192021; Thu, 09 Feb 2023 01:16:32 -0800 (PST) MIME-Version: 1.0 References: <20221201014440.11896-1-stephen@networkplumber.org> <20230207001937.875608-1-stephen@networkplumber.org> <20230208011316.47a6e9a6@sovereign> In-Reply-To: <20230208011316.47a6e9a6@sovereign> From: David Marchand Date: Thu, 9 Feb 2023 10:16:21 +0100 Message-ID: Subject: Re: [PATCH v2 0/8] Enable building more libraries on Windows To: Stephen Hemminger Cc: Dmitry Kozlyuk , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Stephen, On Tue, Feb 7, 2023 at 11:13 PM Dmitry Kozlyuk wrote: > > 2023-02-06 16:19 (UTC-0800), Stephen Hemminger: > > While diagnosing some Windows cross build errors; > > noticed that lots of important DPDK libraries are not > > being built on Windows. > > > > Stephen Hemminger (8): > > net/null: build null PMD on Windows > > net/ring: build on Windows > > lpm: enable on Windows > > reorder: build on Windows > > ip_frag: enable build on Windows > > rib: enable on Windows > > fib: enable on Windows > > pcapng: windows compatibility > > > > v2 - fix unnecessary PATH_MAX in net/ring driver > > Looks like #include is still needed in rte_eth_ring.h > to avoid the fatal warning about `strdup()` with clang (MS CRT, actually). We need a new revision. Thanks. -- David Marchand