From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by dpdk.org (Postfix) with ESMTP id E96191BC12 for ; Tue, 18 Dec 2018 11:41:45 +0100 (CET) Received: by mail-ua1-f46.google.com with SMTP id d21so5527961uap.9 for ; Tue, 18 Dec 2018 02:41:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SD5/B00SYWH5eQhwr9BIaQ2gjgsQOOo9hH5EZm9SeW4=; b=icaaVMZO8W4GMa1qCr2kmdeHGbLhNWqvBcAkYA7Ypy2zUOdLD0EqYqJLlzVsU2DQSO hQsQHHrpBq+v3ikHxoELcVmIXMwHXfoNIn0Zvi/GMUbzm0fzNws0UYhAzOv2GUtPuXDt M+jxvNfRIThDcSr1YokzNLbZj/4UuwFL+yALHWctW5jkXI1qtSCEJhGg6jMDs61xA8PH rBqYd7dLtDS85vQTWJCx2tpQX4ko9PuYIl/Ps2+vWxAhvKU3xeUVjcan5PQP6j8KDVjt sINTf4uANRRzhjV7OyXQjQb7mYMVTBV0d971IxrLeGYxTgg+IycjMV2S6LStYBb8m2ld ocJw== X-Gm-Message-State: AA+aEWa2MZE+ahe2AxOlN0bSwEBnsc2kDXiGnwp4p5bm64qVu8S6skRi SmaVLBZCzJ9T4ePcV8Uvntj97NZSKzv4eqXVcaRtcg== X-Google-Smtp-Source: AFSGD/Vmr68Z245qgGd6nYjzyqloMs8PWltBo7HWmemD5bSSbuVygCmQ35RQjVE1Q3KC9ldl4gRiaT5P6hRGRJ57SJA= X-Received: by 2002:ab0:7493:: with SMTP id n19mr1485523uap.115.1545129705425; Tue, 18 Dec 2018 02:41:45 -0800 (PST) MIME-Version: 1.0 References: <20181203164724.GA12316@hmswarspite.think-freely.org> <20181204151457.GA31778@hmswarspite.think-freely.org> <20181205122124.GA6752@hmswarspite.think-freely.org> In-Reply-To: From: David Marchand Date: Tue, 18 Dec 2018 11:41:34 +0100 Message-ID: To: Neil Horman , thomas@monjalon.net Cc: "Yigit, Ferruh" , dev@dpdk.org, Timothy Redaelli , adrien.mazarguil@6wind.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Marking symbols as experimental in the headers only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 10:41:46 -0000 On Wed, Dec 5, 2018 at 2:22 PM David Marchand wrote: > > On Wed, Dec 5, 2018 at 1:23 PM Neil Horman wrote: > >> On Tue, Dec 04, 2018 at 09:48:22PM +0100, David Marchand wrote: >> > On Tue, Dec 4, 2018 at 4:16 PM Neil Horman >> wrote: >> > > If you would like to make this adjustment, I'm fine with it, though be >> > > aware, >> > > you will likely need to make some adjustments to the >> > > check-experimental-syms >> > > script to account for this >> > > >> > >> > I am not sure I see what you mean on check-experimental-syms.sh. >> > I would only do a s/definition/declaration/ in the error message. >> > Do you have something else in mind ? >> All I was saying was that if you wanted to document the policy change, >> you might >> need to check that script as its a reflection of that policy, and I >> couldn't >> recall if it was grepping through .c and .h files (which might imply it >> needs to >> change to reflect this policy). I just looked however, and its checking >> object >> files, so you should be ok. >> > > Yes, thanks for the confirmation. > I have given it some more thought and did not send my patch that removes all __rte_experimental from the definitions sites. The real issue in the end is that the __rte_experimental in headers is the most important thing and can be missed during reviews. But I found no easy way to detect this. Do you have any idea ? -- David Marchand