From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADD69A04DD; Thu, 22 Oct 2020 22:01:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 148255A95; Thu, 22 Oct 2020 22:01:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 18A9B5A84 for ; Thu, 22 Oct 2020 22:01:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603396886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=35jMUc/myD3haQ0sjS+rmBHUz61SG/M6oy9pWuD5iPw=; b=WcvJ/mAoZKAhY/heokG9k49whO/B1U6GITHTqECCa/ZF0xAxrWxA/vdd78IAbRi0pyb2Nh oksZKJZL6REWHq54skDVLkQd5HOVdEiVZCJUtAOq0Cs/TAkmFlZ6CjaXy6nMoVFEvp0viY GacrHajPH+Q0yjJw/s0FszcHhFNDBNw= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-03fC5AjpPTKucZvuHThIvQ-1; Thu, 22 Oct 2020 16:01:24 -0400 X-MC-Unique: 03fC5AjpPTKucZvuHThIvQ-1 Received: by mail-ua1-f70.google.com with SMTP id f10so364493uao.15 for ; Thu, 22 Oct 2020 13:01:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=35jMUc/myD3haQ0sjS+rmBHUz61SG/M6oy9pWuD5iPw=; b=eOXQEw7v288dGNjPvVVSxV09AwqmGW0eT1p1ghdRxmT0QxqmrRmFjLbg49qSwJHbcr fZ9sJjGAJll3/J8fmy/AMNk18fc1xYD2WaQVcrD2mzYdJnha9tJeSEbxBfsa7dPaG8Hs X0vE9T7dxo2HJC5DnOGFjSdh83F3OOGv9eJLZMx6Lgf6HAFJPePJf2s0GnCWeUdDUuLJ c0NcJnql3lGxOFFSjL+PhzHnlcVlXdUxEIeOTXHyJQIcen0nwOHAreNbFT4x9CK2YA57 NsuYohiDwmyciHsVjPuaIxmHGc8h4djrLTdv0ZaGXuHxsqIFj0DcNpOZoCNhIwX1Uyje y9tQ== X-Gm-Message-State: AOAM533QKKKNZUFBwA841n1fTGxrU+BbpVx+WzxWybdLLI9ePeF7G2HX 79XLBBx8Qg7EQC+ShAAfLz/00vivjNa1nNWitEeyFTWMIhi+rHomSf96Mg8poYE8RHdkk44zidg jL4yCLvjTnZvnHPi2FCw= X-Received: by 2002:ab0:4983:: with SMTP id e3mr2731227uad.41.1603396884185; Thu, 22 Oct 2020 13:01:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7oMdwU9orAxWw/kUfHcLOpoL3sJKOuKTrxfaiPw3lMCsGCTO7NBO5fG9hEptCbYFni80LAl3U688EJY/JbpY= X-Received: by 2002:ab0:4983:: with SMTP id e3mr2731200uad.41.1603396883936; Thu, 22 Oct 2020 13:01:23 -0700 (PDT) MIME-Version: 1.0 References: <1600511670-27576-1-git-send-email-wangyunjian@huawei.com> <1602751350-2808-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1602751350-2808-1-git-send-email-wangyunjian@huawei.com> From: David Marchand Date: Thu, 22 Oct 2020 22:01:12 +0200 Message-ID: To: Harman Kalra , Jerin Jacob Kollanukkaran , Sunil Kumar Kori Cc: dev , "Yigit, Ferruh" , "Lilijun (Jerry)" , xudingke , Yunjian Wang , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] eal: fix dereference after null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 15, 2020 at 10:43 AM wangyunjian wrote: > > From: Yunjian Wang > > This patch fixes (dereference after null check) coverity issue. > For this reason, we should add null check at the beginning of the > function and return error directly if the 'intr_handle' is null. > > Coverity issue: 357695, 357751 > Fixes: 05c4105738d8 ("trace: add interrupt tracepoints") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang Review, please. -- David Marchand