From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC84DA04B1; Thu, 24 Sep 2020 11:31:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B180F1DD09; Thu, 24 Sep 2020 11:31:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 6EA941DD09 for ; Thu, 24 Sep 2020 11:31:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600939900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ST2X++OGN4IacIqk1Mnpt5NIC83eEIii7qJbH2JA3aU=; b=cV0XBV7StSmkc/TsqIsCn9f4CYW46xbpaDaqj7X3i8StFwRM5dciouk9KZ8v5TV+VBS/oh 3rYjaJXAsTii2DeYsvZW7Dm26Sbqnn/8Bp5bqZmc/2movtTbayhejk7P3VBA8EvH6OU70S KzYJaIfZm1ZCh126Fo9v7DwaIRjoCEE= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-Pt2LEjSLNCK0TWoKy-K6Rw-1; Thu, 24 Sep 2020 05:31:38 -0400 X-MC-Unique: Pt2LEjSLNCK0TWoKy-K6Rw-1 Received: by mail-vk1-f197.google.com with SMTP id e4so342634vkb.18 for ; Thu, 24 Sep 2020 02:31:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ST2X++OGN4IacIqk1Mnpt5NIC83eEIii7qJbH2JA3aU=; b=bnWaI9b9/4LznmsdVjZD8fC4MskMYcW3aCk03GelTzNa4jk2e8CUKd3SA9oYwF+2Tw hcihFBq75GFm6gI618OJRPaujoewvVUyAnuLMRRJZRkkc2TgtFwwZbIZTwnsepu7+rx3 kX7TxYb5OLccNT7EumHnXXxn6LBseLquJ+NLC/TYO3lr7vPZcH4v8ZUzf8z9Ke7Z/JMm 9y/oZsYwdTVUJh6tufeH3kvm5Ou07yhHM5zBDpdEy/izqCQweZSge0BAFn3lYeU6f5gt CtEhVogNGBHsp5R0+2paoOTlWpKExT88OxUvJmcX+gqSncEQFomLrRAH0xe/FRF4yT1O KNKA== X-Gm-Message-State: AOAM5308GgVYm8wXG4uK+KZHwOFGgDMFL910pnRvwjJC/bVMBM6ewVHn 68ZapPwNP04Iousr+M5lQppmfrnc6Tue8AWQGGCrQGg/gQQPSVgyLeJtGFNgmsIeJYmwUzR4xU6 tgQWDlCJIVOj+H1B4SBI= X-Received: by 2002:a05:6102:10c2:: with SMTP id t2mr2993168vsr.10.1600939898320; Thu, 24 Sep 2020 02:31:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy63ZZoahsI6GflIsfVgJzWiLtW/Eg3XrI2xVzuKBbLNwQxA640XqZLRagZWOG/fcLKx35btfoZmi6yDGVuSsY= X-Received: by 2002:a05:6102:10c2:: with SMTP id t2mr2993165vsr.10.1600939898012; Thu, 24 Sep 2020 02:31:38 -0700 (PDT) MIME-Version: 1.0 References: <20200921133830.1575872-1-ferruh.yigit@intel.com> <20200921133830.1575872-3-ferruh.yigit@intel.com> In-Reply-To: <20200921133830.1575872-3-ferruh.yigit@intel.com> From: David Marchand Date: Thu, 24 Sep 2020 11:31:27 +0200 Message-ID: To: Ferruh Yigit Cc: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , dev , Adrien Mazarguil Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 21, 2020 at 3:39 PM Ferruh Yigit wrote= : > > Error observed with gcc 11 under development > gcc (GCC) 11.0.0 20200920 (experimental) > > ../app/test-pmd/config.c:1777:61: > warning: argument 3 of type =E2=80=98const uint32_t[n]=E2=80=99 > {aka =E2=80=98const unsigned int[n]=E2=80=99} declared as a varia= ble length > array [-Wvla-parameter] > 1777 | port_flow_list(portid_t port_id, uint32_t n, > const uint32_t group[n]) > | ~~~~~~~~~~~~~~~^~~~~~~~ > In file included from ../app/test-pmd/config.c:53: > ../app/test-pmd/testpmd.h:764:67: > note: previously declared as a pointer =E2=80=98const uint32_t *= =E2=80=99 > {aka =E2=80=98const unsigned int *=E2=80=99} > 764 | void port_flow_list(portid_t port_id, uint32_t n, > const uint32_t *group); > | ~~~~~~~~~~~~~~~~^~~~~ > It won't hurt to backport this. Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") Cc: stable@dpdk.org > Signed-off-by: Ferruh Yigit > --- > app/test-pmd/config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index b6eb2a57a..380f3b5f6 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1774,7 +1774,7 @@ port_flow_aged(portid_t port_id, uint8_t destroy) > > /** List flow rules. */ > void > -port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n]) > +port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group) > { > struct rte_port *port; > struct port_flow *pf; > -- > 2.26.2 > Reviewed-by: David Marchand --=20 David Marchand