From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 293C5A00BE; Fri, 11 Feb 2022 08:55:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 16CCB41141; Fri, 11 Feb 2022 08:55:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4B87541238 for ; Fri, 11 Feb 2022 08:55:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644566117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SvQ3jMuBavZFvDqJkQmRDlY5JxXmuwHNm+P68Unv3Pk=; b=IfyZH8a6286QyLl+RJHJCsUXRpKF5RyH3iJtAAvpef5jzCw/juk9WKBoCchQoBTdmHuFiI dKBS8EUQ3fRlZxGPD5l3g+OSWvGG0M9VXUilTd5HAT1m36973i8253peQ4YyFCkA2sv0EE zLGLyPYHHB2dIem0xkh4xwnGKVXvsdA= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-101--SQiv6JiPaazOHqbnxwwbw-1; Fri, 11 Feb 2022 02:55:14 -0500 X-MC-Unique: -SQiv6JiPaazOHqbnxwwbw-1 Received: by mail-lf1-f71.google.com with SMTP id bp24-20020a056512159800b00437955f1443so1915111lfb.4 for ; Thu, 10 Feb 2022 23:55:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SvQ3jMuBavZFvDqJkQmRDlY5JxXmuwHNm+P68Unv3Pk=; b=O0ZyBay1cz6Pssfc13BhV83tMln0cMGTIHdcqHMpWn+wRaCxBGZ+lX3THgHNSTUjnG HtSov1YMq1lk99hBYFWkhkDwKj16CgNdatLD634ot26dKg2KyScVs0Abb81NNJ8I+o42 uGcIfivS6yz46MstFWW0I24Z5HGmlwjMmqjsnuxGPnfmQZWywTCEQcc8Mpe9rz2dCRdX EdD3obF5Wk869Xa8iOOwaJ2gSMtwakLdFT0Ksbat/Ol2c6ueSXfylyOuA5Lmi4DM3nsp WYFHttsUiBZAzgF8Gn8qjhc5TDeO6SHe9235PP+yhxycUakPV2dsMA89r0xWPwlaAhs5 Gm/A== X-Gm-Message-State: AOAM533wgsjx1svS7PQq1zhPfuFe55bGG6SrHTK3XhLjoSuRVnH3unbo bHqCgjNpQIUX7NG1gb8Vq1i+LuQz+9qJG8C5FZK2SIMoE4kxmCPytypaAnAwI5+ZoLklNzEpcc1 lspZf8Y4HKCIl7Nnn32Q= X-Received: by 2002:a05:6512:4014:: with SMTP id br20mr367798lfb.217.1644566113151; Thu, 10 Feb 2022 23:55:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJydHOLUQly5z5/n3J6Zyo44oRe5Cb1kw7CHFA1QovL6BrTI5b/J0cJpqZsCYFQMl9T+XS4+GjrpKDngclb77G8= X-Received: by 2002:a05:6512:4014:: with SMTP id br20mr367781lfb.217.1644566112923; Thu, 10 Feb 2022 23:55:12 -0800 (PST) MIME-Version: 1.0 References: <3d5cb5cba8ee4ae1d1de5eba1d009eaffbb49062.1639488393.git.wangyunjian@huawei.com> In-Reply-To: From: David Marchand Date: Fri, 11 Feb 2022 08:55:01 +0100 Message-ID: Subject: Re: [dpdk-dev] [PATCH 1/1] mem: check allocation in dynamic hugepage init To: Yunjian Wang Cc: dev , "Burakov, Anatoly" , dingxiaoxiong@huawei.com, xudingke , dpdk stable , Dmitry Kozlyuk Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Feb 5, 2022 at 6:29 PM David Marchand wrote: > > On Tue, Dec 14, 2021 at 2:30 PM Yunjian Wang wrote: > > > > The function malloc() could return NULL, the return value > > need to be checked. > > > > Fixes: 694161b7e065 ("mem: extract common dynamic memory allocation") That's actually introduced with: Fixes: 6f63858e55e6 ("mem: prevent preallocated pages from being freed") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yunjian Wang > Reviewed-by: David Marchand Applied, thanks. -- David Marchand