From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jerome.jutteau@outscale.com>
Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com
 [209.85.214.182]) by dpdk.org (Postfix) with ESMTP id 408A45961
 for <dev@dpdk.org>; Mon, 19 Oct 2015 11:43:04 +0200 (CEST)
Received: by obbzf10 with SMTP id zf10so133949295obb.2
 for <dev@dpdk.org>; Mon, 19 Oct 2015 02:43:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc:content-type:content-transfer-encoding;
 bh=drcl6c3LgoyocoE2tfdAwWmrHkHixJ79ocUzJ2moCGY=;
 b=g6FdUWtqsNp/Y0p7RVx8mDnlr3KAJw/zE+DFW9lUDdj8GkPwUH4OeP1LiVpEg4egpL
 Maj/pGJpZk01WREu7x5h7Rmb4Yoa4L35mQlTtPouOWxQUy99mWiML0bBvb75ZpLktfrl
 KeEbmmVtkwcypq7APm3pLnjF/N2PXWv8qgyQ4+LRyjfFTJFvSxu9gJf3Rf12KQSBPdSg
 K/WkFu/F2OHPz03bcMKomX9Mw6mo/WPptaCInD451c4gLD/EHfZYPtt8yznEfComP763
 R3cyxDTqD8lxePT/IVVxyiVcKvq4BzMNt6pIQRkHqvr6NTh+0T0bwjFwdTqTs7LnlYAa
 GF6g==
X-Gm-Message-State: ALoCoQkBtqVJBPuo098TaCYofe0fV/wbTOgBqsMkEbXFRLS6AJuWQ+yfhfQVbJK1V0EViqQk6ppO
X-Received: by 10.182.95.68 with SMTP id di4mr2849496obb.23.1445247783505;
 Mon, 19 Oct 2015 02:43:03 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.182.236.97 with HTTP; Mon, 19 Oct 2015 02:42:44 -0700 (PDT)
In-Reply-To: <20151019043548.GO3115@yliu-dev.sh.intel.com>
References: <1444986530-20893-1-git-send-email-jerome.jutteau@outscale.com>
 <1444986530-20893-3-git-send-email-jerome.jutteau@outscale.com>
 <20151019043548.GO3115@yliu-dev.sh.intel.com>
From: =?UTF-8?B?SsOpcsO0bWUgSnV0dGVhdQ==?= <jerome.jutteau@outscale.com>
Date: Mon, 19 Oct 2015 11:42:44 +0200
Message-ID: <CAJFondOqFAC=yQt-ta68cqdxiCBBvveEWLCM83ofoFQzm8_iGw@mail.gmail.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/3] vhost: check that a device exists during
	reset_owner
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Oct 2015 09:43:04 -0000

Hi Yuanhan,

2015-10-19 6:35 GMT+02:00 Yuanhan Liu <yuanhan.liu@linux.intel.com>:
> I would call get_device() here, which dumps an error message when
> it's NULL so that user will get noticed.
>
> Besides that, the 3 patches look good to me, and,
>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Thanks for your review, a v2 is coming soon with get_device().

--=20
J=C3=A9r=C3=B4me