From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1086BA0562; Tue, 31 Mar 2020 11:48:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E38DE1BFC6; Tue, 31 Mar 2020 11:48:04 +0200 (CEST) Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by dpdk.org (Postfix) with ESMTP id D5E101BFC1 for ; Tue, 31 Mar 2020 11:48:03 +0200 (CEST) Received: by mail-ed1-f65.google.com with SMTP id o1so6094609edv.1 for ; Tue, 31 Mar 2020 02:48:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AQm4a5u38bVQDqME91RKtFRuJUIrbQmqxwzITufvghg=; b=tTi0HBeeBmNSB9RVSpBCezfiPkrn3CaKXQauIvCcUaaK0/zNEzgom56iiswUAKYyE+ 1EARrNkcVa2kkm+qOFdJUqo3wfqlRV3kghDddgnxE956Z/Y/maia8mcW4R4V1drLkbgg ytmz48Omjzn8vUyEvb7m9rIZPklr8jDtUT1JNe4WRU35yztsOIqrHf0KWG1/56GQuk0d xAK/L2EeVpRjI2Kt7vjlxUgs+bA+23iCBRGwVYtjdQ32+FJAZ80ig7eDxl62jcWdIWdO yRkNq0+lvCGBBZJsaxUH3qaw+QSQb/TgukhR2qEa5mEHiWFaAJjYfgHJuFAhx4ymb7xd vF6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AQm4a5u38bVQDqME91RKtFRuJUIrbQmqxwzITufvghg=; b=JwHV/PMG+orZR5kMH3nMYoJqwaAPf8o5cCijuqXMu4MgSHopx70jMjc7sh68JXmng0 pQIlTkRUfTz5kpT9P6XARvxjpLu7b8kKJ2Uy8jyCdNP+fe1nxX8MUtnm/MI01wpSHWka p7HjPtizfrR2LnImn1niyYfz73KO1AekQ8ntxH7paPnGACnMXkZ1edh7DxSVJq03pb+4 aOx390DnheRj35VpEoIiksE/orOv+S6LzyFYWDZtAStbo8017YOVBPjAJw3b3YEP4y1j vlXOQ8jSJ8aC5TseNzKKUM7yQCMe6b1vGeLruKkHlllt8TwRJHuK3G1+c9cGDA3MCTs3 RQWg== X-Gm-Message-State: ANhLgQ2U2rIH3AkEJFwNXsOC/Mdq9ZF1lpgDTj+pgR5c95l4lLQAFf1P qqxZB+Hd5MhTGcBhYawCkh2pZJbVAJ0laRUsoGcePg== X-Google-Smtp-Source: ADFU+vuSFl7Lbx6uN9LnVmyvPGfyOSK6a8zS2JoknkI2RSrqrfd7kdQRciwOxUeEA/9cKBhp+3mIpA82dLJSfwHwoXc= X-Received: by 2002:aa7:ccd4:: with SMTP id y20mr14807054edt.119.1585648083626; Tue, 31 Mar 2020 02:48:03 -0700 (PDT) MIME-Version: 1.0 References: <20200327101823.12646-1-mk@semihalf.com> <20200327101823.12646-2-mk@semihalf.com> <11e2a98d-99dc-5ee8-64fc-69e17724d127@solarflare.com> In-Reply-To: <11e2a98d-99dc-5ee8-64fc-69e17724d127@solarflare.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Tue, 31 Mar 2020 11:47:52 +0200 Message-ID: To: Andrew Rybchenko Cc: dev@dpdk.org, Marcin Wojtas , Maciej Bielski , "Tzalik, Guy" , "Schmeilin, Evgeny" , "Chauskin, Igor" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 01/29] net/ena: check if size of buffer is at least 1400B X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pt., 27 mar 2020 o 11:56 Andrew Rybchenko napisa=C5=82(a): > > On 3/27/20 1:17 PM, Michal Krawczyk wrote: > > Some of the ENA devices can't handle buffers which are smaller than a > > 1400B. Because of this limitation, size of the buffer is being checked > > and limited during the Rx queue setup. > > > > If it's below the allowed value, PMD won't finish it's configuration > > successfully.. > > > > Signed-off-by: Michal Krawczyk > > Reviewed-by: Igor Chauskin > > Reviewed-by: Guy Tzalik > > --- > > drivers/net/ena/ena_ethdev.c | 12 ++++++++++++ > > drivers/net/ena/ena_ethdev.h | 1 + > > 2 files changed, 13 insertions(+) > > > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.= c > > index 665afee4f0..a8f8784a9f 100644 > > --- a/drivers/net/ena/ena_ethdev.c > > +++ b/drivers/net/ena/ena_ethdev.c > > @@ -1282,6 +1282,7 @@ static int ena_rx_queue_setup(struct rte_eth_dev = *dev, > > { > > struct ena_adapter *adapter =3D dev->data->dev_private; > > struct ena_ring *rxq =3D NULL; > > + size_t buffer_size; > > int i; > > > > rxq =3D &adapter->rx_ring[queue_idx]; > > @@ -1309,6 +1310,17 @@ static int ena_rx_queue_setup(struct rte_eth_dev= *dev, > > return -EINVAL; > > } > > > > + /* ENA isn't supporting buffers smaller than 1400 bytes */ > > + buffer_size =3D mp->elt_size - sizeof(struct rte_mbuf) - > > + RTE_PKTMBUF_HEADROOM; > > + if (buffer_size < ENA_RX_BUF_MIN_SIZE) { > > + PMD_DRV_LOG(ERR, > > + "Unsupported size of RX buffer: %zu (min size: %d= )\n", > > + buffer_size, ENA_RX_BUF_MIN_SIZE); > > + return -EINVAL; > > + } > > + printf("mempool size: %ld\n", buffer_size); > > Is it debug printout left? > Yes, sorry. I'll remove it in v2. > > + > > rxq->port_id =3D dev->data->port_id; > > rxq->next_to_clean =3D 0; > > rxq->next_to_use =3D 0; > > diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.= h > > index af5eeea280..c1457defeb 100644 > > --- a/drivers/net/ena/ena_ethdev.h > > +++ b/drivers/net/ena/ena_ethdev.h > > @@ -20,6 +20,7 @@ > > #define ENA_MIN_FRAME_LEN 64 > > #define ENA_NAME_MAX_LEN 20 > > #define ENA_PKT_MAX_BUFS 17 > > +#define ENA_RX_BUF_MIN_SIZE 1400 > > > > #define ENA_MIN_MTU 128 > > > > >