From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31949A0C46; Fri, 23 Jul 2021 11:50:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E721940040; Fri, 23 Jul 2021 11:50:02 +0200 (CEST) Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by mails.dpdk.org (Postfix) with ESMTP id 1D51F4003C for ; Fri, 23 Jul 2021 11:50:02 +0200 (CEST) Received: by mail-il1-f173.google.com with SMTP id a14so1042366ila.1 for ; Fri, 23 Jul 2021 02:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Az8YvHc1eKRbJ3HH/z+mi08tlFcl1xbLOhd57yYWZs0=; b=wSNHQ3mGKMSOfdXiaH7kbjG+LZmgAJ47fdI671TtMnKiHsBdmaExUlqbgFz1UMbhH8 dSrpixdrfk7CgIvFqm+7TM4nC6FkSjsaPIQ/qRP43WvNjiYhLNF2sy8fdB0K9MzxIFPo L3njRqasC2gNoWdfTpXc0z1z2cDX+qnjzzWw6+N6VSy7Bv2Wy6k2Rn4p9+GmNfJNKmEG wLwj5vYLf5Ysg392Rx3Q/E8qksJHW3cTPw2XsBfqY7zwd5SfIb4NsQB8r9R0kgoTRe3M OKVl7vftrJbYp+o4D2xjlMhzp6Y/kW+nRexfY5UprpKQDjpuhY1+S/5HsAj19AsTazSM UV0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Az8YvHc1eKRbJ3HH/z+mi08tlFcl1xbLOhd57yYWZs0=; b=TuwZDtgC3vhnOFeEJQzGYGO0YG1J7FcP1vvY66mCBvxMgjUcLQCVx/WeUh0NAtGl1Z fBJpUQjKPEECsAO9VDKrXYlDf0on09j8ErY/+K8oKbP4IZ2mItZJYNhYtAwCQj2inuNt z5cnFinGKfv3yHxaX0cdznimzyuw+XIUj4vjTPBtUZjB1Nm5lOvmqEb1dDkzddqVL6vL 3tFOIf+0qWatWgxHJXeCJx2BRDJdUKpqt8qj230HFgLh8nkqlghTqu+Xn4DpuhjGSbv2 yh6oOshkgeXh/sLmjswDUkJH9y3sN6dhSHsQjkV4HK/MgV47H2J0f/5b8UcQhNGo72Ve Xosg== X-Gm-Message-State: AOAM531KcSLlYlsE5dhfVQm3/aqGTaCASd1Mn7ZpnIJG3523kxFonL5U VP4pm1iPDpa2Gxnay5BMf30KIe6WSa7ViX6/bVOQKw== X-Google-Smtp-Source: ABdhPJw9luX+wZGSdaZLdhIgn9OdWZSPLc1MX2nDqKiwcsD+3g6aHPDKRvvNSzgN3AMvi3yneh5WYEl59tqHiVfWBGg= X-Received: by 2002:a92:260f:: with SMTP id n15mr2938020ile.143.1627033801555; Fri, 23 Jul 2021 02:50:01 -0700 (PDT) MIME-Version: 1.0 References: <20210714103435.3388-1-mk@semihalf.com> <1691540.9AlFL3h5L8@thomas> <4131521.qjy5Xc5Wae@thomas> In-Reply-To: <4131521.qjy5Xc5Wae@thomas> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Fri, 23 Jul 2021 11:49:50 +0200 Message-ID: To: Thomas Monjalon Cc: dev , "Dagan, Noam" , "Brandes, Shai" , upstream@semihalf.com, Shay Agroskin , Amit Bernstein , Ferruh Yigit , David Marchand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pt., 23 lip 2021 o 11:43 Thomas Monjalon napisa=C5=82= (a): > > 23/07/2021 11:39, Micha=C5=82 Krawczyk: > > pt., 23 lip 2021 o 11:22 Thomas Monjalon napisa= =C5=82(a): > > > > > > 14/07/2021 12:43, Michal Krawczyk: > > > > + PMD_DRV_LOG(WARNING, > > > > + "Setting RSS hash fields is not supported. = Using default values: 0x%llx\n", > > > > + ENA_ALL_RSS_HF); > > > > > > > > > > checkpatch is returning this warning: > > > Using %l format, prefer %PRI*64 if type is [u]int64_t > > > > > > Indeed rss_hf is uint64_t. > > > > > > > > > > Hi Thomas, > > > > I'm aware of that checkpatch warning, but changing format to %PRIx64 > > results in another (compilation) warning: > > > > [1205/2572] Compiling C object > > drivers/libtmp_rte_net_ena.a.p/net_ena_ena_rss.c.o > > In file included from ../drivers/net/ena/ena_rss.c:7: > > ../drivers/net/ena/ena_rss.c: In function =E2=80=98ena_rss_hash_set=E2= =80=99: > > ../drivers/net/ena/ena_logs.h:35:3: warning: format =E2=80=98%lx=E2=80= =99 expects > > argument of type =E2=80=98long unsigned int=E2=80=99, but argument 5 ha= s type =E2=80=98long > > long unsigned int=E2=80=99 [-Wformat=3D] > > 35 | "%s(): " fmt, __func__, ## args) > > | ^~~~~~~~ > > ../drivers/net/ena/ena_rss.c:427:3: note: in expansion of macro =E2=80= =98PMD_DRV_LOG=E2=80=99 > > 427 | PMD_DRV_LOG(WARNING, > > | ^~~~~~~~~~~ > > In file included from ../lib/mempool/rte_mempool.h:40, > > from ../lib/mbuf/rte_mbuf.h:38, > > from ../lib/net/rte_ether.h:23, > > from ../drivers/net/ena/ena_ethdev.h:10, > > from ../drivers/net/ena/ena_rss.c:6: > > /usr/include/inttypes.h:121:34: note: format string is defined here > > 121 | # define PRIx64 __PRI64_PREFIX "x" > > > Sorry I don't have time to dig, but I'm sure you can fix it. > > Yeah, sure, casting ENA_RSS_HF to uint64_t in this log should do the trick - I'll fix that in the v4. Thanks, Michal