From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f196.google.com (mail-ua0-f196.google.com [209.85.217.196]) by dpdk.org (Postfix) with ESMTP id D3ED61B5F6 for ; Wed, 27 Jun 2018 10:36:56 +0200 (CEST) Received: by mail-ua0-f196.google.com with SMTP id g6-v6so751069uam.2 for ; Wed, 27 Jun 2018 01:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NLiRQpyO2cO6TVKHUBpXhFx99Ne7SbW9hb3J5pEiFdg=; b=jtQ8LvVPGmPmRVpB8RRY5qSlIXTLrsCW6aQ/cHhE1dyV/+vlRLkEQLtZrSNvITwias /w4KrqXp/JuK5OJUzwJRDeRnS9Kfhr1nDmt0rpE8OTdMkBmp2dJY7OxT8nm+w2H+/Xv2 s3i/c4tCoZU8putf3jOswJyaI3KRMPckfKIn96zmgBLhqUOshvgfy+pTj0iQe+swpQRE k4FJYtG/S7sJGblvS/9A0Hwri9LGXIWBigaFeHvs101T6bG7fl6PmIA9SJDyx00dhw+5 eW0cyyNy/WOONdcNEuHvAjuellQ7riGd/RV9viRR5YYszcXyyjCdT016C4TGPAK+Y1Ci gUSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NLiRQpyO2cO6TVKHUBpXhFx99Ne7SbW9hb3J5pEiFdg=; b=IhwTK5wJ7L1EXNc+dhGJz/eHuRyGtGLK1iErD4LHgAv5dM4c2pX8gwgQLl6r43WUBx CSiOBjsEhQCPfQb7NdZTB0YauqZ0GOAnF+Eenl69qK0jE6SDGI4hBz9NiwdWm9dx+YZy 2xF2y+cZITZGQLDfW9OaC5Nvd/XVDVVjAzsKrf31fRqJA0cX4O4a11DsYMLj/qpTDl+D nGsqCoBvvu4bkNEMRm+BMfYxldxW04/BhGZWXeIeW3lveYQw+YKuP8CG+RDYWAhAVQ05 aNvhGjlx2BtSCzEcu2UQuYJSakABRh//9GcoQhkuYNQVJG8vCR8XamlZGCUGTOH8St8H q11w== X-Gm-Message-State: APt69E00O9iQnRsVrqMaMcaPqZaqwd+22ylJDNKyi09Wnaawq3ail2oW jwsPKIagXyY5COIc5qw68q7jryEu29JVBpLD1kb9fw== X-Google-Smtp-Source: AAOMgpflBPr6FKZvRzPXT3u4PcaxGCvOA36sGutiSoyznXlYgyVajkxHUzm2p2rz+KCBWYw0icVqCuLYWIhhxCH3Px4= X-Received: by 2002:ab0:5682:: with SMTP id a2-v6mr3148976uab.77.1530088616181; Wed, 27 Jun 2018 01:36:56 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:62c7:0:0:0:0:0 with HTTP; Wed, 27 Jun 2018 01:36:55 -0700 (PDT) In-Reply-To: References: <20180625134046.12448-1-daria.kolistratova@intel.com> <20180626110734.25181-1-daria.kolistratova@intel.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Wed, 27 Jun 2018 10:36:55 +0200 Message-ID: To: Ferruh Yigit Cc: Marcin Wojtas , "Tzalik, Guy" , "Schmeilin, Evgeny" , Daria Kolistratova , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/1] ena: fix SIGFPE with 0 rx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 08:36:57 -0000 2018-06-26 18:53 GMT+02:00 Ferruh Yigit : > On 6/26/2018 6:38 PM, Ferruh Yigit wrote: >> From: Daria Kolistratova > > I re-send the Daria's patch, somehow it didn't appeared in mail list and patchwork. > >> >> When the number of rx queues is 0 >> (what can be when application does not receive) >> failed with SIGFPE. It happens when the application >> is also requesting ETH_MQ_RX_RSS_FLAG in the >> rte_dev->data->dev_conf.rxmode.mq_mode. >> Fixed adding zero rx queues check. >> >> Signed-off-by: Daria Kolistratova Acked-by: Michal Krawczyk >> --- >> drivers/net/ena/ena_ethdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c >> index 9ae73e331..3249b9d92 100644 >> --- a/drivers/net/ena/ena_ethdev.c >> +++ b/drivers/net/ena/ena_ethdev.c >> @@ -1052,7 +1052,7 @@ static int ena_start(struct rte_eth_dev *dev) >> return rc; >> >> if (adapter->rte_dev->data->dev_conf.rxmode.mq_mode & >> - ETH_MQ_RX_RSS_FLAG) { >> + ETH_MQ_RX_RSS_FLAG && adapter->rte_dev->data->nb_rx_queues > 0) { >> rc = ena_rss_init_default(adapter); >> if (rc) >> return rc; >> >