Re: [dpdk-dev] [PATCH] Fix loss of data stored in udata64 mbuf field

["Michał Krawczyk" <mk@semihalf.com>]

czw., 4 lut 2021 o 10:01 David Marchand <david.marchand@redhat.com> napisał(a):
>
> On Thu, Feb 4, 2021 at 9:52 AM Michal Krawczyk <mk@semihalf.com> wrote:
> >
> > DPDK v20.11 removed udata64 field, and changed type of the dynfield1 to
> > uint32_t.
> >
> > Due to define:
> >   lib/common/pg_compat.h:#define udata64                 dynfield1[0]
> > the copy of udata64 was in fact copying only the first 32 bits.
>
> I did not look at the pktgen code, but directly accessing mbuf field
> dynfieldX is likely a bug.
>
> pktgen should register a dynfield for its own usage to avoid conflicts
> with other parts of the dpdk.
> Example of such a conversion to the new mechanism:
> https://git.dpdk.org/dpdk/commit/?id=eb8258402b3f
>

Hi David,

thanks for pointing this out. I wasn't aware of that, I'll rework my
fix to satisfy the dynfield requirements.

Best regards,
Michal

>
> --
> David Marchand
>