From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B72F3A0524; Thu, 4 Feb 2021 10:18:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F2982405FC; Thu, 4 Feb 2021 10:18:06 +0100 (CET) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mails.dpdk.org (Postfix) with ESMTP id CFEF92405FB for ; Thu, 4 Feb 2021 10:18:05 +0100 (CET) Received: by mail-ej1-f54.google.com with SMTP id i8so4085262ejc.7 for ; Thu, 04 Feb 2021 01:18:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5LLoTYbw1g4iuBXlnF9AVSLeHuxF4Vibl3sfVm7wA+0=; b=aMIX3U4sq06VAaSWjsyHv3XPUkD91f9Zn6Y+36dTbu4/eZJosEo10MNCPeKBonAdPy tTkQOydhvf1lyVn1JhUlSzGhxAW7D7Gk5RjXNb12yYKF8+CVrZKmL+LLiGj6KRhtXaVS C4H7EeHFUQF/DUXVm24erPWKwf3PUwsg3nNFx1u+0OK2XvcGytx5V4AmI7CeQ0MhKqaf kcukTVTpaSEn37A73SjVKwY1QrXj3LoEF/qrxEm7/2/9ek1+m9fLKgtKRGC1r6f5B+wH mwlUgLxPdoziR+VwU280jNxzjhqn72n0dURzh6XW2B1ebHvIFgi65iVFfhIbgRzJy2J2 +49w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5LLoTYbw1g4iuBXlnF9AVSLeHuxF4Vibl3sfVm7wA+0=; b=sXfD/dWPk640WcVoZptQBflROVot0y7cU+7O040qhRZHzm7fWZ9VcAjkp0+DUKHeoQ MRXzkZw7AQr2i2qzt9HUCikNeDzFSQ/uS+Nn4RPY5aLSZJzxiIADMPfU26k0DQtBsQmy +hRn+dp9CdF38WB7wX2TIHn0aiOTQlubyujQ3YbbMnAb28ynGL7XUfu6oV2jXuMsFJUt Gu0eD5D0z0H8JrxmPSq1oDqVuQA4OuFP3cS3LTTgElmEUwZcrqh/2gOh8Id/3IxD/DQp fdj6idW5MOiHqN1gte25tXPNbAm+thOecokxS+rkptSe7zoNE5UwczgBkTJZDTFTAXxo Aahw== X-Gm-Message-State: AOAM530bX9Juh5MstGuuAAwAOWqaQXgimLWmM24URGnXqbZBR1IYqmpM fHMuHLSIdu5qT+wR0jXzIPrveERtraeYehQy536gxQ== X-Google-Smtp-Source: ABdhPJwXlKtoykvrrm5j440JbCv00QkUHdcFzmrzLVVf8FgbFRA8PLbY+15GPhEznhqMkl/CJvSxWrmiEmtxCi7dj7s= X-Received: by 2002:a17:906:c446:: with SMTP id ck6mr6802888ejb.491.1612430285464; Thu, 04 Feb 2021 01:18:05 -0800 (PST) MIME-Version: 1.0 References: <20210204085209.2716232-1-mk@semihalf.com> In-Reply-To: From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Thu, 4 Feb 2021 10:17:54 +0100 Message-ID: To: David Marchand Cc: "Wiles, Keith" , dev , Igor Chauskin , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] Fix loss of data stored in udata64 mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" czw., 4 lut 2021 o 10:01 David Marchand napisa= =C5=82(a): > > On Thu, Feb 4, 2021 at 9:52 AM Michal Krawczyk wrote: > > > > DPDK v20.11 removed udata64 field, and changed type of the dynfield1 to > > uint32_t. > > > > Due to define: > > lib/common/pg_compat.h:#define udata64 dynfield1[0] > > the copy of udata64 was in fact copying only the first 32 bits. > > I did not look at the pktgen code, but directly accessing mbuf field > dynfieldX is likely a bug. > > pktgen should register a dynfield for its own usage to avoid conflicts > with other parts of the dpdk. > Example of such a conversion to the new mechanism: > https://git.dpdk.org/dpdk/commit/?id=3Deb8258402b3f > Hi David, thanks for pointing this out. I wasn't aware of that, I'll rework my fix to satisfy the dynfield requirements. Best regards, Michal > > -- > David Marchand >