From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f65.google.com (mail-vk0-f65.google.com [209.85.213.65]) by dpdk.org (Postfix) with ESMTP id 075251066 for ; Mon, 18 Jun 2018 10:32:35 +0200 (CEST) Received: by mail-vk0-f65.google.com with SMTP id o138-v6so9024753vkd.3 for ; Mon, 18 Jun 2018 01:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=arITxxBddPMiwz3KsIo2y+aIRoFuwa1qeBLd2tNvYBE=; b=RRPG2+5mx/rDhxvwuBa/L/EJ7VzrNJFY4TZTs0xLXZ7vSDKcrSUShSe8LvpUtzPjE3 ZSpG5uOTgGTDACg6APnH+9HnTySLmNUldfdRphZXkDesRnAfJQ4UMxleY7QNvrAh3ksd eer3jI5whnyTN5s4iLacSWZmc9DAQOZShplQN87iU7YgKupFKAQhAgtZRp33wll3M1iN 4+U+FUq36mjzTUjbt+cz+utiK0Pwvh1jne52VNKLYs61fgFJAcq6HvCtCcLrJB5Scy3/ AJCdZqQ/VwPD6fGA10AaqSIkLPnbsUv8jyNe25ey4AmZrhI///b2OT+y8AjeV2uzQgQd 82KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=arITxxBddPMiwz3KsIo2y+aIRoFuwa1qeBLd2tNvYBE=; b=AAZ1ulw0mA4yXIARCNxhgipzNDuV4hMbgz2CFg/lU3PyIMZDxXwaDVgVUndsWKflYV fV7TzcD2Gh9IxEP7X/kUWprpBPB4ql4oaSMzKtcyngn94cZQnz75+xSzfD8WdQeb0gHn PdzbE5XKJFDWyNXceAP3uSrT/K9xbqEHUtPrLt+WNcLIMrNDZQHUsESSSUFG8ugcprgE XloUL1PiwYFfTJgEImTw7+ncv5Km0XHX0cZphC5BRKT9p8AYZj7cswjfUN0Fa4toIhpQ FTPBSAhnFPAV0IpygJ6cWT93LONLDGnusQiVmTa2gNNLYYCx12/4akQRtzNuPP1T8ZX0 FWNQ== X-Gm-Message-State: APt69E0hyD/IOY3rxXr6+9VXJGldhN4jMlvfy7mYf+TGOcjFLdd7sl9S vf2l/WAWbGE27wWOADgMc0ETHSOHkhIOJEBCB6OdSg== X-Google-Smtp-Source: ADUXVKJ8tJUTP2ii4s4qbCQCVGpWN4LhDkHI9kU/56WVFrwgHy0djGzlOHb4DYqeNayEoRhl4POymIXg5jKf2Nn7/yQ= X-Received: by 2002:a1f:ce43:: with SMTP id e64-v6mr6335401vkg.49.1529310754381; Mon, 18 Jun 2018 01:32:34 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:62c7:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 01:32:33 -0700 (PDT) In-Reply-To: <6508461.cpII4DF8a3@xps> References: <20180607094322.14312-1-mk@semihalf.com> <3540745.n2F2IE3GfD@xps> <6508461.cpII4DF8a3@xps> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Mon, 18 Jun 2018 10:32:33 +0200 Message-ID: To: Thomas Monjalon Cc: dev@dpdk.org, Marcin Wojtas , Guy Tzalik , Evgeny Schemeilin , "Matushevsky, Alexander" , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 10/27] net/ena: add lrte_timer dependency for linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 08:32:35 -0000 2018-06-18 10:30 GMT+02:00 Thomas Monjalon : > > 18/06/2018 08:04, Micha=C5=82 Krawczyk: > > 2018-06-18 0:37 GMT+02:00 Thomas Monjalon : > > > 07/06/2018 11:43, Michal Krawczyk: > > >> ENA PMD is required to use librte_timer. The appropriate depndency m= ust > > >> be added ifin case the DPDK will be built as shared library. > > >> > > >> Signed-off-by: Michal Krawczyk > > >> --- > > >> drivers/net/ena/Makefile | 1 + > > >> mk/rte.app.mk | 1 + > > >> 2 files changed, 2 insertions(+) > > >> > > >> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile > > >> index 43339f3b9..ff9ce315b 100644 > > >> --- a/drivers/net/ena/Makefile > > >> +++ b/drivers/net/ena/Makefile > > >> @@ -58,5 +58,6 @@ CFLAGS +=3D $(INCLUDES) > > >> LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > > >> LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs > > >> LDLIBS +=3D -lrte_bus_pci > > >> +LDLIBS +=3D -lrte_timer > > >> > > >> include $(RTE_SDK)/mk/rte.lib.mk > > >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk > > >> index 1e32c83e7..c70bc254e 100644 > > >> --- a/mk/rte.app.mk > > >> +++ b/mk/rte.app.mk > > >> @@ -60,6 +60,7 @@ endif > > >> > > >> _LDLIBS-y +=3D --whole-archive > > >> > > >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) +=3D -lrte_timer > > > > > > Why is it added in rte.app.mk? It is already there, few lines below. > > > > I think that's because it wasn't present on the version I was > > preparing the patch (18.02) and I didn't notice that it was added > > meantime when I was rebasing this patch. > > > > This patch is already merged to dpdk-next-net. Should I add a patch > > that is reverting this change there? > > I can remove it when pulling next-net today. Ok, that will be fine, thanks.