From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 609DAA09E4; Fri, 29 Jan 2021 13:16:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E17C3240134; Fri, 29 Jan 2021 13:16:53 +0100 (CET) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by mails.dpdk.org (Postfix) with ESMTP id 7E49A40694 for ; Fri, 29 Jan 2021 13:16:52 +0100 (CET) Received: by mail-ej1-f52.google.com with SMTP id g12so12666662ejf.8 for ; Fri, 29 Jan 2021 04:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=q2bus96FO19gi4LOlCIcGLmUbQV/7iIq+6qZLAzYecM=; b=RwITl6dx2afZL8Ma8RqqCrQhYvmVH8kaBHU2oFJDQozQ3Ct+S8Z9FxrkIWVR+iu7+/ LwPDhzEyTT+JyBW6jXGtnjqocCvkL4eZHrXKHlIzUUd6xMYvYrfTkY+ZVMgiPQ9/ThfZ zp0EwtfpurYD3flt3R0fp1ywtB6J/wWHPa/4zmc5reMu7B3rXmIASfd9HWVB7Hct08YO tL10GODRik3K2yxlfaZd9jfte4pBi8n+L4CY82YRIrQO+GRkvDXuPRpao4LBOmCB5jHV 0Z+C9qA/XunOmjJdjeYhWnwOxLWzPEj5QzV4jTROKzrA4fKEq6nGLMsaTKsm+m11Ik8Y o2sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=q2bus96FO19gi4LOlCIcGLmUbQV/7iIq+6qZLAzYecM=; b=mDBa0EjO+cJENwKl0FxTm5iLPN4GlugPOZkc5i601aN2+eVett7xvCQX2Nn1XpsyQt FtP/uH/Nuvgu1rIymaYMtnS0ZZx9KQuoc1WDTFJxnZX5YxsY2R1sCx2aknP+i7pb9ZOA MpX/lSwmKPowpuw3AGZH5aND62IC7UDXg3kt09f17Gij8ZwbeXdGRL5T9ykAkO4MUQvh U16PDlMeBNWNzQlb/Bc2wGk8mc+YMOvJowSDO8PUC5/KGm2bxuZHneLy868GLRVXUJtT B3jLS7tDAQDn7QAL7vJgZPvWO5JFNJJETDtDJO1RjdqcBACnOvOiOG7tyjRVGrqTNThg 3fkw== X-Gm-Message-State: AOAM533Wh7EeMz1zAH39lM4vuH1+ShqBUvNUjdZCOLGY49C+3+X7DSKl xBq6GY0pKlLO3MK/rsxRBrWMN2+8j3QMs1gU07kiGw== X-Google-Smtp-Source: ABdhPJzeeoz1xVAbF5T3K84RJKcaVGNAdWCwNnVHY21l53EDXfb+7gfRgXCn9WddX9a2Xj9tfNPayIpOa4Y89eEbanQ= X-Received: by 2002:a17:906:e203:: with SMTP id gf3mr4255238ejb.117.1611922612192; Fri, 29 Jan 2021 04:16:52 -0800 (PST) MIME-Version: 1.0 References: <20210126183226.2420903-1-mk@semihalf.com> <20210126183226.2420903-5-mk@semihalf.com> <97d9c7eb-7bc2-3076-b5bf-f835958ca483@intel.com> In-Reply-To: <97d9c7eb-7bc2-3076-b5bf-f835958ca483@intel.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Fri, 29 Jan 2021 13:16:39 +0100 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, "Tzalik, Guy" , "Chauskin, Igor" , Marcin Wojtas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 4/5] net/ena: fix Tx sq free space assessment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pt., 29 sty 2021 o 13:07 Ferruh Yigit napisa=C5=82= (a): > > On 1/26/2021 6:32 PM, Michal Krawczyk wrote: > > From: Igor Chauskin > > > > Before starting transmission of Tx burst, the driver checked the > > available space in the sq and limited the number of packets for > > transmission accordingly. > > The calculation was incorrect for fragmented packets and potentially ha= d > > significantly limited the length of Tx bursts. > > > > This patch removes the assessment and pushes packets to the sq as long > > as the burst is not exhausted and space is available in the sq. > > > > Correct evaluation of the required space isn't possible before the burs= t > > because it depends on the number of segments of each packet. > > This patch adds per-packet space evaluation for each packet before > > attempting to process it. In case there is not enough queue space, the > > burst will just stop without error. > > > > Signed-off-by: Igor Chauskin > > Reviewed-by: Michal Krawczyk > > Hi Michal, Igor, > > Can you please provide fixes line for the patch, and I assume you want it= to be > backported? > Hi Ferruh, thanks for the note! I'll update missing fixlines in v3 for both patch 4 an= d 5. Thanks, Michal