From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ED5FA0A0E; Mon, 10 May 2021 14:02:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE35F40140; Mon, 10 May 2021 14:02:22 +0200 (CEST) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by mails.dpdk.org (Postfix) with ESMTP id 935BA4003E for ; Mon, 10 May 2021 14:02:22 +0200 (CEST) Received: by mail-il1-f182.google.com with SMTP id v13so13801697ilj.8 for ; Mon, 10 May 2021 05:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1zX8uO9DXJ1yntnQzSbDsFDSxcdhMSuJjyEqIYzPrGU=; b=U8L2jJztIKjVFEAbklqMizGX86h+S7PitO86h+mFNWGSUwRnZgemjx2R9RkXwz0jdF zsFrg7QBrQMMejWTCrEOwg0eEkU5SpzA6bwf5+3LzGhLPIz72BT2h+vyCsHw7sA5JZtH CDXDSm+H/t3npYyOKH6sndZ/Dx/hSHAEowNKaBu6l33UaydVrahKWVvh+g3ix7T2kyxN 5R3xFS1htHJ6UESGpGSUadhi0XkJ2b8jS+oJr0JZMzmXoug3/y9i/Spe1huk7uq0JiPX D0jbiVtjp9+ShaBaG4CPpasnXnu3LNU8uuHVh3EKTGnFsAR0fas52X/hG8P2YNVXrhQE gr2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1zX8uO9DXJ1yntnQzSbDsFDSxcdhMSuJjyEqIYzPrGU=; b=aWi2Q+jZZd54znPqbn7j9rAydau3qGRLRYCBv37fAjl7ZWD1Gz4AzKRPHWp8eiQdiV kvNht+CDU1jW2L8CEs9T4lAob4iD/WcEEAH2v79wfkxqdIhBZz4kdERvGXaNdSd83SDd 6bGVscSFCb7V3i8OBnznnR2T+elRK4pyb9w/bISrO4WrN2GbrFmHmdMuq/sZ99Gg1Rfo DTVPr4QqqdzDHuKcAduk3BU0AU7Wqoo5QapJ9F5pKv9+enFTVFgwqEb1WpilgU0aUJDC oG5qsOYYVzqrp67YcwIHUmrEvE6IBQb3qjptxW+UyjbsclyXxjwQxMDlCTAXefy0hE22 PrOw== X-Gm-Message-State: AOAM53041SmOK+G6XlisYUjpXcCv3VN4vFOB+IJWCk14uo26MWhnjM7y GCtKVQLUJCPvLp5Oale3LwHmx20b4H8TGjCkwq+A8Q== X-Google-Smtp-Source: ABdhPJytXZzcU865jMFQ0lucAiFR7OHBUoTn2yy/PFoSvxwbhR3muBeDEBhJvT5fwAxHxiamJofz+ZUWzMNz4Y+vRtI= X-Received: by 2002:a92:1a0a:: with SMTP id a10mr21579305ila.195.1620648141808; Mon, 10 May 2021 05:02:21 -0700 (PDT) MIME-Version: 1.0 References: <20210505073348.6394-1-mk@semihalf.com> <20210506142526.28245-1-mk@semihalf.com> <4fae6792-f42f-1160-9af9-a3b055565ea0@intel.com> In-Reply-To: <4fae6792-f42f-1160-9af9-a3b055565ea0@intel.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Mon, 10 May 2021 14:02:10 +0200 Message-ID: To: Ferruh Yigit Cc: dev , "Dagan, Noam" , "Tzalik, Guy" , "Chauskin, Igor" , upstream@semihalf.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 00/22] net/ena: update ENA PMD to v2.3.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pt., 7 maj 2021 o 16:59 Ferruh Yigit napisa=C5=82(= a): > > On 5/6/2021 3:25 PM, Michal Krawczyk wrote: > > Hi, > > > > this version updates the driver to version 2.3.0, which fixes multiple > > bugs, contains part of the work on making the ENA PMD fully MP aware, a= nd > > also updates HAL to the latest version. > > > > More detailed list of changes: > > * memcpy mapping to the dpdk-optimized version. > > * ena_com (HAL) update to the latest version. > > * Bug fixes for the large LLQ headers and devargs parsing. > > * Mbuf RSS hash presence indication. > > * Bug fix for the default ring size. > > * Various fixes for the SMP mode. > > > > v3: > > * Fix build of the PMD with the debug flags enabled. > > * Fix typo in the commit log of the version upgrade patch. > > > > v2: > > * Fix nested declaration of the rte_memcpy on arm64 architecture. > > > > Amit Bernstein (1): > > net/ena/base: adjust changes to lastest ena-com > > > > Igor Chauskin (2): > > net/ena: switch memcpy to dpdk-optimized version > > net/ena: fix parsing of large_llq_hdr argument > > > > Michal Krawczyk (12): > > net/ena/base: unify arg names for the functions > > net/ena/base: add dev arg to the logging macros > > net/ena/base: typos, style and comments improvements > > net/ena/base: fix issues from the static code scan > > net/ena/base: destroy multiple "wait events" > > net/ena/base: remove indir table from ENA feat ctx > > net/ena/base: remove mutable RSS from the host info > > net/ena/base: update generation date and commit > > net/ena/base: use rte_prefetch0_write > > net/ena: terminate devargs allowed keys with NULL > > net/ena: indicate Rx RSS hash presence > > net/ena: update version to v2.3.0 > > > > Stanislaw Kardach (7): > > net/ena: remove endian swap functions > > net/ena: handle spurious wakeups in ENA_WAIT_EVENT > > net/ena: support SMP for mz alloc counter > > net/ena: move default RSS key to shared mem > > net/ena: make ethdev references smp safe > > net/ena: disable dev_ops not supported in SMP > > net/ena: report default ring size > > > > Hi Michal, > > There are some checkpatch and check-git-log.sh [1] warnings, can you plea= se > check them? > Hi Ferruh, sure, I'll check them all and fix whatever is possible. The problem is with some of the HAL patches, which are just touching some lines on which the checkpatch returns a warning. Many of them aren't related to those patches, so I don't think we should fix them as part of those commits (like the one you listed below, the following patch just adds ena_dev as an extra input argument). Please let me know what you think about that. Thanks, Michal > > You can see checkpatch warnings from patchwork: > https://patches.dpdk.org/project/dpdk/list/?series=3D16861 > The ones with yellow marker in the warning column. > > Additionally I am getting following checkpatch warning, that is not seen = in CI: > ### net/ena/base: add dev arg to the logging macros > > > > WARNING:UNNECESSARY_MODIFIER: Integer promotion: Using 'h' in '%hu' is > unnecessary > #331: FILE: drivers/net/ena/base/ena_com.c:861: > > + ena_trc_err(ena_dev, "Reading reg failed for timeout. exp= ected: > req id[%hu] offset[%hu] actual: req id[%hu] offset[%hu]\n", > mmio_read->seq_num, > > offset, > > read_resp->req_id, > > @@ -854,7 +868,7 @@ static u32 ena_com_reg_bar_read32(struct ena_com_dev > *ena_dev, u16 offset) > > > > [1] > ./devtools/check-git-log.sh -22