From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 841F5A0562; Tue, 31 Mar 2020 11:47:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A4F11C025; Tue, 31 Mar 2020 11:47:18 +0200 (CEST) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by dpdk.org (Postfix) with ESMTP id 6C4191BFC1 for ; Tue, 31 Mar 2020 11:47:16 +0200 (CEST) Received: by mail-ed1-f68.google.com with SMTP id a20so24375771edj.2 for ; Tue, 31 Mar 2020 02:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4aq23Y/uOtestjn6yy6DBRs9yjFD9lwyc2VxpirDdxI=; b=pCW4VrN7v1y+5VxYCPgHag7utPzr6ibKF1Gw+BpWLEREtLy0rY1MkjjCdEGH+Gj3n8 3Q+BS+o82mdW3krU3SDgrW8RP0tVJEDisEpvMDXwa9hqcOnJxRosDUN3D7tpAnNYAO+h HH16o5tUoYHg9k/CXsFXF8AQKC7F8mAai3skB8AAmUFXeD1Rd8Y+KIADSYqsnrvc6f4P Awul6d7SHovinbS++VWxwdDBYrP+RJBV5PhrVnTiM2NUIz3twG6mIAlgW5AftPNbSvg8 e31FiB9uLRcMVJrcr/KmzN5sF+dBlAIvPo/61lyOI1COe/GEPZ5sn5QUP7Z70/iv3IsU VduA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4aq23Y/uOtestjn6yy6DBRs9yjFD9lwyc2VxpirDdxI=; b=AM7DBbP7tehHLvEacVgD8q4P2huyB3f1miGHbDC9RODAq1yMKfW9SEhabIjeLjoqpM iolJgcbj3Ts46fjp5ltbu43A6/OqwC/KF3T/eojXHS2xGOaVu676JO1EQCxnDBmHlskz 06VRFFasvJ0xwbcy+MF9Kufk0PIsgW/0f3tGC0dOQCTMutAoUA+bRlwytkH9N8wGxMt5 4jg/3uolAouygPkK484P8mGcg692javfA7tJf9CG6iBLg75P3Hx8ECaQoAVY+wW6y4ay Ncey/KZfkh18g/kIv0Xy58oPKoVKUqAFxsKTvjPElmlMFllA6NSM5rEKqNDytnLclFlJ A05A== X-Gm-Message-State: ANhLgQ0RSIx8PbhP1OYxoeDKCunkjSzkDHBKJN7SwgL/dSfs3Ft0q3Sn 274O0YRTEDnp3ysREEPRMYeTHMg3CWQcY1HEQYkcdg== X-Google-Smtp-Source: ADFU+vsk90bGrTvOYnitXpURcUKbG/f4QYbYp+Ly0gOQZaKEEUvXTddgLQEXRoQMOseLckGckp9hI2HmV24mZ7p0h50= X-Received: by 2002:a17:906:1584:: with SMTP id k4mr15102491ejd.355.1585648036125; Tue, 31 Mar 2020 02:47:16 -0700 (PDT) MIME-Version: 1.0 References: <20200327101823.12646-1-mk@semihalf.com> <20200327101823.12646-3-mk@semihalf.com> <20200327075448.417ef984@hermes.lan> In-Reply-To: <20200327075448.417ef984@hermes.lan> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Tue, 31 Mar 2020 11:47:04 +0200 Message-ID: To: Stephen Hemminger Cc: dev@dpdk.org, Marcin Wojtas , Maciej Bielski , "Tzalik, Guy" , "Schmeilin, Evgeny" , "Chauskin, Igor" , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 02/29] net/ena/base: make allocation macros thread-safe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pt., 27 mar 2020 o 15:54 Stephen Hemminger napisa=C5=82(a): > > On Fri, 27 Mar 2020 11:17:56 +0100 > Michal Krawczyk wrote: > > > From: Igor Chauskin > > > > Memory allocation region id could possibly be non-unique > > due to non-atomic increment, causing allocation failure. > > > > Fixes: 9ba7981ec992 ("ena: add communication layer for DPDK") > > Cc: stable@dpdk.org > > > > Signed-off-by: Igor Chauskin > > Reviewed-by: Michal Krawczyk > > Reviewed-by: Guy Tzalik > > With DPDK all control operations are the device are supposed > to be single threaded by the caller. Do you have an allocation in > some datapath? Currently, there aren't any allocations on the datapath. But if you don't mind, we would like to keep the atomics there for future robustness.