From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13201A0C46; Fri, 23 Jul 2021 11:39:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94AAD40040; Fri, 23 Jul 2021 11:39:44 +0200 (CEST) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mails.dpdk.org (Postfix) with ESMTP id C1D124003C for ; Fri, 23 Jul 2021 11:39:43 +0200 (CEST) Received: by mail-io1-f53.google.com with SMTP id f11so1805498ioj.3 for ; Fri, 23 Jul 2021 02:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=98CEKzUUMWmSDh13QdfYkffP1IpcFOcNguvVW9J0cQ4=; b=P3VMHjXVZ97rXOYnbwNf0DYCr4dQq1IwT8VbBNeT7CWGdo9sOTv7Wqq0t/LTM54XAm qDVlja2ilRz4zxpYxZmohqeI1dSN+iFYg215gSgKNNLxveb+2o9x9zH9JW66T6HPsOvy Hi/2w99QkL6K2GER1usmwGgcF8GMBWZ9VNPaVc3EiOIpm8NqsqI0htIVWwbHg0O5E2H0 YeMxenEPBW+Cnc3bR3l3UR5K8xG/2op22u7yl72eFxJySF9YiwRBcIhtw8IFz60rUeP2 ty7jFY9Qw4JxHvQadlR+hZAa6WmA+J63cohPOzc4fmnryvNMreAu5hqhV65fszNTswpf AjaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=98CEKzUUMWmSDh13QdfYkffP1IpcFOcNguvVW9J0cQ4=; b=kz1qa1WU0Xinf//zcyC3XiIG+2gaCtjvV1VcdiihcIcgicFGeS5u2wuHkSGwqV2HBD 9LuHuHn5BLwxeq4VFxGNEUfGRBeS2lrj2aA5qc8r2KsSIiOCxlyqnG6+cMwcRc5+KmU1 Tvq3ORcvue4YV/5C6J5aop7KW9b1jI4WaV+5DMPVDc5y0uUSucx3fJSDPD2EC2vNGgp5 LIdeJXNvAmDUvIR1vTJBuSOKdMcs662C9KdCDVSb73hPE7de7ITIw3Nf8cRN+U2KMKVw /hyAN8eP+h4DnRfsmprgeBtKXKEdb3vZLH0rLZeqWwRvC7G5KlSuFf3ychxVPu1U81g/ ROkQ== X-Gm-Message-State: AOAM532GrvXymVAvi6O4yJyaeQMHsUxi16zKSMPinlrzCzQVlb4OQLvM Np7Q+K/R7Jq5LT4YnqcZEQCSDT1cAvqSeqPvGyVzzg== X-Google-Smtp-Source: ABdhPJwY9gMigiRPJjoMSvh+Q0zyD3kmSOOrU319z/LbDNJbm00xygQEAH56FnKGJQNBUh8FvVmSceSs6lZXzKIvIpk= X-Received: by 2002:a5d:8996:: with SMTP id m22mr3250267iol.6.1627033183121; Fri, 23 Jul 2021 02:39:43 -0700 (PDT) MIME-Version: 1.0 References: <20210714103435.3388-1-mk@semihalf.com> <20210714104320.4096-1-mk@semihalf.com> <20210714104320.4096-6-mk@semihalf.com> <1691540.9AlFL3h5L8@thomas> In-Reply-To: <1691540.9AlFL3h5L8@thomas> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Fri, 23 Jul 2021 11:39:32 +0200 Message-ID: To: Thomas Monjalon Cc: dev , "Dagan, Noam" , "Brandes, Shai" , upstream@semihalf.com, Shay Agroskin , Amit Bernstein , Ferruh Yigit , David Marchand Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pt., 23 lip 2021 o 11:22 Thomas Monjalon napisa=C5=82= (a): > > 14/07/2021 12:43, Michal Krawczyk: > > + PMD_DRV_LOG(WARNING, > > + "Setting RSS hash fields is not supported. Usin= g default values: 0x%llx\n", > > + ENA_ALL_RSS_HF); > > > > checkpatch is returning this warning: > Using %l format, prefer %PRI*64 if type is [u]int64_t > > Indeed rss_hf is uint64_t. > > Hi Thomas, I'm aware of that checkpatch warning, but changing format to %PRIx64 results in another (compilation) warning: [1205/2572] Compiling C object drivers/libtmp_rte_net_ena.a.p/net_ena_ena_rss.c.o In file included from ../drivers/net/ena/ena_rss.c:7: ../drivers/net/ena/ena_rss.c: In function =E2=80=98ena_rss_hash_set=E2=80= =99: ../drivers/net/ena/ena_logs.h:35:3: warning: format =E2=80=98%lx=E2=80=99 e= xpects argument of type =E2=80=98long unsigned int=E2=80=99, but argument 5 has ty= pe =E2=80=98long long unsigned int=E2=80=99 [-Wformat=3D] 35 | "%s(): " fmt, __func__, ## args) | ^~~~~~~~ ../drivers/net/ena/ena_rss.c:427:3: note: in expansion of macro =E2=80=98PM= D_DRV_LOG=E2=80=99 427 | PMD_DRV_LOG(WARNING, | ^~~~~~~~~~~ In file included from ../lib/mempool/rte_mempool.h:40, from ../lib/mbuf/rte_mbuf.h:38, from ../lib/net/rte_ether.h:23, from ../drivers/net/ena/ena_ethdev.h:10, from ../drivers/net/ena/ena_rss.c:6: /usr/include/inttypes.h:121:34: note: format string is defined here 121 | # define PRIx64 __PRI64_PREFIX "x"