From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51A9AA0C45; Fri, 30 Jul 2021 11:38:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12F854067A; Fri, 30 Jul 2021 11:38:10 +0200 (CEST) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id 0D3B74014D for ; Fri, 30 Jul 2021 11:38:09 +0200 (CEST) Received: by mail-io1-f54.google.com with SMTP id r18so10713445iot.4 for ; Fri, 30 Jul 2021 02:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=E2waDA9+1v+2vL0tlVR5prMx7K8fT5wZpiT5q19Gl58=; b=XW2CEx7PnQXvKEKbie1bQcMTuiovUHyA8ckT9qQi2BPr1BzHdsF6vIgGs5bFHVWKUR z3xtoem/BynpJlx25PNruHk13A3em5QvLoo8I+VdtLpIg+y+iGkXUsufDd8UFecXRSFZ UavoZ3oJCJ3+/iDelDorhiitb9b0Xsse8A3JXdfuqDGT2Juxfoumjp2V+2yGkO19oZrj TYK6nzkqbyK7kT+ogkuVImsQ+wIwBkAoIxfbuQJY501/t7q/G4+FPRpk7U2ejIybudrV RoUBLr82VNpFO4lAbHrmEsrvjTvAkIRzvfEJ1uyRUha0J1mGdNYgPqw2b2Z4y+v0CLLM yCJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=E2waDA9+1v+2vL0tlVR5prMx7K8fT5wZpiT5q19Gl58=; b=DUHLcoqqjZ/xr5gaEjVpPGiYAkdeZX5XD8aIHXRsjVPb2nTNl8SUjEOzgs1iQxE5HR FwvR6bQhSBw9YmscJTOAvf03Mg9DoClIN0B6FdgIsiqQ1pwoONrd3cQXxx5Rr1SvKB/D Fb2Q0rKodIzoWx/+iM2ojyxI3oCRdpCRARWfNWjMbp/c9LTzOHzqxAD6yT9kLQvECcOL epM9qEZWlxvhPheZGJ5h0Mgf/U4v17lnFHR5NR89+qwf2b1Y4z3+FOvUow/UrShCSF4C I8wPysVuJz7xZiMquKUQo7AX0bUN9GgAOQI6LKmJTsj16lH2s1D/GrvT0OeLlT1Cpgsz UvlA== X-Gm-Message-State: AOAM532Aukoyeo7NZD8FBi+rCfrraFdaReiDHnevG3aww0J+1RK9junf NIqazXYFAZln4bj8+O6k4LTg5ZY511MxuGRftMYp2Q== X-Google-Smtp-Source: ABdhPJx7mqkYOkaSCQPbDh5vVl6XdNH0YQdZHFK+qnjbmbO0g+xHSeb5xRigH3fk4JeJx3p0ajuLHwnwW14xfLS4BYM= X-Received: by 2002:a05:6602:d9:: with SMTP id z25mr379205ioe.154.1627637888463; Fri, 30 Jul 2021 02:38:08 -0700 (PDT) MIME-Version: 1.0 References: <20210712170153.11508-1-ghalem.boudour@6wind.com> <20210730083441.7465-1-olivier.matz@6wind.com> In-Reply-To: <20210730083441.7465-1-olivier.matz@6wind.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Fri, 30 Jul 2021 11:37:55 +0200 Message-ID: To: Olivier Matz Cc: dev , Ghalem Boudour , "Schmeilin, Evgeny" , "Chauskin, Igor" , Marcin Wojtas , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] net/ena: enable multi segment in Tx offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pt., 30 lip 2021 o 10:35 Olivier Matz napisa=C5=82= (a): > > From: Ghalem Boudour > > The DPDK ENA driver does not provide multi-segment tx offload capability. > Let's add DEV_TX_OFFLOAD_MULTI_SEGS to ports offload capability by > default, and always set it in dev->data->dev_conf.txmode.offload. > > This flag in not listed in doc/guides/nics/features/default.ini, so > ena.ini does not need to be updated. > > Fixes: 1173fca25af9 ("ena: add polling-mode driver") > Cc: stable@dpdk.org > > Signed-off-by: Ghalem Boudour > Signed-off-by: Olivier Matz Acked-by: Michal Krawczyk > --- > > v2 > * set DEV_TX_OFFLOAD_MULTI_SEGS in dev->data->dev_conf.txmode.offload > * add Fixes and Cc stable > > drivers/net/ena/ena_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index dfe68279fa..b59451034c 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1981,6 +1981,7 @@ static int ena_dev_configure(struct rte_eth_dev *de= v) > > if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) > dev->data->dev_conf.rxmode.offloads |=3D DEV_RX_OFFLOAD_R= SS_HASH; > + dev->data->dev_conf.txmode.offloads |=3D DEV_TX_OFFLOAD_MULTI_SEG= S; > > adapter->tx_selected_offloads =3D dev->data->dev_conf.txmode.offl= oads; > adapter->rx_selected_offloads =3D dev->data->dev_conf.rxmode.offl= oads; > @@ -2055,6 +2056,7 @@ static int ena_infos_get(struct rte_eth_dev *dev, > DEV_RX_OFFLOAD_TCP_CKSUM; > > rx_feat |=3D DEV_RX_OFFLOAD_JUMBO_FRAME; > + tx_feat |=3D DEV_TX_OFFLOAD_MULTI_SEGS; > > /* Inform framework about available features */ > dev_info->rx_offload_capa =3D rx_feat; > -- > 2.29.2 >