From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f65.google.com (mail-vk0-f65.google.com [209.85.213.65]) by dpdk.org (Postfix) with ESMTP id 3C5A41B471 for ; Tue, 26 Jun 2018 13:15:34 +0200 (CEST) Received: by mail-vk0-f65.google.com with SMTP id q135-v6so9785536vkh.1 for ; Tue, 26 Jun 2018 04:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GfPst5G3xJo4rAao5BeqBgErvCD+hHGaPYGFE2JsZGo=; b=RDC21VmvJgULRxDpeEc6VwPhlestA62W5iClnhaLPN53LHFp2XZ/DK4OIXbE8NRw5N DmMw5cI2YhoKZLNkQ3LjTf7MUYLAvtOZVZvFY+Mgat5FqiqqefuaA2qtepCpGHmXZFzl dXxfpmQ/XcmMZEy0AYFHubvtCOCeKRu2T47JzF3D/YjMMuXjtCk2oC06Nl2ReocdBgS9 YmDK8h1/SibwzZmJ6dNZdoZW617zkX323Zh0eWnwvU/w+1dNOOUq9Mw/PVEYOrpvmvrN LUz4TpDE9f7aBxy2IwPiXTAUajL1RyFguD99BY+miSfWR7y6qkjNrTReLHMFe/HTeZ6g u3Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GfPst5G3xJo4rAao5BeqBgErvCD+hHGaPYGFE2JsZGo=; b=OfGxzfSYeO3Z/av7ziHs2neN7PnOX5nbBdBl2GSCYWsUvjeHj9ciYfye0MMRYvtp5L IKcmp0dn0SsqTsq52tD0Fd1Q6/PLm1v1fEc73VuMJIX+JjzHgdxQF9MaNSiERPQr8wCw iV878ZEQNZd5yyjQTZblw4CuwDJoQXAcI0fBbZjwtFR3+a4TlSQO/TLHCPNWyHWnbkzc T0ADj8Wfvjjh1917hthL7svvXNgtSugDx8+jdw9VhyWcTmsmq3DYJdFz/OOYafHs4Z/m XHX/Qx2WjEgShbfCdPzT+3YT6HWHD2sb/BLfNF279TALP31zWCcJfWSNeyL70XcchgRU E4LA== X-Gm-Message-State: APt69E2inEu7mYWO8n8txfHxCLHu+eEvIdh6o4ZfFCu4d5J2b1St63vo Fv85chi/6qJtjTGYn2n0eGPckFhuJiKnn3X4BmIc2A== X-Google-Smtp-Source: AAOMgpceu4eZrjmsojRjKTh81bsJQpsodujVJGKEEHF704sDyeZzI0MB9Ui9x92Qa/Pve5BpDW+2oJeKUcA2ZIUH578= X-Received: by 2002:a1f:b393:: with SMTP id c141-v6mr611076vkf.37.1530011733619; Tue, 26 Jun 2018 04:15:33 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:62c7:0:0:0:0:0 with HTTP; Tue, 26 Jun 2018 04:15:33 -0700 (PDT) In-Reply-To: <20180626110734.25181-1-daria.kolistratova@intel.com> References: <20180626110734.25181-1-daria.kolistratova@intel.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Tue, 26 Jun 2018 13:15:33 +0200 Message-ID: To: Daria Kolistratova Cc: Ferruh Yigit , Marcin Wojtas , "Tzalik, Guy" , "Schmeilin, Evgeny" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/1] ena: fix SIGFPE with 0 rx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 11:15:34 -0000 2018-06-26 13:07 GMT+02:00 Daria Kolistratova : > When the number of rx queues is 0 > (what can be when application does not receive) > failed with SIGFPE. It happens when the application > is also requesting ETH_MQ_RX_RSS_FLAG in the > rte_dev->data->dev_conf.rxmode.mq_mode. > Fixed adding zero rx queues check. > > Signed-off-by: Daria Kolistratova Acked-by: Michal Krawczyk > --- > drivers/net/ena/ena_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 9ae73e331..3249b9d92 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1052,7 +1052,7 @@ static int ena_start(struct rte_eth_dev *dev) > return rc; > > if (adapter->rte_dev->data->dev_conf.rxmode.mq_mode & > - ETH_MQ_RX_RSS_FLAG) { > + ETH_MQ_RX_RSS_FLAG && adapter->rte_dev->data->nb_rx_queues > 0) { > rc = ena_rss_init_default(adapter); > if (rc) > return rc; > -- > 2.14.4 >