From: "Michał Krawczyk" <mk@semihalf.com>
To: David Harton <dharton@cisco.com>
Cc: Marcin Wojtas <mw@semihalf.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Chauskin, Igor" <igorch@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
sameehj@amazon.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/ena: Fix admin cq polling for 32-bit apps
Date: Wed, 17 Jul 2019 16:29:43 +0200 [thread overview]
Message-ID: <CAJMMOfP9KdNmWMJJ-QAC3YgVVRDAbKzKxzftTSz_Y5jfSMC9VQ@mail.gmail.com> (raw)
In-Reply-To: <20190712173543.28306-1-dharton@cisco.com>
pt., 12 lip 2019 o 19:35 David Harton <dharton@cisco.com> napisał(a):
>
> Recent modifications to admin command queue polling logic
> did not support 32-bit applications. Updated the driver to
> work for 32 or 64 bit applications
>
> Fixes: 3adcba9a89 ("net/ena: update HAL to the newer version")
>
> Signed-off-by: David Harton <dharton@cisco.com>
Acked-by: Michal Krawczyk <mk@semihalf.com>
> ---
> v2: Leave existing timeout method and only arch size issue.
> v1: Fix arch size issue and count iterations to limit polling.
>
> drivers/net/ena/base/ena_com.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c
> index b688067f7..e9b9be28d 100644
> --- a/drivers/net/ena/base/ena_com.c
> +++ b/drivers/net/ena/base/ena_com.c
> @@ -547,7 +547,7 @@ static int ena_com_wait_and_process_admin_cq_polling(struct ena_comp_ctx *comp_c
> struct ena_com_admin_queue *admin_queue)
> {
> unsigned long flags = 0;
> - unsigned long timeout;
> + uint64_t timeout;
> int ret;
>
> timeout = ENA_GET_SYSTEM_TIMEOUT(admin_queue->completion_timeout);
> --
> 2.19.1
>
next prev parent reply other threads:[~2019-07-17 14:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 21:01 [dpdk-dev] [PATCH] " David Harton
2019-06-27 15:37 ` Ferruh Yigit
2019-06-28 15:03 ` Michał Krawczyk
2019-06-28 15:46 ` David Harton (dharton)
2019-07-01 7:24 ` Michał Krawczyk
2019-07-01 12:00 ` David Harton (dharton)
2019-07-01 12:52 ` Michał Krawczyk
2019-07-12 17:35 ` [dpdk-dev] [PATCH v2] " David Harton
2019-07-17 14:29 ` Michał Krawczyk [this message]
2019-07-17 15:15 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJMMOfP9KdNmWMJJ-QAC3YgVVRDAbKzKxzftTSz_Y5jfSMC9VQ@mail.gmail.com \
--to=mk@semihalf.com \
--cc=akiyano@amazon.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=matua@amazon.com \
--cc=mw@semihalf.com \
--cc=netanel@amazon.com \
--cc=sameehj@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).