From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f67.google.com (mail-vk0-f67.google.com [209.85.213.67]) by dpdk.org (Postfix) with ESMTP id C89B32C38 for ; Mon, 25 Jun 2018 13:09:41 +0200 (CEST) Received: by mail-vk0-f67.google.com with SMTP id x4-v6so7562920vkx.11 for ; Mon, 25 Jun 2018 04:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=iLfsXiT1Rtp1Pu9uB8OJyTeGbukgCDmBBGPJSx0J/lg=; b=tqAoO8aKCW6tH2mVSTmAgZTeMnoxdxmHwgIGc6j6wsbU4xbHEFelPsMjN0oPAfmPKQ VwyDz7RkGDwTfmDyU8MpE8Bk1iQiTDGX4UAiV3J1uWQLLaj2ZdHpAf7IVgAN4197lLhm GerrE/EURwobiL8Bh9BIL0ebFXmeiA02k9MsMQb7wrpvCOye6SZ1B0nkYjckax0DZEws 6jpRW3CVnkqOcCCIx6103rQRAQ+a1CW9Aa8lIQ0nIU1hyzJx2WrVjbbNNXoVYdvstMMG CW9JxifD96ExP1S8mDBphYqzXvBEKRLbFuoOxwi4YTa1URLo2B8rWZaLL++j0/Bik3mC xukQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iLfsXiT1Rtp1Pu9uB8OJyTeGbukgCDmBBGPJSx0J/lg=; b=j7AXZMungkKaK8KebR7hKkbUrROLruUeaYCr5/UpBHChN3GySgrFmlFih2mxSjyC0P nmZZblJRH3PHn5L84yOOir304u+TxTJL3u/r2IXsmQB48MGTZYK6JgBqwn2KAsFO1bLp QwDlMbJ+q9DFyaQeGpin50BCMHXVbzy6bVRxc8NupkmvVD8LucF3ADidq7R0bulOF0xR 8Sx+FHCsMD8zDMYU2dva98TG5Qc63XZkdtZrNDut7KMicvudgNSX9hqaPykP35sDocGD 0AfHFIxv+H7ZoIZaMNTxzzafXJRv8IS5kQ/lQs1db6WFoLjgdYdv6Q+w61Ldea1cPPxO L2ww== X-Gm-Message-State: APt69E1o5Gi6Yv07ZyxLouFtpb+4Qm0gnGS7d7MykD6Gd9PKkj5K6sND hQEOXaN1Jd3zxW2UVVIktHmvOAwjHnJUo9oLqqch5g== X-Google-Smtp-Source: AAOMgpfavRB/b+UlrOFX0p9p1ZgkUOaqbno+qf3RuW5wBk4uYpMQUsedUc6FLIvZsbdIjLe1xTyNpnbiWokATjv11pI= X-Received: by 2002:a1f:ee49:: with SMTP id m70-v6mr2884147vkh.180.1529924981082; Mon, 25 Jun 2018 04:09:41 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:62c7:0:0:0:0:0 with HTTP; Mon, 25 Jun 2018 04:09:40 -0700 (PDT) In-Reply-To: <574333F3A897D24883A0208564DF74C8377F5A50@IRSMSX103.ger.corp.intel.com> References: <20180621153433.86009-1-daria.kolistratova@intel.com> <574333F3A897D24883A0208564DF74C8377F5A50@IRSMSX103.ger.corp.intel.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Mon, 25 Jun 2018 13:09:40 +0200 Message-ID: To: "Kolistratova, Daria" Cc: "Yigit, Ferruh" , Marcin Wojtas , "Tzalik, Guy" , "Schmeilin, Evgeny" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/1] ena: fix SIGFPE with 0 rx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 11:09:42 -0000 Daria, Yes, please. I will ack the patch once it will be resent. Thanks, Michal 2018-06-25 13:05 GMT+02:00 Kolistratova, Daria : > Hi Michal, > > Yes, it won't fix the issue, but will return error instead of fail. I tri= ed to execute with changes from the earlier email thread and it works. Shou= ld I resend patch with these changes? > > Best regards, > Kolistratova Daria > > > -----Original Message----- > From: Micha=C5=82 Krawczyk [mailto:mk@semihalf.com] > Sent: Monday, June 25, 2018 11:02 AM > To: Kolistratova, Daria > Cc: Yigit, Ferruh ; Marcin Wojtas ; Tzalik, Guy ; Schmeilin, Evgeny ; dev@dpdk.org > Subject: Re: [PATCH 1/1] ena: fix SIGFPE with 0 rx queues > > Hi Daria, > > From what you reported on bugzilla, it looks like this patch won't fix th= e issue. Have you tried to execute the application with the changes I sugge= sted in the earlier email thread? > > Thanks, > Michal > > > czw., 21.06.2018, 17:34 u=C5=BCytkownik Daria Kolistratova napisa=C5=82: >> >> When he number of rx queues is 0 >> (what can be when application does not receive) failed with SIGFPE. >> Fixed adding zero check before division. >> >> Signed-off-by: Daria Kolistratova >> --- >> drivers/net/ena/ena_ethdev.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ena/ena_ethdev.c >> b/drivers/net/ena/ena_ethdev.c index 9ae73e331..76c483921 100644 >> --- a/drivers/net/ena/ena_ethdev.c >> +++ b/drivers/net/ena/ena_ethdev.c >> @@ -684,7 +684,11 @@ static int ena_rss_init_default(struct ena_adapter = *adapter) >> } >> >> for (i =3D 0; i < ENA_RX_RSS_TABLE_SIZE; i++) { >> - val =3D i % nb_rx_queues; >> + if (nb_rx_queues !=3D 0) >> + val =3D i % nb_rx_queues; >> + else >> + val =3D 0; >> + >> rc =3D ena_com_indirect_table_fill_entry(ena_dev, i, >> ENA_IO_RXQ_IDX(va= l)); >> if (unlikely(rc && (rc !=3D ENA_COM_UNSUPPORTED))) { >> -- >> 2.14.4 >> > > -------------------------------------------------------------------- > Joint Stock Company Intel A/O > Registered legal address: Krylatsky Hills Business Park, > 17 Krylatskaya Str., Bldg 4, Moscow 121614, > Russian Federation > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies.