From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB357A0524; Wed, 5 May 2021 14:21:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A015740143; Wed, 5 May 2021 14:21:18 +0200 (CEST) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by mails.dpdk.org (Postfix) with ESMTP id 6346A40040 for ; Wed, 5 May 2021 14:21:17 +0200 (CEST) Received: by mail-io1-f42.google.com with SMTP id v123so1424459ioe.10 for ; Wed, 05 May 2021 05:21:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LW9Xxlyl4cr6BKGEQO1cY//Jh0gF37rXzojuHJ8OWsY=; b=pvHA/Mqm995ysf1wEGt0JL+jHIWTjwG075BsQqVpAwPgCd1PzCQ/nsDPaM6oOPn25L AMVtJy0wCafgTJis1/jbibSRoxTPpwvxBkVSOhdy/Qke1DumDJtk09fwoKNZ+3Z6ueAp xs0R1NE4R7rpM1wZ+VkB7slhFrhNUz2AkN+kQCGoPoUpnVvWl45Pxk3JC4f3gyEXIoey LfDHhQLAtMMlDYTcxR6bkKnulmzdqb60zRnAhboLi8uirsI2dBcybMu62TPo1/4pLFJH 7XrF8Hx6jkKWLBR3M+Gwbcio5+F7JWEj4vx6dsb+UUjVeJ7aJ9FW9dsmREl4bvm8mlxM zehg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LW9Xxlyl4cr6BKGEQO1cY//Jh0gF37rXzojuHJ8OWsY=; b=YK6pZBBurlfnxKMNiSo0Bd2wvUOZeL1QEh3Tm/6VCOeUPUOat5uLtuqE96K7SfjiKl MUPff8ZbAyOu0ohZWtZuSpLbA5DnGWFhiArFHSKR2VcpeykE4seA7B/kj9b8DMvw2po9 hOqT9l2MBkbMqEOUB1g2nfYRyIm8AzW+p6D5grT0evOhIX4cZkRp7hQzPF3Rwd9oCxko BKDiiB6dXJ77LnoVcyBYZxWWx8W8B/nfC5hcXTwQXAPJh11tyM50q6Qs8k4L11GN8AGV ZO+UvBP+YkMCqG3kBTn8VXU65gDU56B6X+NKRelVCNKZjYYcCscI37IfhdnqQuRKH/ZU vx2A== X-Gm-Message-State: AOAM5307W3kDo0biRbIMrGZdfAImCjQaZwZDxQmvD5Jlcwtwbwfrb76l jyAqtNQwbuYxXjId32Ev8NkbkpsAXR8aqxD9i/z0nw== X-Google-Smtp-Source: ABdhPJxrPK2SXxSY1xMBUQb+hh9ne4kKc+/rRX6ZrNkKMzOqBLq52ANbJMeAIlvqTdN6kGtTfn5hC5HQN0pctm4euc0= X-Received: by 2002:a5d:88c2:: with SMTP id i2mr8395611iol.18.1620217276750; Wed, 05 May 2021 05:21:16 -0700 (PDT) MIME-Version: 1.0 References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210331095254.2454439-1-qi.z.zhang@intel.com> <20210331095254.2454439-2-qi.z.zhang@intel.com> <27cbb27b-42c9-9a6d-c990-c2174ec59e83@intel.com> <155bda61-4a17-1618-003f-1b155304e448@intel.com> In-Reply-To: <155bda61-4a17-1618-003f-1b155304e448@intel.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Wed, 5 May 2021 14:21:05 +0200 Message-ID: To: Ferruh Yigit Cc: Shahed Shaikh , Rasesh Mody , Devendra Singh Rawat , Igor Russkikh , Maxime Coquelin , Chenbo Xia , Stephen Hemminger , Long Li , Steven Webster , Matt Peters , Jerin Jacob , Maciej Czekaj , Yong Wang , Heinrich Kuhn , Shijith Thotton , Srisivasubramanian Srinivasan , Jiawen Wu , Jian Wang , Marcin Wojtas , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , dev , Thomas Monjalon , bruce.richardson@intel.com, Qi Zhang , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 1/8] ether: refine debug build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" =C5=9Br., 5 maj 2021 o 13:45 Ferruh Yigit napisa= =C5=82(a): > > On 4/1/2021 3:30 PM, Ferruh Yigit wrote: > > On 3/31/2021 10:52 AM, Qi Zhang wrote: > >> PMDs use RTE_LIBRTE__DEBUG_RX|TX as build option to wrap > >> data path debug code. As .config has been removed since the meson buil= d, > >> It is not friendly for new DPDK users to notice those debug options. > >> > >> The patch introduces below build options for data path debug, so PMD > >> can choose to reuse them to avoid maintain their own. > >> > >> - RTE_ETHDEV_DEBUG_RX > >> - RTE_ETHDEV_DEBUG_TX > >> > >> All the build options are documented at programming guide > >> "3.1 Driver Option", so users can easily find them. > >> > >> The original undocumented RTE_LIBRTE_ETHDEV_DEBUG will alias to > >> both RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX for backward > >> compatibility. > >> > >> Signed-off-by: Qi Zhang > >> --- > >> doc/guides/nics/build_and_test.rst | 16 ++++++++++++++++ > >> lib/librte_ethdev/rte_ethdev.h | 22 ++++++++++++++-------- > >> 2 files changed, 30 insertions(+), 8 deletions(-) > >> > >> diff --git a/doc/guides/nics/build_and_test.rst > >> b/doc/guides/nics/build_and_test.rst > >> index e83dd4628c..e8b29c2277 100644 > >> --- a/doc/guides/nics/build_and_test.rst > >> +++ b/doc/guides/nics/build_and_test.rst > >> @@ -26,6 +26,22 @@ This will also build testpmd. > >> Detailed instructions are available > >> in the :doc:`meson build guide <../prog_guide/build-sdk-meson>`. > >> +The ethdev layer supports below build options for debug purpose: > >> + > >> +- ``RTE_ETHDEV_DEBUG_RX`` (default **disabled**) > >> + > >> + Build with debug code on Rx path. > >> + > >> +- ``RTE_ETHDEV_DEBUG_TX`` (default **disabled**) > >> + > >> + Build with debug code on Tx path. > >> + > >> +.. Note:: > >> + > >> + The ethdev library use above options to wrap debug code to trace i= nvalid > >> parameters > >> + on data path APIs, so performance downgrade is expected when enabl= ing > >> those options. > >> + Each PMD can decide to reuse them to wrap their own debug code in = the > >> Rx/Tx path. > >> + > > > > Following drivers are other users of the PMD specific compile flag for = the Rx/Tx > > datapath debug logs [1], maintainers of those PMDs cc'ed, can you pleas= e plan > > switching to the RTE_ETHDEV_DEBUG_RX / RTE_ETHDEV_DEBUG_TX macros? > > > > [1]: > > - bnx2x: RTE_LIBRTE_BNX2X_DEBUG_RX / RTE_LIBRTE_BNX2X_DEBUG_TX > > - qede: RTE_LIBRTE_QEDE_DEBUG_RX / RTE_LIBRTE_QEDE_DEBUG_TX > > - virtio: RTE_LIBRTE_VIRTIO_DEBUG_RX / RTE_LIBRTE_VIRTIO_DEBUG_TX > > - netvsc: RTE_LIBRTE_NETVSC_DEBUG_RX / RTE_LIBRTE_NETVSC_DEBUG_TX > > - avp: RTE_LIBRTE_AVP_DEBUG_RX / RTE_LIBRTE_AVP_DEBUG_TX > > - thunderx: RTE_LIBRTE_THUNDERX_NICVF_DEBUG_RX / > > RTE_LIBRTE_THUNDERX_NICVF_DEBUG_TX > > - vmxnet3: RTE_LIBRTE_VMXNET3_DEBUG_RX / RTE_LIBRTE_VMXNET3_DEBUG_TX > > - nfp: RTE_LIBRTE_NFP_NET_DEBUG_RX / RTE_LIBRTE_NFP_NET_DEBUG_TX > > - liquidio: RTE_LIBRTE_LIO_DEBUG_RX / RTE_LIBRTE_LIO_DEBUG_TX > > - txgbe: RTE_LIBRTE_TXGBE_DEBUG_RX / RTE_LIBRTE_TXGBE_DEBUG_TX > > - ena: RTE_LIBRTE_ENA_DEBUG_RX / RTE_LIBRTE_ENA_DEBUG_TX > > > > > Reminder of this one. > > Can it be possible to schedule this task for v20.08? Hi Ferruh, we'll schedule this task for v20.08 for the ENA PMD. Thanks, Michal