From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f194.google.com (mail-ua0-f194.google.com [209.85.217.194]) by dpdk.org (Postfix) with ESMTP id 218531B056 for ; Mon, 25 Jun 2018 10:01:46 +0200 (CEST) Received: by mail-ua0-f194.google.com with SMTP id g6-v6so548730uam.2 for ; Mon, 25 Jun 2018 01:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NqdqGby+UigZ2C/dahUbamkA0gf+yPJ6aSq6Py1G9tA=; b=Yv/BFuAxDeqG4CAE0E8DMKeU/lqolKwFM10+YiZBsn966vzkRxfdZbjv1IpHUoaNbd 8+0RHUe2uMyuOA/81YKLOZx9kk4kPh45Qd03m3MMHtLoQ1M06JhoUTZazM2Vb2ht1y4Y xvxeVv8DsR3s1HkJm4MnUxSJfrST7Be95oRcTW7KFyMZKJlLj2+xibUyEWADB+qTSmzz +VsQDIojU50lNZlElc43C6eZzZx/CIANWn+sXBLJyWiXCIacph3l3WXkkLDl7OONiM9d DVFjFlLQuq/zc83xu7S2SVy6u71BisUxWYR+QnE234PqWSzS/KdqW0hoaE9SzOmq6WIE YZ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NqdqGby+UigZ2C/dahUbamkA0gf+yPJ6aSq6Py1G9tA=; b=MpQrYcrReL9Lxe6/DfTaQuANBpPSdHU7HQ/OxIE6pnWiqlOlklfwOjy2nenwFbwlSI hWMNN0zkLUA8lssubCBn+ShgQA7hzdha2w8uV3qVG0UT/OUwlAT54ccelty1mVY6mnW+ N864cX4J21YpECdHpHdgyMkPGjRBCh3vhWer94tRK91+6A63RUuk7ZqxrEC3bFQPNZs0 S06ftkzFEFRraQ08LhALnv4g6BdmrllIWvT2Q9Jx2mMvvqR0tt53EGE6SNeRLhpEkQKB bZV+FKgFOcAWZGrAVtK49faXi7mZD9mo7uFC0QGkhQZgqkYG8/VVs3S6/6dUw/rl55C5 WNAw== X-Gm-Message-State: APt69E0PEBsFbBLe9kyz0txebiL/76TzmIPGh65OyA5T9bJBIzyxCfW5 Ee9m7k9Oewrg8PY7pnY2Ijnt/kagbhEoiGsUWPsUCQ== X-Google-Smtp-Source: AAOMgpcGZ5pxevnC5XwhGXPjggyqiK7W9wJU3EcG2TDgiqepHIgjDKayOqrNCOd/AMOgGQfUJj4RmF5uKgji9a6jcs0= X-Received: by 2002:a9f:258d:: with SMTP id 13-v6mr2896719uaf.22.1529913705451; Mon, 25 Jun 2018 01:01:45 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:62c7:0:0:0:0:0 with HTTP; Mon, 25 Jun 2018 01:01:44 -0700 (PDT) In-Reply-To: <20180621153433.86009-1-daria.kolistratova@intel.com> References: <20180621153433.86009-1-daria.kolistratova@intel.com> From: =?UTF-8?Q?Micha=C5=82_Krawczyk?= Date: Mon, 25 Jun 2018 10:01:44 +0200 Message-ID: To: Daria Kolistratova Cc: Ferruh Yigit , Marcin Wojtas , "Tzalik, Guy" , "Schmeilin, Evgeny" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/1] ena: fix SIGFPE with 0 rx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 08:01:46 -0000 Hi Daria, >>From what you reported on bugzilla, it looks like this patch won't fix the issue. Have you tried to execute the application with the changes I suggested in the earlier email thread? Thanks, Michal czw., 21.06.2018, 17:34 u=C5=BCytkownik Daria Kolistratova napisa=C5=82: > > When he number of rx queues is 0 > (what can be when application does not receive) > failed with SIGFPE. > Fixed adding zero check before division. > > Signed-off-by: Daria Kolistratova > --- > drivers/net/ena/ena_ethdev.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 9ae73e331..76c483921 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -684,7 +684,11 @@ static int ena_rss_init_default(struct ena_adapter *= adapter) > } > > for (i =3D 0; i < ENA_RX_RSS_TABLE_SIZE; i++) { > - val =3D i % nb_rx_queues; > + if (nb_rx_queues !=3D 0) > + val =3D i % nb_rx_queues; > + else > + val =3D 0; > + > rc =3D ena_com_indirect_table_fill_entry(ena_dev, i, > ENA_IO_RXQ_IDX(val= )); > if (unlikely(rc && (rc !=3D ENA_COM_UNSUPPORTED))) { > -- > 2.14.4 >