From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AD1443DF6; Thu, 4 Apr 2024 09:48:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A1C840268; Thu, 4 Apr 2024 09:48:14 +0200 (CEST) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by mails.dpdk.org (Postfix) with ESMTP id 1A30A4027B for <dev@dpdk.org>; Thu, 4 Apr 2024 00:08:54 +0200 (CEST) Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2d476d7972aso4407771fa.1 for <dev@dpdk.org>; Wed, 03 Apr 2024 15:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1712182133; x=1712786933; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eexvF+bYOuD3/uLSk0XI+F+1jB+mSuXYm+Bu4uNvJ+s=; b=FLBJhHmg2wX+WxmQRqesI5m6f28PtTPTTC6AC6rSHgbo3/GgBlHy9iVq0+IJ2FeFPy T8A1uhSCcoWqDWqJSTVB24MLFj+kEzl3TM2I3tmBLhN7VeudFHzKcCI04TEqlNkDANPU MwB03CSUjWOKayTi+jGJDnsFoJX8m0asD0AtBX5Gr0jZm2cbje9lVeRyOz5FrSVUkOGX 88diikUSfarGUaqX7e07EXM0O2ZePs72544JOr7rRt+XsnCo5T3nQ36tv5mXopxudazu MJF98YZREE2HMhfRGjePfESs/eq4uImJrKDCTZHOKkdDbzMZQn/OW4toG77f5B5ebkiA Hq2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712182133; x=1712786933; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eexvF+bYOuD3/uLSk0XI+F+1jB+mSuXYm+Bu4uNvJ+s=; b=atvJ+w84yO+E7VS+HhS194RZ86Xcnhne0LfeU5+KTu4Qe/36KbCN2rr/syDqH7io4p LENhztpDYG0y8KnKbwf2NIFl8wLZE+qMbnE9Wkl6+MaC594/pWerdbD97aRawwj7cy57 TFu0U8XOqRLbcQpJ5f+am985BPv4E+g1K0pYjjGicCTBdUQjU4Ckic7Rc0shqbItMfZd gptmJs9je3+c5cPnts8ru1l2TE0M551kcF7f+2X/23mZioIgR7W+UOCkKvOc2vb54teH lrbD6iLP3oiBVC0CRuHFTAz30+dOCN8CrgH36Ub6GgPAnwXtx16AYoCaIpuNxwHtd8EP i2Dg== X-Forwarded-Encrypted: i=1; AJvYcCUKapZXwsoKJ065wu05KVrRlahQLMA6/MUx3Nh/RjyMjFBBLxACmBWofFlq3KQog2XwQHOwJ3b3kmgFTH0= X-Gm-Message-State: AOJu0Ywq/yftkFJLtYUVyHoDvsk7VsJn0BkIfgrzv1djImf2ihl15yCn u6wEGaAeAmhnsS41QTMuLL1nSBwRQeaUk/P+cHZMuJ4Vxx3trrlpELSKMmhEBVwI7i6PTz9UppM VERjgOJki2baO0k0MuQtX21/4ZyEZj8vlQd3c X-Google-Smtp-Source: AGHT+IGoER2CL11j2znGNk+4H6fDaQc6NJlad3EOQisdzYll98uuThyii68Kro5adRS69GC/m9yyXVvyP884qzg2DIw= X-Received: by 2002:a2e:2c19:0:b0:2d2:206a:2f2a with SMTP id s25-20020a2e2c19000000b002d2206a2f2amr662370ljs.17.1712182133339; Wed, 03 Apr 2024 15:08:53 -0700 (PDT) MIME-Version: 1.0 References: <20240326235909.25276-1-mpazdan@arista.com> <20240403135953.7209-1-mpazdan@arista.com> <1924573.MyG8hOvIyE@thomas> <CAJUFdiGAnnmtXc1GhUe=CAQya5BYFhcLFiUx1WVs86-msdKvgw@mail.gmail.com> <20240403102302.6b700690@hermes.local> In-Reply-To: <20240403102302.6b700690@hermes.local> From: Marek Pazdan <mpazdan@arista.com> Date: Thu, 4 Apr 2024 00:08:41 +0200 Message-ID: <CAJUFdiGUTcyehcW-pwc3yYZ8Mb2+zQUVWC=Bbg+gZJRv1a3S9Q@mail.gmail.com> Subject: Re: [PATCH] lib: add get/set link settings interface To: stephen@networkplumber.org Cc: Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000d9c4a206153877c2" X-Mailman-Approved-At: Thu, 04 Apr 2024 09:48:12 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org --000000000000d9c4a206153877c2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I can remove this part (rte_eth_config), but the new API provides other link information which is not available from the existing API, like supported/advertising/partner_advertising link modes. Additionally from what I see, rte_eth_confg is available from rte_eth_dev_conf_get API and it's copy of requested configuration: `memcpy(dev_conf, &dev->data->dev_conf, sizeof(struct rte_eth_conf));` On Wed, Apr 3, 2024 at 7:23=E2=80=AFPM Stephen Hemminger <stephen@networkpl= umber.org> wrote: > On Wed, 3 Apr 2024 16:59:08 +0200 > Marek Pazdan <mpazdan@arista.com> wrote: > > > Hi Thomas, > > > > Information like advertising: speed, pause, autonegotiation etc. and th= at > > same for link partner advertising. > > I try to mimic ethtool since it's a common, well known and widely used > tool > > so adding an API which provides the same set of information in case the > > interface is passthrough to dpdk will be useful I think. > > I've 2 more patches dependent on the one we are discussing now, but I > need > > patchwork id to add dependency information. I need moderator approval f= or > > the current patch. > > > > Regards, > > Marek > > DPDK already had this info under rte_eth_conf and it is supported > on all drivers. Why introduce yet another API and only for some drivers? > --000000000000d9c4a206153877c2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>I can remove this part (rte_eth_config), but the new = API provides other link information which is not available from the existin= g API, like supported/advertising/partner_advertising link modes.</div><div= >Additionally from what I see, rte_eth_confg is available from rte_eth_dev_= conf_get API and it's copy of requested configuration:</div><div>`memcp= y(dev_conf, &dev->data->dev_conf, sizeof(struct rte_eth_conf));`= =C2=A0</div><div><br></div><div></div></div><br><div class=3D"gmail_quote">= <div dir=3D"ltr" class=3D"gmail_attr">On Wed, Apr 3, 2024 at 7:23=E2=80=AFP= M Stephen Hemminger <<a href=3D"mailto:stephen@networkplumber.org">steph= en@networkplumber.org</a>> wrote:<br></div><blockquote class=3D"gmail_qu= ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20= 4);padding-left:1ex">On Wed, 3 Apr 2024 16:59:08 +0200<br> Marek Pazdan <<a href=3D"mailto:mpazdan@arista.com" target=3D"_blank">mp= azdan@arista.com</a>> wrote:<br> <br> > Hi Thomas,<br> > <br> > Information like advertising: speed, pause, autonegotiation etc. and t= hat<br> > same for link partner advertising.<br> > I try to mimic ethtool since it's a common, well known and widely = used tool<br> > so adding an API which provides the same set of information in case th= e<br> > interface is passthrough to dpdk will be useful I think.<br> > I've 2 more patches dependent on the one we are discussing now, bu= t I need<br> > patchwork id to add dependency information. I need moderator approval = for<br> > the current patch.<br> > <br> > Regards,<br> > Marek<br> <br> DPDK already had this info under rte_eth_conf and it is supported<br> on all drivers. Why introduce yet another API and only for some drivers?<br= > </blockquote></div> --000000000000d9c4a206153877c2--