From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDBF643A96; Tue, 6 Feb 2024 14:08:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD469410FD; Tue, 6 Feb 2024 14:08:27 +0100 (CET) Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by mails.dpdk.org (Postfix) with ESMTP id 2BCA440EF1 for ; Tue, 6 Feb 2024 13:54:45 +0100 (CET) Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-363bd37434dso10564015ab.1 for ; Tue, 06 Feb 2024 04:54:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1707224084; x=1707828884; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Lv5duKQYtAJkRmWjKExU/jFOYH4nl2j8rfttKj4EiAY=; b=TO4GKkpHV6LvBBSt9Lqhzu9EHVyDu43UKHRkpQDBZExMH2h+/EXMfnvzHE9xy5k2Bc aRjJeLOWdgQn3koRbQMlMcHmX12HPLaoRVLVhJOlKNop/JuuywS/xNpVWEnsCXP9P1w/ /KB84EUDq37VJasSGpkBQ6LC32GR+yN6Jk8ug= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707224084; x=1707828884; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lv5duKQYtAJkRmWjKExU/jFOYH4nl2j8rfttKj4EiAY=; b=nmcrnmGi57ddZAekbXuFrCXdX9i/kRH1yZbEhuozYIUNa+W8y4hoHjl7Tg+tXNaAUK 5AEzUxJnbhJjqf3dPuuTgYCoa+VORjpcclTB4eNLCGaeIpZGYZazNMpjo3mUN3Yjbfe0 tQmuCkFgW0T2t15UJY1JiMqpu2+HRzpyHhQJIJTCdihMuEvu43p2wKhzccpjzD5ud4+N i9BD3ACLXE+wuK13iyo86WNfA/lcgNZTPnizlTLe2WOqB0fg3S6I+PMS8FZBw35NMTkV XEhyjUZyqGYDyYaSMLiCNSYkV9BC6xZleZX/rjSo+hf+K1MRjwuTlPPcQiMHBXUYk0oj idQQ== X-Gm-Message-State: AOJu0YwVmNfRbm64W3QDaFyq9TrR01ReoRxn2mHqtB/jN5LgtrObTwLm kkYADjz/HS0L+M0UIkYraJIdQmsHZl2m2CozNfeoqXL9e4dvwlorBCivIjE2+bpRS+TRzHODgA9 euwgtDIbV6QHs4NcvZucuMeaO+Yb3+LUzBmodBoYhXZ8TSuBPXE86aygTEn/o0VIDNhXrVPhgGQ enwkLe X-Google-Smtp-Source: AGHT+IFougQzHUaDOTqblZ2RnZ+vVMc/ZXIi6czAHYlAND9RqqxuDcVi0A/YFZHI9oEHqb56JeqhDh8rQ3sr37g2x04= X-Received: by 2002:a92:d48a:0:b0:363:c63e:bc41 with SMTP id p10-20020a92d48a000000b00363c63ebc41mr2878476ilg.9.1707224084315; Tue, 06 Feb 2024 04:54:44 -0800 (PST) MIME-Version: 1.0 References: <20240206095607.339410-1-david.marchand@redhat.com> <20240206103420.341328-1-david.marchand@redhat.com> In-Reply-To: From: Amiya Ranjan Mohakud Date: Tue, 6 Feb 2024 18:24:08 +0530 Message-ID: Subject: Re: [PATCH v2] net/iavf: remove error logs for vlan offloading To: David Marchand Cc: dev@dpdk.org, bruce.richardson@intel.com, stable@dpdk.org, Jingjing Wu , Qiming Yang , Qi Zhang , Haiyue Wang Content-Type: multipart/alternative; boundary="00000000000019231f0610b615e8" X-Mailman-Approved-At: Tue, 06 Feb 2024 14:08:25 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000019231f0610b615e8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks @David Marchand for the quick response. Regards, Amiya On Tue, Feb 6, 2024 at 6:18=E2=80=AFPM David Marchand wrote: > On Tue, Feb 6, 2024 at 1:46=E2=80=AFPM David Marchand > wrote: > > > > On Tue, Feb 6, 2024 at 1:44=E2=80=AFPM Amiya Ranjan Mohakud > > wrote: > > > I also see a similar error with iavf using dpdk-22.11.1. But in my > case, I see 2 more additional error logs showing up during > iavf_dev_configure(). It's with ESX-8.0U1 with an inbox driver. Firmware > upgrade did not resolve the issue though. > > > > > > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 > iavf_execute_vf_cmd(): Return failure -4 for cmd 27 > > > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 > iavf_enable_vlan_strip(): Failed to execute command of > OP_ENABLE_VLAN_STRIPPING > > > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 > iavf_dev_init_vlan(): Failed to update vlan offload > > > 2023-12-08T09:58:00.906 |9322| MSG [NET] dpdk_log_write:107 > iavf_dev_configure(): configure VLAN failed: -5 > > > 2023-12-08T09:58:01.156 |9322| MSG [NET] dpdk_log_write:107 > iavf_execute_vf_cmd(): Return failure -5 for cmd 14 > > > > > > I was currently following up with KaiwenX on this. Attached the mail > thread for reference. > > > > > > Could you please let me know if this patch would fix the issue or any > more additional fixes are needed? > > > > Those logs above are about actually requesting vlan offloading. > > While in my case, I was not requesting anything. > > Ah sorry, I read too quickly and missed the iavf_dev_init_vlan(). > Well, it may be related, though I can't produce the mailbox errors in > my case, which seems specific to the ESX PF driver. > And for this, I have no clue what is wrong. > > > -- > David Marchand > > --=20 This electronic communication and the information and any files transmitted= =20 with it, or attached to it, are confidential and are intended solely for=20 the use of the individual or entity to whom it is addressed and may contain= =20 information that is confidential, legally privileged, protected by privacy= =20 laws, or otherwise restricted from disclosure to anyone else. If you are=20 not the intended recipient or the person responsible for delivering the=20 e-mail to the intended recipient, you are hereby notified that any use,=20 copying, distributing, dissemination, forwarding, printing, or copying of= =20 this e-mail is strictly prohibited. If you received this e-mail in error,= =20 please return the e-mail to the sender, delete it from your computer, and= =20 destroy any printed copy of it. --00000000000019231f0610b615e8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Feb 6, 2024 at 6:18= =E2=80=AFPM David Marchand <david.marchand@redhat.com> wrote:
On Tue, Feb 6, 2024 at 1:46=E2=80=AFPM David Marc= hand <dav= id.marchand@redhat.com> wrote:
>
> On Tue, Feb 6, 2024 at 1:44=E2=80=AFPM Amiya Ranjan Mohakud
> <amiya-ranjan.mohakud@broadcom.com> wrote:
> > I also see a similar error with iavf using dpdk-22.11.1. But in m= y case, I see=C2=A0 2 more additional error logs showing up during iavf_dev= _configure(). It's with ESX-8.0U1 with an inbox driver. Firmware upgrad= e did not resolve the issue though.
> >
> > 2023-12-08T09:58:00.906 |9322| MSG=C2=A0 =C2=A0 =C2=A0 [NET] dpdk= _log_write:107 iavf_execute_vf_cmd(): Return failure -4 for cmd 27
> > 2023-12-08T09:58:00.906 |9322| MSG=C2=A0 =C2=A0 =C2=A0 [NET] dpdk= _log_write:107 iavf_enable_vlan_strip(): Failed to execute command of OP_EN= ABLE_VLAN_STRIPPING
> > 2023-12-08T09:58:00.906 |9322| MSG=C2=A0 =C2=A0 =C2=A0 [NET] dpdk= _log_write:107 iavf_dev_init_vlan(): Failed to update vlan offload
> > 2023-12-08T09:58:00.906 |9322| MSG=C2=A0 =C2=A0 =C2=A0 [NET] dpdk= _log_write:107 iavf_dev_configure(): configure VLAN failed: -5
> > 2023-12-08T09:58:01.156 |9322| MSG=C2=A0 =C2=A0 =C2=A0 [NET] dpdk= _log_write:107 iavf_execute_vf_cmd(): Return failure -5 for cmd 14
> >
> > I was currently following up with KaiwenX on this. Attached the m= ail thread for reference.
> >
> > Could you please let me know if this patch would fix the issue or= any more additional fixes are needed?
>
> Those logs above are about actually requesting vlan offloading.
> While in my case, I was not requesting anything.

Ah sorry, I read too quickly and missed the iavf_dev_init_vlan().
Well, it may be related, though I can't produce the mailbox errors in my case, which seems specific to the ESX PF driver.
And for this, I have no clue what is wrong.


--
David Marchand


This ele= ctronic communication and the information and any files transmitted with it= , or attached to it, are confidential and are intended solely for the use o= f the individual or entity to whom it is addressed and may contain informat= ion that is confidential, legally privileged, protected by privacy laws, or= otherwise restricted from disclosure to anyone else. If you are not the in= tended recipient or the person responsible for delivering the e-mail to the= intended recipient, you are hereby notified that any use, copying, distrib= uting, dissemination, forwarding, printing, or copying of this e-mail is st= rictly prohibited. If you received this e-mail in error, please return the = e-mail to the sender, delete it from your computer, and destroy any printed= copy of it. --00000000000019231f0610b615e8--