From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5DE42469D4;
Tue, 17 Jun 2025 13:55:33 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B772040E42;
Tue, 17 Jun 2025 13:55:28 +0200 (CEST)
Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com
[209.85.219.173])
by mails.dpdk.org (Postfix) with ESMTP id 3877240E36
for <dev@dpdk.org>; Tue, 17 Jun 2025 13:55:26 +0200 (CEST)
Received: by mail-yb1-f173.google.com with SMTP id
3f1490d57ef6-e7d9d480e6cso4240196276.2
for <dev@dpdk.org>; Tue, 17 Jun 2025 04:55:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=broadcom.com; s=google; t=1750161325; x=1750766125; darn=dpdk.org;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:from:to:cc:subject:date:message-id:reply-to;
bh=rscpIgMgQjrGssttKPFHYWc+vowqryd4OrK+RGMqlOA=;
b=TBbIiZQDPEm5Jal7L1NX7hiDnpY1fEOJ5T5Tf1ZSI2IlwpyVS3I7DsezAn0LwP1vbg
a3jCy3nPt/jfaQcKyYuMNvmMaw0toulV9Eg5aFD/pU9QSjo+AJeeVp+0XrRW/cIai+nA
vG5g3CTEFsK1s+xvNa/lOIXedwQL+Ogmk6HLI=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1750161325; x=1750766125;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=rscpIgMgQjrGssttKPFHYWc+vowqryd4OrK+RGMqlOA=;
b=DZB4s1D3PDReLAvfE0w5KDbSkULmJ4aBwLuZfiTvUuk4JA/CnLjRHY/aFfgyIqKeF5
f64UPvfdUV0M0+6sOO2ju8vBJeSWey+IUNwzBSw2/OMJNk4DXXbmOMNpQxH9xo1uf/j8
JZMlYfdsMgSVLiRra6mANvCLn3Y5VbwiAUtRUkdkiEZO0a3m5D994+j6HNo+dwLt4qtl
etUwW8WcMM35Rt1vw9T0FV1a9QwLewOoOpz5XXv1soJZlJQD8IFEgWWEy8231unnAh1u
tIFDjSdAoTmscG19uZWQRH57XDHbXXTzuGF2hRUeNPENlnLsH+3dWSkslp1Ioam3kebL
VtGg==
X-Gm-Message-State: AOJu0YxzWUwHkvcAJtUx5cCsI9e9fZMiIuuB/ukDrtPj4hgdMVfLwl+7
5viIyDvmcMKnZlHkCi+ISkMdsQcoqNO28WgUevjY7dOvwHWvKe7xN2GNfijNr2Ju9F0ccS+h1lu
I/Nz0Uiagl9AGxSNEhFgvyjvmoI4TbNwyuSTn9xCRrNMgULn2wzdb7mIbb2UFW9TwpoOSxCjOfC
S6bf4yPe8eBM6DwhIbk94zNcvV
X-Gm-Gg: ASbGnctRRY/JK1/iwZt+3ZiWUZGb4H+g8YJQZWc6qdwNSNMdwPjRSn/DqYcKi8cN/wZ
RpSxtMJ4+YLSfPmcqFYBHVqmaxpFYD7ltN8wXfLxkI/zWtRHo4xamqJYiLSMqMXzvkONn9yq3eH
n8Bwm/z8w11PO0DGQNR3mOyY8mw5igBj4uogodZcFFONviVEn1uS0FTt9epunt176AHWlHRVfmW
hI=
X-Google-Smtp-Source: AGHT+IEW2k7XTUpi6NyTZHz2TfoEu4vjHk81Vrglr8B3Ef4ckfqsR1063gqjHArfyReZXg5QZfLq5KAaKuSuTjd8Cdg=
X-Received: by 2002:a05:6902:1895:b0:e80:cff4:5d1f with SMTP id
3f1490d57ef6-e822ad8a463mr16435034276.33.1750161325261; Tue, 17 Jun 2025
04:55:25 -0700 (PDT)
MIME-Version: 1.0
References: <CAJgakAcq1jA93xuOHfYhGuT9=Hj5p7DaUKq88mbL9t4bqf6qUw@mail.gmail.com>
In-Reply-To: <CAJgakAcq1jA93xuOHfYhGuT9=Hj5p7DaUKq88mbL9t4bqf6qUw@mail.gmail.com>
From: Amiya Ranjan Mohakud <amiya-ranjan.mohakud@broadcom.com>
Date: Tue, 17 Jun 2025 17:24:48 +0530
X-Gm-Features: AX0GCFuIoHsKkKoVYvUzwp3w6EgWr4OX0GbXQMddLX6IJr2FeIdFaHVBhm1aQrE
Message-ID: <CAJgakAcwPdp+hG4w1TLuFSZMcHs8z-S7ejoKhbunVaVzNg9R=g@mail.gmail.com>
Subject: Re: iavf pmd vlan Issue: dpdk-22.11.0
To: dev@dpdk.org, users@dpdk.org
Cc: wenjing.qiao@intel.com,
Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
Content-Type: multipart/alternative; boundary="00000000000017ff260637c33003"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
--00000000000017ff260637c33003
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Created a ticket: https://bugs.dpdk.org/show_bug.cgi?id=3D1725
Sharing the patch for the same for quick look.( I know it can be better
modularised.)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.=
c
index 656a4c6176..25d7924c31 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1360,6 +1360,18 @@ iavf_dev_vlan_filter_set(struct rte_eth_dev
*dev, uint16_t vlan_id, int on)
err =3D iavf_add_del_vlan_v2(adapter, vlan_id, on);
if (err)
return -EIO;
+ /* Disable strip for i40e kernel driver which supports vlan=
v2
+ * VIRTCHNL OP
+ */
+ if (adapter->hw.mac.type =3D=3D IAVF_MAC_XL710 ||
+ adapter->hw.mac.type =3D=3D IAVF_MAC_VF ||
+ adapter->hw.mac.type =3D=3D IAVF_MAC_X722_VF) {
+ if (on && !(dev_conf->rxmode.offloads &
RTE_ETH_RX_OFFLOAD_VLAN_STRIP)) {
+ err =3D iavf_disable_vlan_strip(adapter);
+ if (err)
+ return -EIO;
+ }
+ }
return 0;
}
@@ -1375,10 +1387,9 @@ iavf_dev_vlan_filter_set(struct rte_eth_dev
*dev, uint16_t vlan_id, int on)
* change strip flag. To be consistent with dpdk side, disable stri=
p
* again.
*
- * For i40e kernel driver which supports vlan v2, dpdk will
invoke vlan v2
- * related function, so it won't go through here.
*/
if (adapter->hw.mac.type =3D=3D IAVF_MAC_XL710 ||
+ adapter->hw.mac.type =3D=3D IAVF_MAC_VF ||
adapter->hw.mac.type =3D=3D IAVF_MAC_X722_VF) {
if (on && !(dev_conf->rxmode.offloads &
RTE_ETH_RX_OFFLOAD_VLAN_STRIP)) {
err =3D iavf_disable_vlan_strip(adapter);
Regards
*Amiya*
On Mon, Jun 16, 2025 at 10:04=E2=80=AFPM Amiya Ranjan Mohakud <
amiya-ranjan.mohakud@broadcom.com> wrote:
> Hi All,
>
> I'm encountering an issue with XL710 SR-IOV on KVM for VLAN packets with =
DPDK-22.11.0 version.
>
> *Issue Description:* I have disabled RTE_ETH_RX_OFFLOAD_VLAN_STRIP in rte=
_eth_conf and calling rte_eth_dev_configure and expecting my dpdk applicati=
on to receive the packets with vlan tags. Later I added some vlans using rt=
e_eth_dev_vlan_filter() and I see that the vlan is getting stripped off fo=
r the incoming packets.
>
> *Setup Details:(KVM SR-IOV)*
>
> KVM Host: Ubuntu 20.04.6 LTS: kernel version: 5.4.0-216-generic #236-Ubun=
tu
> NIC: XL710
> 3b:00.0 Ethernet controller: Intel Corporation Ethernet Controller XL710 =
for 40GbE QSFP+ (rev 02)
> 3b:00.1 Ethernet controller: Intel Corporation Ethernet Controller XL710 =
for 40GbE QSFP+ (rev 02)
> i40e PF Driver: Out of tree 2.20.12
> Firmware: 9.00/9.40
> DPDK Version: 22.11.0
>
>
> *Observation/Analysis:*
>
> I could see that even after disabling RTE_ETH_RX_OFFLOAD_VLAN_STRIP offlo=
ad flag, when I receive the packets, the mbuf offload flags (RTE_MBUF_F_RX_=
VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED) are set inside the mbuf. This confirms =
that the driver is stripping off the vlans.
>
>
> I tried with recommended PF driver version for DPDK-22.11.0 as per https:=
//mails.dpdk.org/archives/dev/2023-November/281700.html and DPDK-22.11 rele=
ase note https://doc.dpdk.org/guides/rel_notes/release_22_11.html. Still it=
did not help.
>
>
> Intel=C2=AE Ethernet Converged Network Adapter XL710-QDA2 (2X40G)
> Firmware version(PF): 9.00 0x8000ce86 1.3179.0
> Device id (pf/vf): 8086:1583 / 8086:154c
> Driver version(out-tree): 2.20.12 (i40e)
> Driver version(in-tree): 5.15.0-46-generic (i40e)
>
>
> Upon debugging further, I came across a DPDK commit: https://github.com/D=
PDK/dpdk/commit/e25c7ed114b296ddaa583427824acc30bcf9c85d which says it sets=
the vlan_strip on in PF when we set vlan filter on VF.
>
> I picked the fix, but still it did not help.
>
> Later when I debugged further, I found that the vf_cap_flags is set to VI=
RTCHNL_VF_OFFLOAD_VLAN_V2 for the above PF driver and still it sets the vla=
n_strip on. I extended the dpdk commit for the VIRTCHNL_VF_OFFLOAD_VLAN_V2 =
case which fixed the issue.
>
>
> I just want to know if it's a known issue for the VIRTCHNL_VF_OFFLOAD_VLA=
N_V2 case. I understand it's a known issue for VIRTCHNL_VF_OFFLOAD_VLAN_V1 =
and dpdk has a fix for it.
> Do we need to add the fix for VIRTCHNL_VF_OFFLOAD_VLAN_V2 as well. Can we=
mainstream it? If yes, please let me know so that I can raise a pull reque=
st for it, if required.
>
> Regards
> *Amiya*
>
>
--=20
This electronic communication and the information and any files transmitted=
=20
with it, or attached to it, are confidential and are intended solely for=20
the use of the individual or entity to whom it is addressed and may contain=
=20
information that is confidential, legally privileged, protected by privacy=
=20
laws, or otherwise restricted from disclosure to anyone else. If you are=20
not the intended recipient or the person responsible for delivering the=20
e-mail to the intended recipient, you are hereby notified that any use,=20
copying, distributing, dissemination, forwarding, printing, or copying of=
=20
this e-mail is strictly prohibited. If you received this e-mail in error,=
=20
please return the e-mail to the sender, delete it from your computer, and=
=20
destroy any printed copy of it.
--00000000000017ff260637c33003
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div><div style=3D"font-family:verdana,sans-serif;color:rg=
b(103,78,167)" class=3D"gmail_default">Created a ticket:=C2=A0<a href=3D"ht=
tps://bugs.dpdk.org/show_bug.cgi?id=3D1725" target=3D"_blank">https://bugs.=
dpdk.org/show_bug.cgi?id=3D1725</a></div><div style=3D"font-family:verdana,=
sans-serif;color:rgb(103,78,167)" class=3D"gmail_default">Sharing the patch=
for the same for quick look.( I know it can be better modularised.)</div><=
div style=3D"font-family:verdana,sans-serif;color:rgb(103,78,167)" class=3D=
"gmail_default"><br></div><div style=3D"font-family:verdana,sans-serif;colo=
r:rgb(103,78,167)" class=3D"gmail_default"><pre>diff --git a/drivers/net/ia=
vf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 656a4c6176..25d7924c31 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1360,6 +1360,18 @@ iavf_dev_vlan_filter_set(struct rte_eth_dev *dev, ui=
nt16_t vlan_id, int on)
err =3D iavf_add_del_vlan_v2(adapter, vlan_id, on);
if (err)
return -EIO;
+ /* Disable strip for i40e kernel driver which supports vlan=
v2
+ * VIRTCHNL OP
+ */
+ if (adapter->hw.mac.type =3D=3D IAVF_MAC_XL710 ||
+ adapter->hw.mac.type =3D=3D IAVF_MAC_VF ||
+ adapter->hw.mac.type =3D=3D IAVF_MAC_X722_VF) {
+ if (on && !(dev_conf->rxmode.offloads &a=
mp; RTE_ETH_RX_OFFLOAD_VLAN_STRIP)) {
+ err =3D iavf_disable_vlan_strip(adapter);
+ if (err)
+ return -EIO;
+ }
+ }
return 0;
}
=20
@@ -1375,10 +1387,9 @@ iavf_dev_vlan_filter_set(struct rte_eth_dev *dev, ui=
nt16_t vlan_id, int on)
* change strip flag. To be consistent with dpdk side, disable stri=
p
* again.
*
- * For i40e kernel driver which supports vlan v2, dpdk will invoke =
vlan v2
- * related function, so it won't go through here.
*/
if (adapter->hw.mac.type =3D=3D IAVF_MAC_XL710 ||
+ adapter->hw.mac.type =3D=3D IAVF_MAC_VF ||
adapter->hw.mac.type =3D=3D IAVF_MAC_X722_VF) {
if (on && !(dev_conf->rxmode.offloads & RTE_=
ETH_RX_OFFLOAD_VLAN_STRIP)) {
err =3D iavf_disable_vlan_strip(adapter);
</pre></div></div><div><div dir=3D"ltr" class=3D"gmail_signature" data-sm=
artmail=3D"gmail_signature"><div dir=3D"ltr"><div><span style=3D"font-size:=
10pt;font-family:Arial,sans-serif;font-weight:700;vertical-align:baseline">=
<font color=3D"#666666"><span style=3D"font-size:13.3333px">Regards</span><=
br></font></span></div><span style=3D"font-size:10pt;font-family:Arial,sans=
-serif;vertical-align:baseline"><b><font color=3D"#666666">Amiya</font></b>=
</span><div><div><div><span style=3D"font-size:10pt;font-family:Arial,sans-=
serif;color:rgb(102,102,102);vertical-align:baseline"><br></span></div></di=
v></div></div></div></div><br></div><br><div class=3D"gmail_quote gmail_quo=
te_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jun 16, 2025 at=
10:04=E2=80=AFPM Amiya Ranjan Mohakud <<a href=3D"mailto:amiya-ranjan.m=
ohakud@broadcom.com">amiya-ranjan.mohakud@broadcom.com</a>> wrote:<br></=
div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div=
><pre style=3D"font-size:13px;color:rgb(0,0,0)">Hi All,<br><br>I'm enco=
untering an issue with XL710 SR<span class=3D"gmail_default" style=3D"font-=
family:verdana,sans-serif">-</span>IOV on KVM for VLAN packets with DPDK-22=
.11.0 version. <br><br><b><u>Issue Description:</u></b> I have disabled RTE=
_ETH_RX_OFFLOAD_VLAN_STRIP in rte_eth_conf and calling rte_eth_dev_configur=
e and expecting my dpdk application to receive the packets with vlan tags. =
Later I added some vlans using rte_eth_dev_vlan_filter() and I see that the=
vlan is getting stripped off =C2=A0for the incoming packets. <br><br><b><u=
>Setup Details:(KVM SR<span class=3D"gmail_default" style=3D"font-family:ve=
rdana,sans-serif">-</span>IOV)</u></b><br><br>KVM Host: Ubuntu 20.04.6 LTS:=
kernel version: 5.4.0-216-generic #236-Ubuntu<br>NIC: XL710<br>3b:00.0 Eth=
ernet controller: Intel Corporation Ethernet Controller XL710 for 40GbE QSF=
P+ (rev 02)<br>3b:00.1 Ethernet controller: Intel Corporation Ethernet Cont=
roller XL710 for 40GbE QSFP+ (rev 02)<br>i40e PF Driver: Out of tree 2.20.1=
2<br>Firmware: 9.00/9.40 <br>DPDK Version: 22.11.0<br><br><br><b><u>Observa=
tion/Analysis:</u></b><br><br>I could see that even after disabling RTE_ETH=
_RX_OFFLOAD_VLAN_STRIP offload flag, when I receive the packets, the mbuf o=
ffload flags (RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED) are set ins=
ide the mbuf. This confirms that the driver is stripping off the vlans.</pr=
e><pre style=3D"font-size:13px;color:rgb(0,0,0)"><br>I tried with recommend=
ed PF driver version for DPDK-22.11.0 as per <a href=3D"https://mails.dpdk.=
org/archives/dev/2023-November/281700.html" target=3D"_blank">https://mails=
.dpdk.org/archives/dev/2023-November/281700.html</a> and DPDK-22.11 release=
note <a href=3D"https://doc.dpdk.org/guides/rel_notes/release_22_11.html" =
target=3D"_blank">https://doc.dpdk.org/guides/rel_notes/release_22_11.html<=
/a>. Still it did not help.<br><br><br><span class=3D"gmail_default" style=
=3D"font-family:verdana,sans-serif"> </span>Intel=C2=AE Ethernet Conv=
erged Network Adapter XL710-QDA2 (2X40G)<br>=C2=A0 =C2=A0 Firmware version(=
PF): 9.00 0x8000ce86 1.3179.0<br>=C2=A0 =C2=A0 Device id (pf/vf): 8086:1583=
/ 8086:154c<br>=C2=A0 =C2=A0 Driver version(out-tree): 2.20.12 (i40e)<br>=
=C2=A0 =C2=A0 Driver version(in-tree): 5.15.0-46-generic (i40e)<br><br><br>=
Upon debugging further, I came across a DPDK commit: <a href=3D"https://git=
hub.com/DPDK/dpdk/commit/e25c7ed114b296ddaa583427824acc30bcf9c85d" target=
=3D"_blank">https://github.com/DPDK/dpdk/commit/e25c7ed114b296ddaa583427824=
acc30bcf9c85d</a><span class=3D"gmail_default" style=3D"font-family:verdana=
,sans-serif"> </span>which says it sets the vlan_strip on in PF when we set=
vlan filter on VF. <br><br></pre><pre style=3D"font-size:13px;color:rgb(0,=
0,0)">I picked the fix, but still it did not help.<br><br>Later when I debu=
gged further, I found that the vf_cap_flags is set to VIRTCHNL_VF_OFFLOAD_V=
LAN_V2 for the above PF driver and still it sets the vlan_strip on. I exten=
ded the dpdk commit for the VIRTCHNL_VF_OFFLOAD_VLAN_V2 case which fixed th=
e issue.<br><br><br>I just want to know if it's a known issue for the V=
IRTCHNL_VF_OFFLOAD_VLAN_V2 case. I understand it's a known issue for VI=
RTCHNL_VF_OFFLOAD_VLAN_V1 and dpdk has a fix for it. <br>Do we need to add =
the fix for VIRTCHNL_VF_OFFLOAD_VLAN_V2 as well. Can we mainstream it? If y=
es, please let me know so that I can raise a pull request for it, if requir=
ed.</pre></div><div><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"=
ltr"><div><span style=3D"font-size:10pt;font-family:Arial,sans-serif;font-w=
eight:700;vertical-align:baseline"><font color=3D"#666666"><span style=3D"f=
ont-size:13.3333px">Regards</span><br></font></span></div><span style=3D"fo=
nt-size:10pt;font-family:Arial,sans-serif;vertical-align:baseline"><b><font=
color=3D"#666666">Amiya</font></b></span><div><div><div><span style=3D"fon=
t-size:10pt;font-family:Arial,sans-serif;color:rgb(102,102,102);vertical-al=
ign:baseline"><br></span></div></div></div></div></div></div></div>
</blockquote></div>
<br>
<span style=3D"background-color:rgb(255,255,255)"><font size=3D"2">This ele=
ctronic communication and the information and any files transmitted with it=
, or attached to it, are confidential and are intended solely for the use o=
f the individual or entity to whom it is addressed and may contain informat=
ion that is confidential, legally privileged, protected by privacy laws, or=
otherwise restricted from disclosure to anyone else. If you are not the in=
tended recipient or the person responsible for delivering the e-mail to the=
intended recipient, you are hereby notified that any use, copying, distrib=
uting, dissemination, forwarding, printing, or copying of this e-mail is st=
rictly prohibited. If you received this e-mail in error, please return the =
e-mail to the sender, delete it from your computer, and destroy any printed=
copy of it.</font></span>
--00000000000017ff260637c33003--