From: Tapio Tallgren <tapio.tallgren@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Newbie question: compiling virtio-net-pmd v1.2 fails with dpdk 1.7 on a VM
Date: Thu, 20 Nov 2014 14:37:27 +0200 [thread overview]
Message-ID: <CAJi57Q=YB4zp0y7rYvdzgSwaP2dbmsQG52QQjtfv1hErC3oe=A@mail.gmail.com> (raw)
In-Reply-To: <6470390.sH3U320kkz@xps13>
On Thu, Nov 20, 2014 at 1:33 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> 2014-11-20 06:17, Neil Horman:
> > On Thu, Nov 20, 2014 at 09:14:35AM +0200, Tapio Tallgren wrote:
> > > Looks like a version conflict? Dpdk 1.7 should support virtio-pmd so
> what
> > > am I doing wrong?
> >
> > Nothing, its a bug. DPDK changed the API here with commit
> > 9aaccf1abdb2894ec23870e1d2199a657f85850e but it never got changed in the
> > virtio_user pmd. You need to modify the pmd like the other call sites
> have been
> > in the above commit.
> >
> > This is why those external pmds need to be merged into the dpdk tree.
>
> Yes, exactly.
> We'll see during 2.0 cycle how to merge them. The ideal plan is to keep
> only
> 1 implementation.
>
> In the meantime, patches are welcome.
>
> --
> Thomas
>
This looks like a purely cosmetic change? So, if the code compiles, then it
will also run correctly?
--
-Tapio
next prev parent reply other threads:[~2014-11-20 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 7:14 Tapio Tallgren
2014-11-20 11:17 ` Neil Horman
2014-11-20 11:33 ` Thomas Monjalon
2014-11-20 12:37 ` Tapio Tallgren [this message]
2014-11-20 14:17 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJi57Q=YB4zp0y7rYvdzgSwaP2dbmsQG52QQjtfv1hErC3oe=A@mail.gmail.com' \
--to=tapio.tallgren@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).