From: Cody Doucette <doucette@bu.edu>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"michel@digirati.com.br" <michel@digirati.com.br>,
Qiaobin Fu <qiaobinf@bu.edu>
Subject: Re: [dpdk-dev] [PATCH] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()
Date: Fri, 29 Jun 2018 13:38:15 -0400 [thread overview]
Message-ID: <CAJjX64Y0W4-zzAHWNpHJ9OY8HvesCa3gRtkPWJ8gdHeaUeVF5w@mail.gmail.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB977258C0C45010@irsmsx105.ger.corp.intel.com>
Hi,
> Just a generic thought - might be worse to move functions that parse ipv6 header extentions
> and related strcutures into rte_net.
> I am sure they might be reused by some other code.
Sorry, I am misunderstanding. Do you mean it might be better to move
struct ipv6_opt_hdr and ipv6_ext_hdr() into rte_net since they are not
fragmentation specific? That seems fine to me.
> pktmbuf_read() is quite heavy-weight one.
> Do we really need it here?
> From my perspective - add an assumption that all whole IPv6 header will be inside
> one segment seems reasonable enough.
It is my understanding that rte_pktmbuf_read() will almost always just
invoke a light weight rte_pktmbuf_mtod_offset(). It only runs the
heavy weight __rte_pktmbuf_read() in the case that the assumption you
mentioned is broken.
Thanks for looking!
Cody
next prev parent reply other threads:[~2018-06-29 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 1:44 Cody Doucette
2018-06-29 16:58 ` Ananyev, Konstantin
2018-06-29 17:38 ` Cody Doucette [this message]
2018-07-17 13:54 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJjX64Y0W4-zzAHWNpHJ9OY8HvesCa3gRtkPWJ8gdHeaUeVF5w@mail.gmail.com \
--to=doucette@bu.edu \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=michel@digirati.com.br \
--cc=qiaobinf@bu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).