From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay52.bu.edu (relay52.bu.edu [128.197.228.12]) by dpdk.org (Postfix) with ESMTP id 756D92C2F for ; Tue, 30 Oct 2018 19:10:48 +0100 (CET) X-Envelope-From: doucette@bu.edu Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay52.bu.edu (8.14.3/8.14.3) with ESMTP id w9UIACwq019883 for ; Tue, 30 Oct 2018 14:10:12 -0400 Received: by mail-wr1-f71.google.com with SMTP id q1-v6so11053270wrr.9 for ; Tue, 30 Oct 2018 11:10:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6esuHoix3eHNHiMpBlJuVEB0wZsNH37RF6HeuQZusmI=; b=l5z6kFLJrzN7nmdz45Iz1ZQj6dSNHKhEKhu5pKxZyMJnr5/UJRxY6vX1Wj8jgTbqiY cixEwRwOD/7Sr+Gf7qLSQRSmtcmFpDlWHa6VHk5NGSlWlT6aBN4zur4VmyqY1yF8eeDz TDSWCSZTppPsw8msMO/SZoD8N0OXmA7nMxJ5/EVJoffMd3EceZAjof+BP84E9Nw0zfAg NE+10xsCN9ZTYylYSPCEA1hJ5UWeM+1wgYWFHz6EMEF+KfOPEDAC30d6uEQmKXCdSnJp l6/5xb6U3YcL7tGOEj63oRt1EUA7ls9QtJZ2Uowk5ZWSUzMrwucr1wdME6NfEtKTTwtG zjfg== X-Gm-Message-State: AGRZ1gL6ZXqKD2hMEneV1KITIV613A6VohqbkZxO9gkIpsKvb4QbpLFh TZujaAiXmQRloiiw+K/S6k95xbIh7lqdribdDk4UHuUCXKeHlxoZtAkAt4H/IQtOCgiXkWZ12jC mXP9PDZdwyEQkF4yDB1mz X-Received: by 2002:adf:bb0f:: with SMTP id r15-v6mr19524766wrg.24.1540923011467; Tue, 30 Oct 2018 11:10:11 -0700 (PDT) X-Google-Smtp-Source: AJdET5fIrVokWDHyq2MjGCUeUqRFRSSfnQ6RSfeQfeR6ScH9NK6bCTALjaxDFhSgOejL8bkWcVbx001C4XgjR1jc+mA= X-Received: by 2002:adf:bb0f:: with SMTP id r15-v6mr19524727wrg.24.1540923010824; Tue, 30 Oct 2018 11:10:10 -0700 (PDT) MIME-Version: 1.0 References: <20180727135243.147744-1-doucette@bu.edu> <5318192.uTAyPRLYMi@xps> <2601191342CEEE43887BDE71AB97725801030656B1@irsmsx105.ger.corp.intel.com> <9635910.y5ZcffoGi6@xps> In-Reply-To: <9635910.y5ZcffoGi6@xps> From: Cody Doucette Date: Tue, 30 Oct 2018 14:09:58 -0400 Message-ID: To: thomas@monjalon.net Cc: "Ananyev, Konstantin" , dev@dpdk.org, Gaetan Rivet , Olivier Matz , "Dumitrescu, Cristian" , Michel Machado , "Fu, Qiaobin" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 18:10:48 -0000 OK, I will send three separate patches plus a cover letter. I seem to be having trouble with checkpatch complaining that new symbols are not inserted into the EXPERIMENTAL section of the .map file: ERROR: symbol break is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol const is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol &frag_hdr_buf) is added in a section other than the EXPERIMENTAL section of the version map INFO: symbol frag_hdr is being removed, ensure that it has gone through the deprecation process INFO: symbol is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol offset, is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol offset is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol return is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol return is added in a section other than the EXPERIMENTAL section of the version map INFO: symbol is added but patch has insuficient context to determine the section name please ensure the version is EXPERIMENTAL ERROR: symbol sizeof(*frag_hdr), is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol size_t is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol struct is added in a section other than the EXPERIMENTAL section of the version map INFO: symbol struct is being removed, ensure that it has gone through the deprecation process ERROR: symbol struct is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol uint8_t is added in a section other than the EXPERIMENTAL section of the version map Even when moving the new symbol into the EXPERIMENTAL version and recreating the patch, checkpatch still issues the same errors. Can I leave the .map file as it is in v3? If not, any suggestions on what checkpatch is looking for me to do here? Cody On Tue, Oct 30, 2018 at 10:36 AM Thomas Monjalon wrote: > 30/10/2018 10:46, Ananyev, Konstantin: > > Hi Thomas, > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 28/10/2018 21:54, Cody Doucette: > > > > On Sun, Oct 28, 2018 at 6:22 AM Thomas Monjalon > wrote: > > > > > 27/07/2018 15:52, Cody Doucette: > > > > > > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > > > > > > other IPv6 extension headers when finding the fragment header. > > > > > > > > > > > > According to RFC 8200, there is no guarantee that the IPv6 > > > > > > Fragment extension header will come before any other extension > > > > > > header, even though it is recommended. > > > > > > > > > > > > Signed-off-by: Cody Doucette > > > > > > Signed-off-by: Qiaobin Fu > > > > > > Reviewed-by: Michel Machado > > > > > > --- > > > > > > v3: > > > > > > * Removed compilation flag D_XOPEN_SOURCE=700 from the > > > > > > failsafe driver to allow compilation on freebsd. > > > > > > > > > > How failsafe is related to ip_frag? > > > > > > > > > > > > > > > > v2: > > > > > > * Moved IPv6 extension header definitions to lib_net. > > > > > > > > > > > > drivers/net/failsafe/Makefile | 1 - > > > > > > drivers/net/failsafe/meson.build | 1 - > > > > > > examples/ip_reassembly/main.c | 6 ++-- > > > > > > lib/librte_ip_frag/rte_ip_frag.h | 23 ++++++------- > > > > > > lib/librte_ip_frag/rte_ip_frag_version.map | 1 + > > > > > > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 38 > +++++++++++++++++++++ > > > > > > lib/librte_ip_frag/rte_ipv6_reassembly.c | 4 +-- > > > > > > lib/librte_net/rte_ip.h | 27 +++++++++++++++ > > > > > > lib/librte_port/rte_port_ras.c | 6 ++-- > > > > > > > > > > Changes in failsafe, rte_net and rte_port look like garbage. > > > > > > > > > > Anyway, the ip_frag part requires some review. > > > > > +Cc Konstantin, the maintainer. > > > > > > > > Garbage in what sense? I would be happy to amend with a little more > > > > information. > > > > > > > > The changes to failsafe and rte_net were from previous reviews from > > > > Konstantin: > > > > > > > > https://mails.dpdk.org/archives/dev/2018-June/106023.html > > > > > > > > https://mails.dpdk.org/archives/dev/2018-July/108701.html > > > > > > After a better look, the change in rte_port is fine. > > > > > > But the changes in failsafe and rte_net would be better in their own > patch. > > > You can have 3 patches in a patchset (with a cover letter to explain > the > > > global idea). > > > Then, failsafe and rte_net changes must be reviewed by their > maintainers. > > > > > > > The patch looks good to me. > > About failsafe changes - the reason for that was that failsafe driver > didn't build > > properly with the proposed changes. > > Gaetan was ok to remove that extra compiler flag: > > https://mails.dpdk.org/archives/dev/2018-July/108826.html > > OK. Please send the failsafe patch as the first of the series. > Thanks > > >