From: Cody Doucette <doucette@bu.edu>
To: thomas@monjalon.net
Cc: dev@dpdk.org, Gaetan Rivet <gaetan.rivet@6wind.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
Michel Machado <michel@digirati.com.br>,
"Fu, Qiaobin" <qiaobinf@bu.edu>
Subject: Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()
Date: Sun, 28 Oct 2018 16:54:58 -0400 [thread overview]
Message-ID: <CAJjX64a5pEpouyjdie5x10+BFXC0YT9LteH9fetoNGwpKShRqg@mail.gmail.com> (raw)
In-Reply-To: <1549031.gagrcBMtR4@xps>
Garbage in what sense? I would be happy to amend with a little more
information.
The changes to failsafe and rte_net were from previous reviews from
Konstantin:
https://mails.dpdk.org/archives/dev/2018-June/106023.html
https://mails.dpdk.org/archives/dev/2018-July/108701.html
Best,
Cody
On Sun, Oct 28, 2018 at 6:22 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> 27/07/2018 15:52, Cody Doucette:
> > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any
> > other IPv6 extension headers when finding the fragment header.
> >
> > According to RFC 8200, there is no guarantee that the IPv6
> > Fragment extension header will come before any other extension
> > header, even though it is recommended.
> >
> > Signed-off-by: Cody Doucette <doucette@bu.edu>
> > Signed-off-by: Qiaobin Fu <qiaobinf@bu.edu>
> > Reviewed-by: Michel Machado <michel@digirati.com.br>
> > ---
> > v3:
> > * Removed compilation flag D_XOPEN_SOURCE=700 from the
> > failsafe driver to allow compilation on freebsd.
>
> How failsafe is related to ip_frag?
>
>
> > v2:
> > * Moved IPv6 extension header definitions to lib_net.
> >
> > drivers/net/failsafe/Makefile | 1 -
> > drivers/net/failsafe/meson.build | 1 -
> > examples/ip_reassembly/main.c | 6 ++--
> > lib/librte_ip_frag/rte_ip_frag.h | 23 ++++++-------
> > lib/librte_ip_frag/rte_ip_frag_version.map | 1 +
> > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 38 +++++++++++++++++++++
> > lib/librte_ip_frag/rte_ipv6_reassembly.c | 4 +--
> > lib/librte_net/rte_ip.h | 27 +++++++++++++++
> > lib/librte_port/rte_port_ras.c | 6 ++--
>
> Changes in failsafe, rte_net and rte_port look like garbage.
>
> Anyway, the ip_frag part requires some review.
> +Cc Konstantin, the maintainer.
>
>
>
>
next prev parent reply other threads:[~2018-10-28 20:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 13:52 Cody Doucette
2018-08-20 19:31 ` Cody Doucette
2018-10-28 10:21 ` Thomas Monjalon
2018-10-28 20:54 ` Cody Doucette [this message]
2018-10-28 21:19 ` Thomas Monjalon
2018-10-30 9:46 ` Ananyev, Konstantin
2018-10-30 14:36 ` Thomas Monjalon
2018-10-30 18:09 ` Cody Doucette
2018-10-30 23:12 ` Thomas Monjalon
2018-10-31 9:27 ` Neil Horman
2018-10-31 14:20 ` Cody Doucette
2018-10-31 15:03 ` Neil Horman
2018-10-31 15:08 ` Thomas Monjalon
2018-11-01 13:53 ` Neil Horman
2018-11-01 14:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJjX64a5pEpouyjdie5x10+BFXC0YT9LteH9fetoNGwpKShRqg@mail.gmail.com \
--to=doucette@bu.edu \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=konstantin.ananyev@intel.com \
--cc=michel@digirati.com.br \
--cc=olivier.matz@6wind.com \
--cc=qiaobinf@bu.edu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).