From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay55.bu.edu (relay55.bu.edu [128.197.228.15]) by dpdk.org (Postfix) with ESMTP id D972B5920 for ; Sun, 28 Oct 2018 21:55:34 +0100 (CET) X-Envelope-From: doucette@bu.edu Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay55.bu.edu (8.14.3/8.14.3) with ESMTP id w9SKtCrr009858 for ; Sun, 28 Oct 2018 16:55:12 -0400 Received: by mail-ed1-f72.google.com with SMTP id x44-v6so4353985edd.17 for ; Sun, 28 Oct 2018 13:55:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KTl2aUsYJSBe+dexdmDb0jd+7q8vBKJfzpI6vygeymc=; b=LUfYEB7kBhwPE+0PMfv0akGs//pPk8tuAFqa3aXMHDA7yIdrHzlt9SUWxpni74CbPl S2+lnMjP47a8xDzPYfdpkgT2nJ2eMv/uG6uBwXythMpEPWAF9iD7RmJ/hZgpFqTEZ6xv c/O4oHsHvIHfE0UWQ/gIZxg9+DFNmdZgzFdR8sWuz3E1VupMr0U3zZDeKkKlMcAONAkm CAWubam9f3q7bnq8emqUTPjnlPl9w+zgT9hGVDqzrLjMTefugNHjUnAySsXazB01/mtN Nencs3cxwKW38Lq8aSQF+MKPLTjtdQwMSZEj6LTB91GCE3YroY65Hn7zsmWwMa48cLWv 1ujg== X-Gm-Message-State: AGRZ1gIl6ND4owqIIIR26EWWbGTcd06tjWUPKDkwRoRmPhxkbdLHoIJk 0fxoUThlAVvItEHljcbdBV2xbpBaY++cRihwuAtwBemcApM7uHIWIjky2Z7ooiYGBFUxq03Kc5s UA/8vFwpDwg45lIVeHutW X-Received: by 2002:adf:8065:: with SMTP id 92-v6mr12115600wrk.23.1540760111659; Sun, 28 Oct 2018 13:55:11 -0700 (PDT) X-Google-Smtp-Source: AJdET5fE0tcBsBrnj0gKjG+RMpH967PMCSHB0Rwr+Htqk7RV3/5hmTr3WOPbVkEL53y6dOe9Top/5hbjxlzD7faEMD8= X-Received: by 2002:adf:8065:: with SMTP id 92-v6mr12115584wrk.23.1540760111198; Sun, 28 Oct 2018 13:55:11 -0700 (PDT) MIME-Version: 1.0 References: <20180727135243.147744-1-doucette@bu.edu> <1549031.gagrcBMtR4@xps> In-Reply-To: <1549031.gagrcBMtR4@xps> From: Cody Doucette Date: Sun, 28 Oct 2018 16:54:58 -0400 Message-ID: To: thomas@monjalon.net Cc: dev@dpdk.org, Gaetan Rivet , "Ananyev, Konstantin" , Olivier Matz , "Dumitrescu, Cristian" , Michel Machado , "Fu, Qiaobin" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2018 20:55:35 -0000 Garbage in what sense? I would be happy to amend with a little more information. The changes to failsafe and rte_net were from previous reviews from Konstantin: https://mails.dpdk.org/archives/dev/2018-June/106023.html https://mails.dpdk.org/archives/dev/2018-July/108701.html Best, Cody On Sun, Oct 28, 2018 at 6:22 AM Thomas Monjalon wrote: > 27/07/2018 15:52, Cody Doucette: > > Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any > > other IPv6 extension headers when finding the fragment header. > > > > According to RFC 8200, there is no guarantee that the IPv6 > > Fragment extension header will come before any other extension > > header, even though it is recommended. > > > > Signed-off-by: Cody Doucette > > Signed-off-by: Qiaobin Fu > > Reviewed-by: Michel Machado > > --- > > v3: > > * Removed compilation flag D_XOPEN_SOURCE=700 from the > > failsafe driver to allow compilation on freebsd. > > How failsafe is related to ip_frag? > > > > v2: > > * Moved IPv6 extension header definitions to lib_net. > > > > drivers/net/failsafe/Makefile | 1 - > > drivers/net/failsafe/meson.build | 1 - > > examples/ip_reassembly/main.c | 6 ++-- > > lib/librte_ip_frag/rte_ip_frag.h | 23 ++++++------- > > lib/librte_ip_frag/rte_ip_frag_version.map | 1 + > > lib/librte_ip_frag/rte_ipv6_fragmentation.c | 38 +++++++++++++++++++++ > > lib/librte_ip_frag/rte_ipv6_reassembly.c | 4 +-- > > lib/librte_net/rte_ip.h | 27 +++++++++++++++ > > lib/librte_port/rte_port_ras.c | 6 ++-- > > Changes in failsafe, rte_net and rte_port look like garbage. > > Anyway, the ip_frag part requires some review. > +Cc Konstantin, the maintainer. > > > >