Re: [PATCH v12 07/10] dts: replace use of sanity check in comment

[Patrick Robb <probb@iol.unh.edu>]

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

Unfortunately I do find myself saying sanity check often... something to
cut out from my vocabulary. From a quick google it looks like many are
using coherence check in its place, or just explicitly writing out what the
check is as you did.

It would also probably be fine to just remove the comment entirely given
the assert immediately following it also contains its own explanation of
the check. But, I guess the original author thought it was useful to have
the comment, so we can keep it.

Reviewed-by: Patrick Robb <probb@iol.unh.edu>

On Wed, Apr 2, 2025 at 7:24 PM Stephen Hemminger <stephen@networkplumber.org>
wrote:

> Replace with better words.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  dts/tests/TestSuite_blocklist.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dts/tests/TestSuite_blocklist.py
> b/dts/tests/TestSuite_blocklist.py
> index ce7da1cc8f..82109f72a1 100644
> --- a/dts/tests/TestSuite_blocklist.py
> +++ b/dts/tests/TestSuite_blocklist.py
> @@ -22,7 +22,7 @@ def verify_blocklisted_ports(self, ports_to_block:
> list[Port]):
>              allowlisted_ports = {port.device_name for port in
> testpmd.show_port_info_all()}
>              blocklisted_ports = {port.pci for port in ports_to_block}
>
> -            # sanity check
> +            # ensure at least one port is allowed
>              allowed_len = len(allowlisted_ports - blocklisted_ports)
>              self.verify(allowed_len > 0, "At least one port should have
> been allowed")
>
> --
> 2.47.2
>
>

[-- Attachment #2: Type: text/html, Size: 2153 bytes --]