From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2879943B62;
	Wed, 21 Feb 2024 20:09:45 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EBF5740297;
	Wed, 21 Feb 2024 20:09:44 +0100 (CET)
Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com
 [209.85.161.52]) by mails.dpdk.org (Postfix) with ESMTP id B93BE4013F
 for <dev@dpdk.org>; Wed, 21 Feb 2024 20:09:43 +0100 (CET)
Received: by mail-oo1-f52.google.com with SMTP id
 006d021491bc7-5a00dfbeb3cso643012eaf.0
 for <dev@dpdk.org>; Wed, 21 Feb 2024 11:09:43 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1708542583; x=1709147383; darn=dpdk.org;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:from:to:cc:subject:date:message-id:reply-to;
 bh=hIWiUpX41SBf0h2pBseHcMAJQUudwn6uUdE0KBC4EIU=;
 b=c+UBZ1rZvOIEHVfZlPDPBQgrVl5Uphs337F4Dpr74+Tjyv3oaast9NrkKG2ShITGtB
 AKYSYYWMTDQOXjMOPK51qqdiJnRnjw5IsjhH/C+kASrZMEdM1IlT03n20exYcVXV8rTD
 ekyllof2o47gNKq2MCv71D5u4YmflONryHFrg=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1708542583; x=1709147383;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=hIWiUpX41SBf0h2pBseHcMAJQUudwn6uUdE0KBC4EIU=;
 b=gsXUCmGcXbEmiwVYAiSnE22HUc+A/+SePdsQjtr0tPhaCcE59+xcQm/rvjT2QBYKYr
 ubpfjwuh02RPv5mnKp4DdvfQ0JGKpl7IjcBmwEYcPCXOakxn9LnBLQjOPRpIUpsDFu/D
 mEeJvlnw8SLmw0GrTTnJSu7Mz+f3A/XPfeYtcNkpJZsV2QQz1FxrHHT+bjpSfGKYYBh6
 wsh4FeaWd3VnzFfLma/iu7/sTYaXfVIhzXzaw75JhhVC6TFaznWbgEX39kZaR3mhVp8a
 qSAgPFYmpuy3iia7UFD7s26/j1sq+eRsyhMm97Js4nE5k1S0+EtglgIhukh19ev1e9fJ
 82uw==
X-Forwarded-Encrypted: i=1;
 AJvYcCUGd09wqRu5sGvY9Jj7IPECZaF3ZG+ZVsk7gYEOIh8jEGCGv9O52n9ti44jkSzTnDGJIUwbnKx2w1ER1Uk=
X-Gm-Message-State: AOJu0Ywwsu/hi2IRMEXYGflxho/vP5t+iS3REbg4O4/nvBsgFgmBtPAM
 EZf4EB2iE93fZZI3te6yZqSidyRO8QVGO0huMhadDwx4fAlJCXXZDNgUIMIc6/zcPVETU6lHi2S
 h0WvKbVaUR8yhsoQ5HuIKag/okAEXBrErri9Ifg==
X-Google-Smtp-Source: AGHT+IGUdnNsynGVS3P3yepmIbSv5bozu73AxC+jpSdgCAOulNZyAfqYC5eQpPsV/rwGrfC+Kxtm9cbrqxXsDt5Xcf4=
X-Received: by 2002:a4a:900a:0:b0:59c:b9ad:4ba3 with SMTP id
 i10-20020a4a900a000000b0059cb9ad4ba3mr18025498oog.3.1708542582984; Wed, 21
 Feb 2024 11:09:42 -0800 (PST)
MIME-Version: 1.0
References: <20230421131221.1732314-1-ciara.power@intel.com>
 <20230516152422.606617-1-ciara.power@intel.com>
 <20230516152422.606617-9-ciara.power@intel.com>
 <112430369.nniJfEyVGO@thomas>
 <CO6PR18MB44847F67F56288592B4FB828D85AA@CO6PR18MB4484.namprd18.prod.outlook.com>
 <AS8PR08MB811033306B75EEF2B694D4D2E85BA@AS8PR08MB8110.eurprd08.prod.outlook.com>
 <CO6PR18MB44846058F310B82454201B30D85BA@CO6PR18MB4484.namprd18.prod.outlook.com>
 <DM8PR11MB55917C5C2EB33054E6090B1B8458A@DM8PR11MB5591.namprd11.prod.outlook.com>
 <CO6PR18MB4484DB18AC976FC7D70D5950D858A@CO6PR18MB4484.namprd18.prod.outlook.com>
 <AS8PR08MB8110C1EF0AFD398D53106F21E85CA@AS8PR08MB8110.eurprd08.prod.outlook.com>
 <CAJvnSUCp8fjkTXcDjBRv1XXppFH6Sp4ZHGe7OZ5eF_Dh086CgQ@mail.gmail.com>
 <238D3DE6-AE8B-45A0-85A5-F7FF5EEB7665@arm.com>
 <SN7PR11MB7639E18B07E4DE86925E5242E6572@SN7PR11MB7639.namprd11.prod.outlook.com>
In-Reply-To: <SN7PR11MB7639E18B07E4DE86925E5242E6572@SN7PR11MB7639.namprd11.prod.outlook.com>
From: Patrick Robb <probb@iol.unh.edu>
Date: Wed, 21 Feb 2024 14:09:32 -0500
Message-ID: <CAJvnSUAH3NKeZxrizFQ7TmDCJM=BQpQA1HzpCLXpFV8oDuozZw@mail.gmail.com>
Subject: Re: [EXT] [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID
To: "Power, Ciara" <ciara.power@intel.com>
Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 Fangming Fang <Fangming.Fang@arm.com>, Akhil Goyal <gakhil@marvell.com>, 
 "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, 
 "thomas@monjalon.net" <thomas@monjalon.net>, "Ji, Kai" <kai.ji@intel.com>, 
 Ruifeng Wang <Ruifeng.Wang@arm.com>, "Mcnamara, John" <john.mcnamara@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "Marchand, David" <david.marchand@redhat.com>, 
 "jerinj@marvell.com" <jerinj@marvell.com>,
 Ashwin Sekhar T K <asekhar@marvell.com>, 
 Wathsala Wathawana Vithanage <wathsala.vithanage@arm.com>,
 Dhruv Tripathi <Dhruv.Tripathi@arm.com>
Content-Type: multipart/alternative; boundary="000000000000be2d8e0611e911f5"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

--000000000000be2d8e0611e911f5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 21, 2024 at 4:50=E2=80=AFAM Power, Ciara <ciara.power@intel.com=
> wrote:

>
> Hi folks,
>
> We had based the ipsec-mb version bump to 1.4 on both intel ipsec-mb and
> arm ipsec-mb supporting that version, so both could still use the Ipsec-m=
b
> SW PMDs.
> I based the arm support from the repo main branch (
> https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-/tree/main)
> It's version is 1.4 and looks like some of the code changes from
> intel-ipsec-mb 1.4 have been merged in (e.g. imb_set_session function whi=
ch
> is 1.4+).
> I know there was issues before with it being tagged as 1.4 too soon - is
> that still the case, or is the main branch up to date now with
> intel-ipsec-mb 1.4?
>
> Thanks,
> Ciara
>

Hi Ciara,

I see what you mean and did a test on an arm container. I used tip of main
for ipsec-mb, applied the v1.4 requirement patch to dpdk, built dpdk and
was able to run the ZUC autotest with the zuc vdev pmd.

root@8aad8acde315:/opt/dpdk/build# meson test cryptodev_sw_zuc_autotest
--test-args=3D"--no-huge --no-pci --vdev=3Dcrypto_zuc"
ninja: no work to do.
ninja: Entering directory `/opt/dpdk/build'
ninja: no work to do.
1/1 DPDK:driver-tests / cryptodev_sw_zuc_autotest        OK
0.22s

Ok:                 1
Expected Fail:      0
Fail:               0
Unexpected Pass:    0
Skipped:            0
Timeout:            0

Usually when we install dependencies we go from a tag which is stable.
We'll update the dpdk-ci container image template engine to clone the repo
and then checkout to this commit which is known to be
good: cef9b8924e3ff52f2c5a3703860008c27ee723c4. And our automated testing
can remain online in this way.

Arm folks, I'm not sure what your plans are but at some point in the docs I
think pages like:

https://doc.dpdk.org/guides/cryptodevs/zuc.html
https://doc.dpdk.org/guides/cryptodevs/snow3g.html

should be updated to reference this commit, or a newly introduced tag, to
reflect that the SECLIB-IPSEC-2023.06.20 tag will no longer work for 24.03
as it is ipsec 1.3.

Thanks for the help.

--000000000000be2d8e0611e911f5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Wed, Feb 21, 2024 at 4:50=E2=80=AF=
AM Power, Ciara &lt;<a href=3D"mailto:ciara.power@intel.com">ciara.power@in=
tel.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"=
margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-lef=
t:1ex"><br>
Hi folks,<br>
<br>
We had based the ipsec-mb version bump to 1.4 on both intel ipsec-mb and ar=
m ipsec-mb supporting that version, so both could still use the Ipsec-mb SW=
 PMDs.<br>
I based the arm support from the repo main branch (<a href=3D"https://gitla=
b.arm.com/arm-reference-solutions/ipsec-mb/-/tree/main" rel=3D"noreferrer" =
target=3D"_blank">https://gitlab.arm.com/arm-reference-solutions/ipsec-mb/-=
/tree/main</a>)<br>
It&#39;s version is 1.4 and looks like some of the code changes from intel-=
ipsec-mb 1.4 have been merged in (e.g. imb_set_session function which is 1.=
4+).<br>
I know there was issues before with it being tagged as 1.4 too soon - is th=
at still the case, or is the main branch up to date now with intel-ipsec-mb=
 1.4?<br>
<br>
Thanks,<br>
Ciara<br>
</blockquote></div><div><br></div><div>Hi Ciara,</div><div><br></div><div>I=
 see what you mean and did a test on an arm container. I used tip of main f=
or ipsec-mb, applied the v1.4 requirement patch to dpdk, built dpdk and was=
 able to run the ZUC autotest with the=C2=A0zuc vdev pmd.=C2=A0</div><div><=
br></div><div>root@8aad8acde315:/opt/dpdk/build# meson test cryptodev_sw_zu=
c_autotest --test-args=3D&quot;--no-huge --no-pci --vdev=3Dcrypto_zuc&quot;=
<br>ninja: no work to do.<br>ninja: Entering directory `/opt/dpdk/build&#39=
;<br>ninja: no work to do.<br>1/1 DPDK:driver-tests / cryptodev_sw_zuc_auto=
test =C2=A0 =C2=A0 =C2=A0 =C2=A0OK =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 0.22s<br><br>Ok: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 1 =C2=A0 <br>Expected Fail: =C2=A0 =C2=A0 =C2=A00 =C2=A0 <br>Fai=
l: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0 =C2=A0 <br>Unexpected=
 Pass: =C2=A0 =C2=A00 =C2=A0 <br>Skipped: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A00 =C2=A0 <br>Timeout: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A00=
=C2=A0=C2=A0</div><div><br></div><div>Usually when we install dependencies =
we go from a tag which is stable. We&#39;ll update the dpdk-ci container im=
age template engine to clone the repo and then checkout to this commit whic=
h is known to be good:=C2=A0cef9b8924e3ff52f2c5a3703860008c27ee723c4. And o=
ur automated testing can remain online in this way.</div><div><br></div><di=
v>Arm folks, I&#39;m not sure what your plans are but at some point in the =
docs I think pages like:<br><br><a href=3D"https://doc.dpdk.org/guides/cryp=
todevs/zuc.html">https://doc.dpdk.org/guides/cryptodevs/zuc.html</a><br></d=
iv><div><a href=3D"https://doc.dpdk.org/guides/cryptodevs/snow3g.html">http=
s://doc.dpdk.org/guides/cryptodevs/snow3g.html</a><br></div><div><br></div>=
<div>should be updated to reference this commit, or a newly introduced tag,=
 to reflect that the=C2=A0SECLIB-IPSEC-2023.06.20 tag will no longer work f=
or 24.03 as it is ipsec 1.3.=C2=A0</div><div><br></div><div>Thanks for the =
help.</div><div>=C2=A0<br></div></div>

--000000000000be2d8e0611e911f5--